Re: [PATCH v3 08/16] normal: Add fw_path variable (revised)

2024-10-15 Thread Vladimir 'phcoder' Serbinenko
Le mar. 15 oct. 2024, 08:24, Michael Chang via Grub-devel < grub-devel@gnu.org> a écrit : > On Thu, Oct 10, 2024 at 03:43:26PM GMT, Leo Sandoval wrote: > > From: Paulo Flabiano Smorigo > > > > This patch makes grub look for its config file on efi where the app was > > found. It was originally wri

[grub-mkconfig] Unable to modify current generating grub.cfg

2024-10-15 Thread Guillaume Hilt via Grub-devel
Hello, Since our bug was closed and we were asked to submit it here to upstream, here we are : https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/2052381 When you want to "alterate" current generating grub.cfg.new in /etc/grub.d/* scripts, you cant sed -i in /boot/grub/grub.cfg.new due to

Re: [PATCH] kern/fs: honour file->read_hook in grub_fs_blocklist_read()

2024-10-15 Thread Daniel Kiper
On Fri, Oct 11, 2024 at 08:12:59PM +0200, Rasmus Villemoes via Grub-devel wrote: > "Vladimir 'phcoder' Serbinenko" writes: > > > Reviewed-by: phco...@gmail.com Reviewed-by: Daniel Kiper > Thanks. Can this be picked up, please? I will take it together with other patches in next round... Daniel

Re: [PATCH] Add NVMe driver for native targets

2024-10-15 Thread Daniel Kiper
On Sun, Oct 13, 2024 at 10:40:41PM +0300, Vladimir 'phcoder' Serbinenko wrote: > Thank you for your effort but we already have nvme driver in the review queue. > See my email from 16th of May I concur. It looks it is even smaller. Mate, could you take a look at Vladimir's patch? Daniel _

Re: [PATCH] lockdown: Defer authorization for anything not in allowlist

2024-10-15 Thread Daniel Kiper
On Fri, Oct 11, 2024 at 05:23:04PM +0200, Julian Andres Klode wrote: > Copy the list of things that do not affect secure boot state from > the shim_lock verifier to the lockdown verifier, and change the code > there to defer for anything not in that list, rather than known > images. > > This preven

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-15 Thread Neal Gompa
On Tue, Oct 8, 2024 at 2:59 AM Michael Chang via Grub-devel wrote: > > On Mon, Oct 07, 2024 at 09:40:40PM GMT, Vladimir 'phcoder' Serbinenko wrote: > > What do you try to achieve with this that can't be achieved with using full > > path? We should avoid using hidden state for directory parsing. So

[PATCH] acpi: Fix out of bounds access in grub_acpi_xsdt_find_table()

2024-10-15 Thread Benjamin Herrenschmidt
The calculation of the size of the table was incorrect (copy/pasta from grub_acpi_rsdt_find_table() I assume...). The entries are 64-bit long. This causes us to access beyond the end of the table which is causing crashes during boot on some systems. Typically this is causing a crash on VMWare when

Re: [PATCH] Re-order grub_serial_find to fix default to com0 on some platforms

2024-10-15 Thread Benjamin Herrenschmidt
On Tue, 2024-10-15 at 11:10 -0700, Adam Williamson wrote: > > 7b192ec4c rejigged the serial port detection code when no port > is explicitly specified. Before 7b192ec4c we did > grub_serial_find ("com0") in this case, which on *any* platform > would return a port called "com0" if one was found, ot

Re: [PATCH] Re-order grub_serial_find to fix default to com0 on some platforms

2024-10-15 Thread Adam Williamson
On Wed, 2024-10-16 at 14:19 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2024-10-15 at 11:10 -0700, Adam Williamson wrote: > > > > 7b192ec4c rejigged the serial port detection code when no port > > is explicitly specified. Before 7b192ec4c we did > > grub_serial_find ("com0") in this case, which

[PATCH] Re-order grub_serial_find to fix default to com0 on some platforms

2024-10-15 Thread Adam Williamson
NOTE, NOT PART OF COMMIT MESSAGE: I am not at all used to the email- based workflow, I don't typically contribute to projects that use it, I am used to pull requests. I don't have the git email stuff set up at all. This email is manually produced by copy/pasting the 'git show' output. Sorry if this