Re: [PATCH v1 25/37] grub.texi: Make our info pages say "grub2" where appropriate.

On 10/7/24 11:20 AM, Leo Sandoval wrote: From: Peter Jones This needs to be hooked up to --program-transform=, but I haven't had time. Can you explain/expand on this? It is not clear (to me) what that means. Is something missing from this patch? Thanks Ross Signed-off-by: Peter Jones -

[PATCH v2 10/17] 10_linux.in: Add devicetree loading

From: Peter Jones Signed-off-by: Peter Jones Switch to use APM Mustang device tree, for hardware testing. Signed-off-by: David A. Marlin Use the default device tree from the grub default file instead of hardcoding a value. Signed-off-by: David A. Marlin --- util/grub-mkconfig.in | 3 +

[PATCH v2 17/17] normal/main: Try $prefix if $fw_path doesn't work.

From: Peter Jones Related: rhbz#1148652 Signed-off-by: Peter Jones --- grub-core/kern/ieee1275/init.c | 28 +++ grub-core/net/net.c| 2 +- grub-core/normal/main.c| 132 - 3 files changed, 81 insertions(+), 81 deletions(-) diff --git a

[PATCH v2 14/17] normal/main: fw_path prefix when fallback searching for grub config

From: Fedora Ninjas When PXE booting via UEFI firmware, grub was searching for grub.cfg in the fw_path directory where the grub application was found. If that didn't exist, a fallback search would look for config file names based on MAC and IP address. However, the search would look in the prefix

[PATCH v2 01/17] ieee1275/openfw: IBM client architecture (CAS) reboot support

From: Paulo Flabiano Smorigo This is an implementation of IBM client architecture (CAS) reboot for GRUB. There are cases where the POWER firmware must reboot in order to support specific features requested by a kernel. The kernel calls ibm,client-architecture-support and it may either return or

[PATCH v2 15/17] normal/main: Try mac/guid/etc before grub.cfg on tftp config files.

From: Peter Jones Signed-off-by: Peter Jones --- grub-core/normal/main.c | 93 ++--- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c index fd8be685a..973e7d733 100644 --- a/grub-core/normal/mai

[PATCH v2 16/17] 10_linux.in: Generate OS and CLASS in 10_linux from /etc/os-release

From: Peter Jones This makes us use pretty names in the titles we generate in grub2-mkconfig when GRUB_DISTRIBUTOR isn't set. Resolves: rhbz#996794 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/grub.d/10_linux

[PATCH v1 21/37] efinet and bootp: add support for dhcpv6

From: Peter Jones Signed-off-by: Peter Jones --- grub-core/net/bootp.c | 173 + grub-core/net/drivers/efi/efinet.c | 86 +- grub-core/net/net.c| 72 grub-core/net/tftp.c | 3 + include/grub/efi/a

[PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c| 195 +++- grub-core/osdep/linux/getroot.c | 148 +++- include/grub/emu/getroot.h | 5 + util/grub-install.c |

[PATCH v1 00/37] Second Distro-agnostic series taken from Fedora Rawhide

This is the second patch series, first version, taken from Fedora Rawhide spec [1] that are distro-agnostic. The goal is to merge most of them so all the community/distros would benefit. Andrei Borzenkov (1): btrfs: Fallback to old subvol name scheme to support old snapshot config Jeff Ma

[PATCH v1 18/37] 10_linux.in: Make grub2-mkconfig construct titles that look like the ones we want elsewhere.

From: Peter Jones Resolves: rhbz#1215839 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index 3105c31e4..0115dd0c0 100644 --- a/util

[PATCH v1 20/37] net/tcp: add window scaling support

From: Josef Bacik Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, which is not ideal. So add tcp window scaling on open connections and

[PATCH v1 25/37] grub.texi: Make our info pages say "grub2" where appropriate.

From: Peter Jones This needs to be hooked up to --program-transform=, but I haven't had time. Signed-off-by: Peter Jones --- docs/grub-dev.texi| 4 +- docs/grub.texi| 359 ++ grub-core/kern/misc.c | 2 +- 3 files changed, 191 insertions(+

[PATCH v1 37/37] chainloader: Use grub_efi_...() memory helpers where reasonable.

From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. Signed-off-by: Peter Jones --- grub-core/loader/efi/chainloader.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v1 36/37] efi: Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

From: Peter Jones Signed-off-by: Peter Jones --- include/grub/efi/efi.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..8d98203a7 100644 --- a/include/grub/efi/efi.h +++ b/

[PATCH v1 35/37] btrfs: Grub not working correctly with btrfs snapshots (bsc#1026511)

From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 238 +++ 1 file changed, 238 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index dba86d19b..87e4dd1a0 100644 --- a/grub-co

[PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/osdep/linux/getroot.c | 7 +++ grub-core/osdep/unix/config.c | 17 +++-- include/grub/emu/config.h | 1 + util/config.c | 10 ++ util/grub-install.c

[PATCH v1 29/37] btrfs: export btrfs_subvol and btrfs_subvolid

From: Michael Chang We should export btrfs_subvol and btrfs_subvolid to have both visible to subsidiary configuration files loaded using configfile. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/b

[PATCH v1 28/37] btrfs: fix a bad null check

From: Peter Jones current gcc complains: grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate as ‘true’ for the address of ‘label’ will never be NULL [-Werror=address] 2745 | if (data->sblock.label) |

[PATCH v1 26/37] 30_os-prober.in: just build chainloader entries, don't try any xnu xnu.

From: Peter Jones Since our bugs tell us that the xnu boot entries really just don't work most of the time, and they create piles of extra boot entries, because they can't quite figure out 32-vs-64 and other stuff like that. It's rediculous, and we should just boot their bootloader through the c

[PATCH v2 02/17] term/terminfo: for ppc, reset console display attr when clear screen

From: Paulo Flabiano Smorigo v2: Also use \x0c instead of a literal ^L to make future patches less awkward. This should fix this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=908519 Signed-off-by: Peter Jones Signed-off-by: Paulo Flabiano Smorigo Signed-off-by: Robbie Harwood --- gr

[PATCH v2 03/17] ieee1275: Disable GRUB video support for IBM power machines

From: Paulo Flabiano Smorigo Disable GRUB Video Support from IBM Power Machines. This patch fixes what is describe above and should fix https://bugzilla.redhat.com/show_bug.cgi?id=973205. C&P the bz problem's description: Grub crashes if it tries to run in video mode. I'm currently testing wit

[PATCH v2 09/17] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

From: Peter Jones Don't munge raw spaces when we're doing our cmdline escaping (#923374) Signed-off-by: Peter Jones --- grub-core/commands/wildcard.c | 16 - grub-core/lib/cmdline.c | 25 ++-- grub-core/script/execute.c| 43 ++--

[PATCH v2 08/17] normal: Add fw_path variable (revised)

From: Paulo Flabiano Smorigo This patch makes grub look for its config file on efi where the app was found. It was originally written by Matthew Garrett, and adapted to fix the "No modules are loaded on grub2 network boot" issue: https://bugzilla.redhat.com/show_bug.cgi?id=857936 Signed-off-by:

[PATCH v2 12/17] Makefile.common: Add .eh_frame to list of relocations stripped

From: Fedora Ninjas Signed-off-by: Peter Jones --- conf/Makefile.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.common index b8f216f6c..ece9ed8a1 100644 --- a/conf/Makefile.common +++ b/conf/Makefile.common @@ -41,7 +41,7 @@ CFLAG

[PATCH v2 11/17] 00_header.in: Enable pager by default. (#985860)

From: Peter Jones Signed-off-by: Peter Jones --- util/grub.d/00_header.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index 6a316a5ba..c2d8b0937 100644 --- a/util/grub.d/00_header.in +++ b/util/grub.d/00_header.in @@ -43,6 +43,8 @@ i

[PATCH v2 05/17] misc: Make "exit" take a return code.

From: Peter Jones This adds "exit" with a return code. With this patch, any "exit" command /may/ include a return code, and on platforms that support returning with an exit status, we will do so. By default we return the same exit status we did before this patch. Signed-off-by: Peter Jones --

[PATCH v2 07/17] 20_ppc_terminfo.in: Migrate ieee1275/PPC from Yaboot to Grub2

From: Mark Hamzy Add configuration support for ieee1275/PPC ofconsole serial terminal. Signed-off-by: Mark Hamzy Signed-off-by: Robbie Harwood --- Makefile.util.def | 7 ++ util/grub.d/20_ppc_terminfo.in | 114 + 2 files changed, 121 insertions(+

[PATCH v2 04/17] configure.ac: Move bash completion script

From: Peter Jones Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=922997 Apparently these go in a new place now. --- configure.ac | 11 +++ util/bash-completion.d/Makefile.am | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/configure.ac

[PATCH v2 00/17] First Distro-agnostic series taken from Fedora Rawhide

This is the first patch series, second version, taken from Fedora Rawhide spec [1] that are distro-agnostic. The goal is to merge most of them so all the community/distros would benefit. Changes since v1: - deleted0005-Allow-fallback-to-include-entries-by-title-not-just-.patch no longer su

[PATCH v2 13/17] 10_linux.in: Don't require a password to boot entries generated by grub-mkconfig.

From: Peter Jones When we set a password, we just want that to mean you can't /edit/ an entry. Resolves: rhbz#1030176 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in in

[PATCH v2 06/17] efi/init: Make efi machines load an env block from a variable

From: Peter Jones Signed-off-by: Peter Jones --- grub-core/Makefile.core.def | 1 + grub-core/kern/efi/init.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 1571421d7..0bffbfea9 100644 -

[PATCH v1 22/37] bootp: New net_bootp6 command

From: Michael Chang Implement new net_bootp6 command for IPv6 network auto configuration via the DHCPv6 protocol (RFC3315). Signed-off-by: Michael Chang Signed-off-by: Ken Lin [pjones: Put back our code to add a local route] Signed-off-by: Peter Jones --- grub-core/net/bootp.c |

[PATCH v1 30/37] btrfs: grub2-btrfs-03-follow_default

From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 107 ++- 1 file changed, 76 insertions(+), 31 deletions(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index 14e38a4df..d47f9ab03 1006

[PATCH v1 32/37] btdfs: grub2-btrfs-05-grub2-mkconfig

From: Michael Chang Signed-off-by: Michael Chang --- util/grub-mkconfig.in | 3 ++- util/grub-mkconfig_lib.in | 4 util/grub.d/00_header.in| 25 - util/grub.d/10_linux.in | 4 util/grub.d/20_linux_xen.in | 4 5 files changed, 38 inserti

[PATCH v1 23/37] grub-get-kernel-settings.in: Add grub-get-kernel-settings and use it in 10_linux

From: Peter Jones This patch adds grub-get-kernel-settings, which reads the system kernel installation configuration from /etc/sysconfig/kernel, and outputs ${GRUB_...} variables suitable for evaluation by grub-mkconfig. Those variables are then used by 10_linux to choose whether or not to creat

[PATCH v1 19/37] grub-set-password.in: Add friendly grub2 password config tool (#985962)

From: Robert Marshall Provided a tool for users to reset the grub2 root user password without having to alter the grub.cfg. The hashed password now lives in a root-only-readable configuration file. Resolves: rhbz#985962 Signed-off-by: Robert Marshall [pjones: fix the efidir in grub-setpassword

[PATCH v1 27/37] btrfs: Add ability to boot from subvolumes

From: Jeff Mahoney This patch adds the ability to specify a different root on a btrfs filesystem too boot from other than the default one. btrfs-list-snapshots will list the subvolumes available on the filesystem. set btrfs_subvol= and set btrfs_subvolid= will specify which subvolume to use an

[PATCH v1 24/37] backtrace: Make grub_fatal() also backtrace

From: Peter Jones --- grub-core/Makefile.core.def | 3 ++ grub-core/kern/misc.c | 6 grub-core/lib/arm64/backtrace.c | 62 + grub-core/lib/backtrace.c | 2 ++ grub-core/lib/i386/backtrace.c | 14 +++- 5 files changed, 86 insertions

[PATCH v1 34/37] btrfs: Fallback to old subvol name scheme to support old snapshot config

From: Andrei Borzenkov Ref: bsc#953538 --- grub-core/fs/btrfs.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index d44a1c73b..dba86d19b 100644 --- a/grub-core/fs/btrfs.c +++ b/grub-core/fs/btrfs.c

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

What do you try to achieve with this that can't be achieved with using full path? We should avoid using hidden state for directory parsing. Solaris GRUB legacy used it for ZFS and it was a mess. Le lun. 7 oct. 2024, 21:22, Leo Sandoval a écrit : > From: Michael Chang > > Signed-off-by: Michael

Re: [PATCH] lvm: allocate metadata buffer from raw contents

On 10/3/24 8:40 PM, Michael Chang via Grub-devel wrote: On Thu, Oct 03, 2024 at 10:30:15AM GMT, ross.philip...@oracle.com wrote: On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: Previously, the buffer for LVM metadata parsing was set to twice the size of the metadata area, which caused

Re: [PATCH v2 09/17] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

On 10/7/24 11:18 AM, Leo Sandoval wrote: From: Peter Jones Don't munge raw spaces when we're doing our cmdline escaping (#923374) Signed-off-by: Peter Jones --- grub-core/commands/wildcard.c | 16 - grub-core/lib/cmdline.c | 25 ++-- grub-core/script/exec

Re: [PATCH v1 37/37] chainloader: Use grub_efi_...() memory helpers where reasonable.

On 10/7/24 11:21 AM, Leo Sandoval wrote: From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. While the idea of putting wrappers around the EFI pool allocation c

Re: [PATCH v2 11/17] 00_header.in: Enable pager by default. (#985860)

This has a danger of rendering headless systems unbootable while waiting for user input Le lun. 7 oct. 2024, 21:19, Leo Sandoval a écrit : > From: Peter Jones > > Signed-off-by: Peter Jones > --- > util/grub.d/00_header.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/util/grub.d

Re: [PATCH v2 03/17] ieee1275: Disable GRUB video support for IBM power machines

Can you add a short comment in cmain why it's needed? It should mention 32-bit address truncation. The story in the commit message, on the other hand, is way too long. It needs to be summarized with a link to full story. Le lun. 7 oct. 2024, 21:19, Leo Sandoval a écrit : > From: Paulo Flabiano S

Re: [PATCH v1 25/37] grub.texi: Make our info pages say "grub2" where appropriate.

Upstream uses "grub" for these commands. Rename to "grub2" is distro-specific Le lun. 7 oct. 2024, 21:23, Leo Sandoval a écrit : > From: Peter Jones > > This needs to be hooked up to --program-transform=, but I haven't had > time. > > Signed-off-by: Peter Jones > --- > docs/grub-dev.texi|

Re: [PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

On Tue, Oct 08, 2024 at 08:07:17AM GMT, Vladimir 'phcoder' Serbinenko wrote: > Again, what do you try to achieve? Why aren't absolute paths enough? The absolute path does not align with the default subvolume. As a result, after running btrfs set-default , the system does not boot the new default s

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

On Mon, Oct 07, 2024 at 09:40:40PM GMT, Vladimir 'phcoder' Serbinenko wrote: > What do you try to achieve with this that can't be achieved with using full > path? We should avoid using hidden state for directory parsing. Solaris > GRUB legacy used it for ZFS and it was a mess. If a path is relativ

Re: [PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

Again, what do you try to achieve? Why aren't absolute paths enough? Le lun. 7 oct. 2024, 21:23, Leo Sandoval a écrit : > From: Michael Chang > > Signed-off-by: Michael Chang > Signed-off-by: Robbie Harwood > --- > grub-core/osdep/linux/getroot.c | 7 +++ > grub-core/osdep/unix/config.c

Re: [PATCH v1 28/37] btrfs: fix a bad null check

LGTM Reviewed-by: Vladimir Serbinenko phco...@gmail.com Le lun. 7 oct. 2024, 21:23, Leo Sandoval a écrit : > From: Peter Jones > > current gcc complains: > > grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: > grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate >

Re: [PATCH v1 24/37] backtrace: Make grub_fatal() also backtrace

This increases the core size on i386-pc needlessly. And will increase even more when we improve backtrace command. This needs to be a hook and loaded together with normal. Also it needs to be cpu-agnostic Le lun. 7 oct. 2024, 21:22, Leo Sandoval a écrit : > From: Peter Jones > > --- > grub-cor