Re: [PATCH 0/4] Various test fixes proposed by Thomas Schmitt

2024-10-02 Thread Thomas Schmitt via Grub-devel
Hi, i wrote: > > Assuming variable "xfail" is be set to a non-empty string exactly if > > argument "--xfail" is given, i'd replace: > > > > if [ -z "$debug" ] && [ "${RET:-1}" -eq 0 ]; then > > rm -rf "$lukstestdir" || : > > fi Glenn Washburn wrote: > RET should never be undefined

Re: [PATCH 08/20] 20_ppc_terminfo.in: Migrate PPC from Yaboot to Grub2

2024-10-02 Thread Leo Sandoval
On Mon, Sep 30, 2024 at 12:57 PM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Why is it ppc-specific? > IBM wrote this patch so this is why this is ppc specific, but you are right, it can apply to all archs. I will send a v2. > > Le lun. 30 sept. 2024, 20:49, Leo Sandoval a écr

Re: [PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number.

2024-10-02 Thread Leo Sandoval
On Mon, Sep 30, 2024 at 1:03 PM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > Using titles is broken concept and the only reason we support it in > default is backwards compatibility. Maybe it's better to restrict it to > just IDs > > The word 'title' is still on the doc https://www.

Re: [PATCH 03/20] ieee1275: Disable GRUB video support for IBM power machines

2024-10-02 Thread Leo Sandoval
On Mon, Sep 30, 2024 at 1:07 PM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > This needs a detailed comment in quirks code as to why we disable video > mode. > Agree. Let me include it in v2. > > Le lun. 30 sept. 2024, 20:47, Leo Sandoval a écrit : > >> From: Paulo Flabiano Smori

Re: [PATCH 08/20] 20_ppc_terminfo.in: Migrate PPC from Yaboot to Grub2

2024-10-02 Thread Vladimir 'phcoder' Serbinenko
Looking at the patch: it's specific to ieee1275 not PPC. The reason is that it operates on ofconsole. But then it means that the patch description doesn't really match the intent. And neither does the name of the variable as it's specific to ofconsole Le mer. 2 oct. 2024, 20:12, Leo Sandoval a éc

Re: [PATCH 11/20] blscfg: add blscfg module to parse Boot Loader Specification snippets

2024-10-02 Thread Leo Sandoval
On Mon, Sep 30, 2024 at 1:09 PM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > This is already being reviewed in separate thread > I did not see a similar patch being reviewed before sending the series, so I will drop it. if possible, can you send the grub-devel archive link? I could