make check as superuser leaves empty directories in /-directory

2024-07-24 Thread Thomas Schmitt via Grub-devel
Hi, i find in the root directory of my system a lot of empty directories like /1678114331.LUKS1_test_with_twofish_cipher /1678114333.LUKS1_test_key_file_support I believe they come from tests/grub_cmd_cryptomount.in where i read eval testcase "'LUKS1 test with twofish cipher:'" \ @bu

Re: make check as superuser leaves empty directories in /-directory

2024-07-24 Thread Thomas Schmitt via Grub-devel
Hi, i believe to have found out what's wrong with TMPDIR in tests/grub_cmd_cryptomount.in It does not get assigned a default value and is used without such a value. Many other tests have the following gesture before using $TMPDIR: : "${TMPDIR=/tmp}" But grub_cmd_cryptomount.in has not and u

[PATCH] tests: Let grub_cmd_cryptomount by default operate in /tmp rather than in /

2024-07-24 Thread Thomas Schmitt via Grub-devel
If not TMPDIR is set by the user then the test grub_cmd_cryptomount creates about 20 directories named *LUKS*_test* in the root directory and leaves them there when the test ends. Initialize in the test script the variable TMPDIR to /tmp if it is not set or if it set to empty text. To be consisten

Re: make check as superuser leaves empty directories in /-directory

2024-07-24 Thread Thomas Schmitt via Grub-devel
Hi, with the freshly submitted patch applied, i see as superuser: # make check TESTS=grub_cmd_cryptomount ... PASS: grub_cmd_cryptomount ... # echo $? 0 # No new directories appeared in the root directory. During the "make check" run i could spot single files /tmp/*LUKS* which did