Re: [PATCH] Mandatory install device check for PowerPC

2024-05-29 Thread avnish
Hi Michal, Thank you so much for a response! We'll work on to figure out the type of machine. On no_prep, as per my analysis. Even with no install device given while installing. We observe boot corruption on some specific setups (mostly where we have multiple valid PReP partition available on

Re: [PATCH v3 1/5] Import libgcrypt 1.10.3

2024-05-29 Thread Daniel Kiper
Could you add your SOB and a few words to the commit message explaining why this patch is needed. It would be nice if you add a cover letter to this patch set too. Daniel On Fri, May 24, 2024 at 08:30:02PM +0300, Vladimir Serbinenko wrote: > --- > grub-core/lib/libgcrypt/AUTHORS |

Re: [PATCH v3 2/5] Import b64dec from gpg-error

2024-05-29 Thread Daniel Kiper
Why this file is needed? From which GPG version this file come from? And missing SOB... On Fri, May 24, 2024 at 08:30:03PM +0300, Vladimir Serbinenko wrote: > --- > grub-core/lib/b64dec.c | 293 + > 1 file changed, 293 insertions(+) > create mode 100644 gr

Re: [PATCH v3 3/5] Adjust import script, definitions and API users for libgcrypt 1.10

2024-05-29 Thread Daniel Kiper
Again, missing commit message and SOB. Could you add to the GRUB Developers Manual description how to upgrade the libgcrypt? On Fri, May 24, 2024 at 08:30:04PM +0300, Vladimir Serbinenko wrote: > --- > autogen.sh | 5 + > conf/Makefile.common

Re: [PATCH v3 4/5] Add DSA and RSA SEXP tests

2024-05-29 Thread Daniel Kiper
Same comments as for earlier patches... On Fri, May 24, 2024 at 08:30:05PM +0300, Vladimir Serbinenko wrote: > --- > grub-core/tests/dsa_sexp_test.c | 107 > grub-core/tests/rsa_sexp_test.c | 81 > 2 files changed, 188 insertions(+) > cr

Re: [PATCH v3 5/5] keccak: Disable acceleration with SSE asm

2024-05-29 Thread Daniel Kiper
Same comments as for earlier patches... Thank you for moving this to separate patch. On Fri, May 24, 2024 at 08:30:06PM +0300, Vladimir Serbinenko wrote: > --- > .../lib/libgcrypt-patches/02_keccak_sse.diff | 19 +++ > 1 file changed, 19 insertions(+) > create mode 100644 grub-