Need help: alternative module inclusion - duplicate symbols

2024-02-26 Thread Michael Lawnick via Grub-devel
Hi group, hope you can help me: I have modules pci_fpga.c and pci_fpga_emul.c with same functions in them but different implementation, one for the real device, the other one is just emulating. What I now want is being able to include one of both versions through build command. I started with thi

Re: Need help: alternative module inclusion - duplicate symbols

2024-02-26 Thread Michael Lawnick via Grub-devel
Using function pointers solves the duplicate symbol problem. But still there is a way needed to get the information passed into build. FPGA is so essential in my use case that the configuration must be compiled-in. But as the sources are under git a #define is not a good option. Am 26.02.2024 um 1

Re: Need help: alternative module inclusion - duplicate symbols

2024-02-26 Thread Vladimir 'phcoder' Serbinenko
You can add a dispatcher which switches between 2 modules. E.g. real_do_stuff (...); fake_do_stuff(...); static int (*do_stuff)( ...); And switch pointer between 2 implementations. See terminal output and grub_xputs for examples On Mon, Feb 26, 2024 at 1:51 PM Michael Lawnick via Grub-devel wrot

Re: [PATCH] Skip tests if tool/dependency is not installed

2024-02-26 Thread Glenn Washburn
On Wed, 14 Feb 2024 11:13:43 +0530 Krishan Gopal wrote: > Hi Glenn, > > On 02/02/24 2:59 am, Glenn Washburn wrote: > > Hi Krishan, > > > > On Tue, 30 Jan 2024 04:18:13 -0600 > > Krishan Gopal Saraswat wrote: > > > >> Currently many tests ends up in an ERROR state due to the environment not > >>

Re: grub keyfile read errors support

2024-02-26 Thread Glenn Washburn
On Mon, 12 Feb 2024 15:36:40 +0300 Alexey Kuznetsov wrote: > Hello John! > > I see your commit 81b2f625f54cb670e36739e3a599daafd34bc44a, about > adding key-file support. This is great! I've been waiting for grub > official support for removable key-file support for a long time. > > I suppose gr

Re: grub keyfile read errors support

2024-02-26 Thread Alexey Kuznetsov
> > If so. Then why does your allow users to remove a removable key? > > I don't understand this, can you rephrase the question? > I have two separate drives: a boot device and a usb flash drive with a key. If I have a usb flash drive attached, grub should automatically unlock the main drive using