Re: [PATCH v3 2/2] disk: increase sector size up to 127 for LBA reads

2024-02-08 Thread Daniel Kiper
On Tue, Jan 30, 2024 at 10:34:33PM +0300, ValdikSS via Grub-devel wrote: > Increase the value from 63 to speed up reading process. > > This commit increases two limits: the low-level int 13h reading code > and a high-level reading code with disk cache. > The disk cache imposes an overall limitation

Re: [PATCH] Revert "templates: Reinstate unused version comparison functions with warning"

2024-02-08 Thread Daniel Kiper
On Tue, Jan 30, 2024 at 01:59:43PM +0100, Julian Andres Klode wrote: > We reinstated these functions before the 2.12 release with a warning > such that users upgrading to 2.12 who had custom scripts using them > would not get broken in the upgrade, and agreed to remove them after > the 2.12 release

Re: [PATCH] util/bash-completion: Load scripts on demand

2024-02-08 Thread Daniel Kiper
On Tue, Jan 30, 2024 at 02:41:10PM +0800, Gary Lin via Grub-devel wrote: > There are two system directories for bash-completion scripts. One is > /usr/share/bash-completion/completions and the other is > /etc/bash_completion.d/. The 'etc' scripts are loaded in advance and > for backward compatibili

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

2024-02-08 Thread Daniel Kiper
On Mon, Jan 29, 2024 at 04:37:30PM -0500, Patrick Plenefisch wrote: > In an effort to solve > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 > for myself, I implemented basic support for cachevol and integrity volumes in > LVM. > > This is just an extension of the cachepool support that

Re: [PATCH] grub-install: Use `GRUB_DISTRIBUTOR` value as EFI boot option title

2024-02-08 Thread Daniel Kiper
On Thu, Feb 01, 2024 at 10:09:04AM +, Mate Kukri wrote: > We are going to be shipping something like this in Ubuntu as we would > like our boot entries to be called "Ubuntu" instead of "ubuntu". > > I wonder if other users of GRUB would find this naming approach > better, I could gate this behi

Re: Proposal: disaggregated kernel parameters for Linux

2024-02-08 Thread Daniel Kiper
Hi, On Fri, Feb 02, 2024 at 09:58:06AM +, Simon Rowe wrote: > I have a suggestion I’d like to have feedback on regarding the management of > Linux kernel parameters. >   > Today the parameters for a Linux menu entry have to be specified in the > GRUB_CMDLINE_LINUX entry of /etc/default/grub. T

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

2024-02-08 Thread Patrick Plenefisch
Hmm, what would the logical parts be? The solution for both cachevol and integrity is the same. I do know another part needs to be added as I still need to investigate some warnings, but I'll likely need to do that this weekend when I have some more time. Patric On Thu, Feb 8, 2024 at 11:57 AM D

Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2

2024-02-08 Thread Daniel Kiper
Hey, Adding Patrick... On Mon, Feb 05, 2024 at 03:39:33PM +0800, Gary Lin wrote: > GIT repo for v9: https://github.com/lcp/grub2/tree/tpm2-unlock-v9 > > This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by > Hernan Gatta to introduce the key protector framework and TPM2 stack >

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

2024-02-08 Thread Daniel Kiper
On Thu, Feb 08, 2024 at 02:52:37PM -0500, Patrick Plenefisch wrote: > Hmm, what would the logical parts be? The solution for both cachevol and > integrity is the same. It seems to me at least code refactoring which you are doing could be taken out to a separate patch. Maybe something else... Anywa

Re: [PATCH v3 2/2] disk: increase sector size up to 127 for LBA reads

2024-02-08 Thread Vladimir 'phcoder' Serbinenko
I have few concerns: 1. The name of your patch is misleading. You don't increase sector size 2. This increases memory pressure on systems that are already low on usable memory. Sparc64 comes to mind. Due to the way how off handles memory map there, even if you have a terabyte of RAM, only few MiB a

Critical Boot Loader Vulnerability in Shim Impacts Nearly All Linux Distros

2024-02-08 Thread Turritopsis Dohrnii Teo En Ming via Grub-devel
Subject: Critical Boot Loader Vulnerability in Shim Impacts Nearly All Linux Distros Good day from Singapore, I have just come across this article. Article: Critical Boot Loader Vulnerability in Shim Impacts Nearly All Linux Distros Link: https://thehackernews.com/2024/02/critical-bootloader-

Re: Critical Boot Loader Vulnerability in Shim Impacts Nearly All Linux Distros

2024-02-08 Thread Vladimir 'phcoder' Serbinenko
Shim is not a component of grub Le ven. 9 févr. 2024, 07:41, Turritopsis Dohrnii Teo En Ming via Grub-devel a écrit : > Subject: Critical Boot Loader Vulnerability in Shim Impacts Nearly All > Linux Distros > > Good day from Singapore, > > I have just come across this article. > > Article: Criti