Re: [PATCH 0/3] Clean up unused values

2024-01-26 Thread Nikolaos Chatzikonstantinou
If I may add a small point, apart from the invariant being kept, initializing on definition also makes bug behavior more deterministic. Hunting for a bug that only manifests on certain uninitialized values in memory is hard. On Thu, Jan 25, 2024 at 5:32 PM Vladimir 'phcoder' Serbinenko wrote: > >

Re: State of Argon2 support

2024-01-26 Thread Nikolaos Chatzikonstantinou
On Thu, Jan 25, 2024 at 1:15 PM Daniel Kiper wrote: > > Adding Vladimir who knows GRUB history better than I... > > On Wed, Jan 24, 2024 at 01:23:55AM -0500, Nikolaos Chatzikonstantinou wrote: > > [...] > > > My apologies for the repeated messages, but I came up with just one > > more question tha

Re: State of Argon2 support

2024-01-26 Thread Patrick Steinhardt
On Fri, Jan 26, 2024 at 03:18:57AM -0500, Nikolaos Chatzikonstantinou wrote: > On Thu, Jan 25, 2024 at 1:15 PM Daniel Kiper wrote: > > > > Adding Vladimir who knows GRUB history better than I... > > > > On Wed, Jan 24, 2024 at 01:23:55AM -0500, Nikolaos Chatzikonstantinou wrote: > > > > [...] > >

Re: State of Argon2 support

2024-01-26 Thread Daniel Kiper
On Fri, Jan 26, 2024 at 03:18:57AM -0500, Nikolaos Chatzikonstantinou wrote: > On Thu, Jan 25, 2024 at 1:15 PM Daniel Kiper wrote: > > > > Adding Vladimir who knows GRUB history better than I... > > > > On Wed, Jan 24, 2024 at 01:23:55AM -0500, Nikolaos Chatzikonstantinou wrote: > > > > [...] > >

Re: State of Argon2 support

2024-01-26 Thread Daniel Kiper
On Fri, Jan 26, 2024 at 10:55:21AM +0100, Patrick Steinhardt wrote: > On Fri, Jan 26, 2024 at 03:18:57AM -0500, Nikolaos Chatzikonstantinou wrote: > > On Thu, Jan 25, 2024 at 1:15 PM Daniel Kiper wrote: > > > > > > Adding Vladimir who knows GRUB history better than I... > > > > > > On Wed, Jan 24,

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Daniel Kiper
On Wed, Jan 24, 2024 at 08:28:39AM +0100, Olaf Hering wrote: > Wed, 24 Jan 2024 06:26:37 + Alec Brown : > > > +static bool cli_disabled = false; > > Are there any other values than zero for "false"? > If not, the initialization can be removed. Even if you are technically correct I think we sho

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Daniel Kiper
On Fri, Jan 26, 2024 at 02:12:31AM +0300, Vladimir 'phcoder' Serbinenko wrote: > Please detail your use case. GRUB already had user framework in the same > problem space. I am not sure what exactly you mean by "user framework". Could you elaborate or point us code examples? Anyway, we need a mech

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 janv. 2024, 23:15, Daniel Kiper a écrit : > On Fri, Jan 26, 2024 at 02:12:31AM +0300, Vladimir 'phcoder' Serbinenko > wrote: > > Please detail your use case. GRUB already had user framework in the same > > problem space. > > I am not sure what exactly you mean by "user framework". Coul

Re: State of Argon2 support

2024-01-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 janv. 2024, 20:50, Daniel Kiper a écrit : > On Fri, Jan 26, 2024 at 03:18:57AM -0500, Nikolaos Chatzikonstantinou > wrote: > > On Thu, Jan 25, 2024 at 1:15 PM Daniel Kiper > wrote: > > > > > > Adding Vladimir who knows GRUB history better than I... > > > > > > On Wed, Jan 24, 2024 at