Re: [PATCHv2] osdep/hurd/getroot: Fix 64bit build

2024-01-25 Thread Daniel Kiper
On Tue, Jan 23, 2024 at 09:47:36PM +0100, Samuel Thibault wrote: > file_get_fs_options takes a mach_msg_type_number_t (32 bit), not a size_t > (64 bit on 64-bit platforms). > > Signed-off-by: Samuel Thibault Reviewed-by: Daniel Kiper Daniel ___ Grub-

Re: [PATCHv2] hurd: Find proper ld.so on 64-bit systems

2024-01-25 Thread Daniel Kiper
On Tue, Jan 23, 2024 at 09:47:56PM +0100, Samuel Thibault wrote: > The 64bit ABI defines ld.so to be /lib/ld-x86-64.so.1 > > Signed-off-by: Samuel Thibault Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.

Re: State of Argon2 support

2024-01-25 Thread Daniel Kiper
Adding Vladimir who knows GRUB history better than I... On Wed, Jan 24, 2024 at 01:23:55AM -0500, Nikolaos Chatzikonstantinou wrote: [...] > My apologies for the repeated messages, but I came up with just one > more question that I'm curious about. To summarize my questions: > > 1. Where is the

Re: [PATCH 0/3] Clean up unused values

2024-01-25 Thread Vladimir 'phcoder' Serbinenko
I oppose to all 3 patches. These assignments are not redundant but keep an important invariant: the variable in question can be passed to free(). For this it needs to either be NULL or point to a valid allocated memory. In this code this ensures that we never double free even after code changes Le

Re: [PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

2024-01-25 Thread Vladimir 'phcoder' Serbinenko
Le mar. 23 janv. 2024, 17:44, Daniel Kiper a écrit : > Mate, > > Next time please respond to all people/addresses in the original > email... > > On Mon, Jan 22, 2024 at 02:09:38PM +, Mate Kukri wrote: > > Dear Alec, and grub-devel, > > > > I haven't checked the specific code in question, but

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-25 Thread Vladimir 'phcoder' Serbinenko
Please detail your use case. GRUB already had user framework in the same problem space. Le mer. 24 janv. 2024, 09:27, Alec Brown a écrit : > Added functionality to disable command line interface access and editing > of GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off