Re: [PATCH 0/3] Clean up unused values

On Sat, Jan 20, 2024 at 02:52:48AM +, Alec Brown wrote: > Coverity listed three unused value bugs in the GRUB. These patches help clean > up and remove these uneccessary bits of code. > > The Coverity bugs being addressed are: > CID 428875 > CID 428876 > CID 428877 > > Alec Brown (3): > f

Re: [PATCH] tests: switch password quality check off for luks2 test

On Sun, Dec 31, 2023 at 09:21:04PM -0600, Glenn Washburn wrote: > On Fri, 29 Dec 2023 17:08:20 +0800 > Gary Lin wrote: > > > When adding/changing the password for the luks2 partition, cryptsetup > > may reject the command due to the weak password. Since this is only for > > testing, add '--force-p

Re: [PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

Mate, Next time please respond to all people/addresses in the original email... On Mon, Jan 22, 2024 at 02:09:38PM +, Mate Kukri wrote: > Dear Alec, and grub-devel, > > I haven't checked the specific code in question, but do we really want > to be removing such null-assignments? (Thinking abo

Re: [PATCH] hurd: Find proper ld.so on 64bit systems

On Sat, Jan 20, 2024 at 09:11:50PM +0100, Samuel Thibault wrote: > Signed-off-by: Samuel Thibault May I ask you to repost this patch with proper commit message and added Signed-off-by? Daniel > Samuel Thibault, le sam. 20 janv. 2024 21:10:14 +0100, a ecrit: > > --- > > util/grub.d/10_hurd.in

Re: Severe bug in grub-2.12-for-windows

Hi, Sorry for late reply but I was on vacation... On Sun, Dec 31, 2023 at 01:10:47PM -0500, Dave Pickens wrote: > Hi, > > I am the author of Grub2Win. > > In order to generate kernels from a Windows environment, I rely heavily on the > Windows version (grub-2.12-for-windows) > > In testing, I hav

Re: [PATCH] osdep/hurd/getroot: Fix 64bit build

On Sun, Jan 21, 2024 at 05:22:29AM +0300, Vladimir 'phcoder' Serbinenko wrote: > LGTM > Reviewed-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: State of Argon2 support

On Thu, Jan 04, 2024 at 10:49:06AM -0500, Nikolaos Chatzikonstantinou wrote: > On Mon, Jan 1, 2024 at 2:48 PM Patrick Steinhardt wrote: > > On Fri, Dec 22, 2023 at 09:43:35PM -0600, Oskari Pirhonen wrote: > > > On Fri, Dec 22, 2023 at 12:29:22 -0500, Nikolaos Chatzikonstantinou wrote: > > > > 2. l

Re: [PATCH V2] ieee1275/ofdisk: vscsi lun handling on lun len

On Wed, Jan 17, 2024 at 12:39:06PM +0530, Mukesh Kumar Chaurasiya wrote: > On 11/30/23 00:45, Daniel Kiper wrote: > > On Mon, Nov 27, 2023 at 06:07:42PM +0530, Mukesh Kumar Chaurasiya wrote: > > > Signed-off-by: Mukesh Kumar Chaurasiya > > > --- > > > grub-core/disk/ieee1275/ofdisk.c | 11 ++

[PATCHv2] osdep/hurd/getroot: Fix 64bit build

file_get_fs_options takes a mach_msg_type_number_t (32 bit), not a size_t (64 bit on 64-bit platforms). Signed-off-by: Samuel Thibault --- grub-core/osdep/hurd/getroot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/osdep/hurd/getroot.c b/grub-core/osdep/hurd/getr

[PATCHv2] hurd: Find proper ld.so on 64-bit systems

The 64bit ABI defines ld.so to be /lib/ld-x86-64.so.1 Signed-off-by: Samuel Thibault --- util/grub.d/10_hurd.in | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/util/grub.d/10_hurd.in b/util/grub.d/10_hurd.in index 7d1e46391..f9c394ecb 100644 --- a/util/grub.d/10_h

Re: State of Argon2 support

On Tue, Jan 23, 2024 at 11:58 AM Daniel Kiper wrote: > > On Thu, Jan 04, 2024 at 10:49:06AM -0500, Nikolaos Chatzikonstantinou wrote: > > On Mon, Jan 1, 2024 at 2:48 PM Patrick Steinhardt wrote: > > > > > > Indeed. There are two different ways to implement Argon2 support in > > > GRUB: > > > > >

Re: State of Argon2 support

On Wed, Jan 24, 2024 at 12:05 AM Nikolaos Chatzikonstantinou wrote: > > On Tue, Jan 23, 2024 at 11:58 AM Daniel Kiper wrote: > > > > On Thu, Jan 04, 2024 at 10:49:06AM -0500, Nikolaos Chatzikonstantinou wrote: > > > On Mon, Jan 1, 2024 at 2:48 PM Patrick Steinhardt wrote: > > > > > > > > Indeed.

[PATCH V5] ieee1275/ofdisk: retry on open and read failure

Sometimes, when booting from a very busy SAN, the access to the disk can fail and then GRUB will eventually drop to GRUB prompt. This scenario is more frequent when deploying many machines at the same time using the same SAN. This patch aims to force the ofdisk module to retry the open or read func

Re: State of Argon2 support

On Wed, Jan 24, 2024 at 12:46 AM Nikolaos Chatzikonstantinou wrote: > > On Wed, Jan 24, 2024 at 12:05 AM Nikolaos Chatzikonstantinou > wrote: > > > > On Tue, Jan 23, 2024 at 11:58 AM Daniel Kiper wrote: > > > > > > On Thu, Jan 04, 2024 at 10:49:06AM -0500, Nikolaos Chatzikonstantinou > > > wrot

[PATCH] cli_lock: Added build option to block command line interface

Added functionality to disable command line interface access and editing of GRUB menu entries if GRUB image is built with --disable-cli. Signed-off-by: Alec Brown --- docs/grub.texi | 6 -- grub-core/kern/main.c | 28 grub-core/kern/resc

Re: [PATCH] cli_lock: Added build option to block command line interface

Wed, 24 Jan 2024 06:26:37 + Alec Brown : > +static bool cli_disabled = false; Are there any other values than zero for "false"? If not, the initialization can be removed. Olaf pgpyCy0AM4E27.pgp Description: Digitale Signatur von OpenPGP ___ Grub