Re: [PATCH v2 0/2] disk: use maximum number of sectors for LBA

2023-10-10 Thread Daniel Kiper
On Mon, Oct 09, 2023 at 05:08:21PM +0200, Daniel Kiper wrote: > On Fri, Oct 06, 2023 at 08:10:11PM +0300, ValdikSS via Grub-devel wrote: > > GRUB2 limits number of sectors read at once in LBA mode to the > > number reported in CHS disk geometry by BIOS. > > This is unnecessary, as IBM/MS INT13 Exte

[PATCH] gzio: Avoid spurious failures

2023-10-10 Thread Jason Andryuk
grub_gzio_read_real() uses grub_errno to identify decompression failures when the function completes. Its callees in gzio.c are void-returning functions that set grub_errno on their exit paths. A Fedora 38 machine was observed to fail `multiboot2 /xen.gz` with "premature end of file". xen.gz was

Re: [PATCH] efi: Set shim_lock_enabled even if validation is disabled

2023-10-10 Thread Julian Andres Klode
On Wed, Jul 19, 2023 at 03:16:00PM +0200, Julian Andres Klode wrote: > If validation has been disabled via MokSbState, secure boot on the > firmware is still enabled, and the kernel fails to boot. > > This is a bit hacky, because shim_lock is not *fully* enabled, but > it triggers the right code p

Re: [PATCH 09/13] autogen: Accept python3.10 as a python alternative

2023-10-10 Thread Glenn Washburn
On Sun, 8 Oct 2023 16:01:10 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > Would be nice to have this more generic. Otherwise, this will be another thing to continually update and might not work for older NetBSDs. Perhaps something like: for i in python3 `seq -f 'python3.%g' 20 -1 1` python;

Re: [PATCH 0/13] Fix compilation on various *BSD

2023-10-10 Thread Glenn Washburn
On Sun, 8 Oct 2023 15:54:17 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > I experienced several build failures and problems on *BSD. Here are the > patches to fix them It would be nice if you would send your patch series threaded and have the patch in the body, not as an attachment. You've sent

Re: [PATCH 10/13] configure: Add *BSD font paths

2023-10-10 Thread Glenn Washburn
On Sun, 8 Oct 2023 16:02:02 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > This is reminds me of all the other patches adding support for various install paths not currently included.[1][2][3] [1] https://lore.kernel.org/grub-devel/20211206222542.20068-1-rharw...@redhat.com/ [2] https://lore.

Re: [PATCH] gzio: Avoid spurious failures

2023-10-10 Thread Glenn Washburn
On Tue, 10 Oct 2023 12:24:24 -0400 Jason Andryuk wrote: > grub_gzio_read_real() uses grub_errno to identify decompression failures > when the function completes. Its callees in gzio.c are void-returning > functions that set grub_errno on their exit paths. > > A Fedora 38 machine was observed to

[PATCH v3 2/2] disk: increase sector size up to 127 for LBA reads

2023-10-10 Thread ValdikSS via Grub-devel
Increase the value from 63 to speed up reading process. This commit increases two limits: the low-level int 13h reading code and a high-level reading code with disk cache. The disk cache imposes an overall limitation of a higher-layer reading code. The original comment regarding 16K is incorrect,

[PATCH v3 1/2] disk: read up to 63 sectors in LBA mode

2023-10-10 Thread ValdikSS via Grub-devel
Current code impose limitations on the amount of sectors read in a single call according to CHS layout of the disk, even in LBA read mode. There's no need to obey CHS layout restrictions for LBA reads on LBA disks, it only slows down booting process. See: https://lore.kernel.org/grub-devel/d42a1

[PATCH v3 0/2] disk: use maximum number of sectors for LBA

2023-10-10 Thread ValdikSS via Grub-devel
GRUB2 limits number of sectors read at once in LBA mode to the number reported in CHS disk geometry by BIOS. This is unnecessary, as IBM/MS INT13 Extensions does not have such limit and it is safe to read up to 127 sectors in a single call. This fixes greatly increased boot times on WYSE C10LE x86

Re: [PATCH v2 0/2] disk: use maximum number of sectors for LBA

2023-10-10 Thread ValdikSS via Grub-devel
On 10.10.2023 14:34, Daniel Kiper wrote: ValdikSS, Vladimir and I agreed we will take patch #1 into the release. The patch #2 will be merged after the release. Though please update both patches and post v3 now. Thank you for debugging and fixing this issue! Daniel Done, check v3. OpenPGP_si