Re: [PATCH v9 02/11] Unify GUID types

2023-10-05 Thread Oliver Steffen
re-adding Ard, who was dropped due to a bug in my MUA - sorry. I seems that removing the packed attribute from the GUID struct alone does not solve it. I am about to post a revert of the whole GUID thing so we can move on with the 2.12 release. If we want this feature, I can spend some time on GU

[PATCH 1/4] bli: don't use %pG format specifier

2023-10-05 Thread Oliver Steffen
We are about to revert the unified GUID type and it's printf format specifier, so do use the explicit printf statement for the partition UUID here instread. Signed-off-by: Oliver Steffen --- grub-core/commands/bli.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/grub

[PATCH 2/4] Revert "guid: Make use of GUID printf format specifier"

2023-10-05 Thread Oliver Steffen
This reverts commit 6ad116e5ff459ae06eb993d386da5e7589242667. Signed-off-by: Oliver Steffen --- grub-core/commands/efi/lsefi.c | 13 - grub-core/commands/efi/lsefisystab.c | 6 +- grub-core/commands/probe.c | 12 grub-core/kern/efi/efi.c

[PATCH 3/4] Revert "kern/misc: Add a format specifier GUIDs"

2023-10-05 Thread Oliver Steffen
This reverts commit f82dbf2bd871e9cce327b511a393ffa543d7f69e. Signed-off-by: Oliver Steffen --- grub-core/kern/misc.c | 81 +++ 1 file changed, 21 insertions(+), 60 deletions(-) diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c index b57249acb..0

[PATCH 0/4] Revert unified GUID struct

2023-10-05 Thread Oliver Steffen
The introduction of the new grub_guid struct which unified the three previously existing guid structs [1,2] causes regressions on some architectures [3..7]. Since there is no satisfactory solution yet and I am too short on time to properly solve this quickly, and not to delay the release of Grub 2

[PATCH 4/4] guid: un-unifiy GUID types

2023-10-05 Thread Oliver Steffen
Switch back to separate GUID types, depending on use-case. - Reverts commit 06edd40db76bb78457ac26156ed5f7b62381bbe8, "guid: Unify GUID types" - Changes the guid type used in grub_efi_set_variable_to_string() to grub_efi_guid_t. - Fixes the type of bli_vendor_guid in bli.c Signed-off-by: Oliv

[PATCH] fs/btrfs: Zero file data not backed by extents

2023-10-05 Thread Fabian Vogt
Implicit holes in file data need to be zeroed explicitly, instead of just leaving the data in the buffer uninitialized. This led to kernels randomly failing to boot in "fun" ways when loaded from btrfs with the no_holes feature enabled, because large blocks of zeros in the kernel file contained ra

Re: [PATCH 1/4] bli: don't use %pG format specifier

2023-10-05 Thread Laszlo Ersek
On 10/5/23 12:47, Oliver Steffen wrote: > We are about to revert the unified GUID type and it's printf format > specifier, so do use the explicit printf statement for the partition > UUID here instread. > > Signed-off-by: Oliver Steffen > --- > grub-core/commands/bli.c | 9 - > 1 file ch

Re: [PATCH 2/4] Revert "guid: Make use of GUID printf format specifier"

2023-10-05 Thread Laszlo Ersek
On 10/5/23 12:47, Oliver Steffen wrote: > This reverts commit 6ad116e5ff459ae06eb993d386da5e7589242667. > > Signed-off-by: Oliver Steffen > --- > grub-core/commands/efi/lsefi.c | 13 - > grub-core/commands/efi/lsefisystab.c | 6 +- > grub-core/commands/probe.c |

Re: [PATCH 3/4] Revert "kern/misc: Add a format specifier GUIDs"

2023-10-05 Thread Laszlo Ersek
On 10/5/23 12:47, Oliver Steffen wrote: > This reverts commit f82dbf2bd871e9cce327b511a393ffa543d7f69e. > > Signed-off-by: Oliver Steffen > --- > grub-core/kern/misc.c | 81 +++ > 1 file changed, 21 insertions(+), 60 deletions(-) > > diff --git a/grub-cor

Re: [PATCH 4/4] guid: un-unifiy GUID types

2023-10-05 Thread Laszlo Ersek
On 10/5/23 12:47, Oliver Steffen wrote: > Switch back to separate GUID types, depending on use-case. > > - Reverts commit 06edd40db76bb78457ac26156ed5f7b62381bbe8, > "guid: Unify GUID types" ack > - Changes the guid type used in grub_efi_set_variable_to_string() > to grub_efi_guid_t. Yes, t

Re: [RFC PATCH] efi: Disable stack smashing protection on grub_efi_init()

2023-10-05 Thread Daniel Kiper
On Tue, Jul 18, 2023 at 12:47:14AM -0500, Glenn Washburn wrote: > GCC is electing to instrument grub_efi_init() to give it stack smashing > protection when configuring with --enable-stack-protector on the x86_64-efi > target. In the function prologue, the canary at the top of the stack frame > is s

Re: [PATCH] term/serial: Ensure proper NULL termination after grub_strncpy

2023-10-05 Thread Daniel Kiper
On Fri, Jul 14, 2023 at 03:33:19PM -0500, Glenn Washburn wrote: > A large enough argument to the --port option could cause a string buffer > to be not NULL terminated because grub_strncpy() does not guarantee NULL > termination if copied string is longer than max characters to copy. > > Fixes: 7123

Re: [PATCH 0/4] Revert unified GUID struct

2023-10-05 Thread Vladimir 'phcoder' Serbinenko
I have a proper solution and should be able to test it today. I'll send it in tomorrow Le jeu. 5 oct. 2023, 12:48, Oliver Steffen a écrit : > The introduction of the new grub_guid struct which unified the three > previously existing guid structs [1,2] causes regressions on some > architectures [

Re: [PATCH v3 0/2] Add LUKS2 support to luks_script

2023-10-05 Thread Daniel Kiper
On Fri, Jul 14, 2023 at 03:49:16PM -0500, Glenn Washburn wrote: > v3: > * Fix inconsistencies noted in v2 > * Add a separate patch for optimization and changes in v2 > * Use 6 digits for sector size, instead of previous 5, for really really >future proofing > v2: > * Use PRIxGRUB_OFFSET ins

Re: [PATCH] fs/btrfs: Zero file data not backed by extents

2023-10-05 Thread Daniel Kiper
On Thu, Oct 05, 2023 at 03:57:44PM +0200, Fabian Vogt wrote: > Implicit holes in file data need to be zeroed explicitly, instead of > just leaving the data in the buffer uninitialized. > > This led to kernels randomly failing to boot in "fun" ways when loaded > from btrfs with the no_holes feature

Re: [PATCH v2] i386: flush cache only on VIA C3 and earlier

2023-10-05 Thread Daniel Kiper
On Fri, Jul 07, 2023 at 12:33:32AM +0300, ValdikSS via Grub-devel wrote: > The code used to flush the cache on VIA processors unconditionally, > which is excessive. > Check for cpuid family and execute wbinvd only on C3 and earlier. > > See: https://savannah.gnu.org/bugs/?45149 > See: commit 25492a

Re: [PATCH 0/2] disk: use maximum number of sectors for LBA

2023-10-05 Thread Daniel Kiper
On Fri, Jul 07, 2023 at 12:39:46AM +0300, ValdikSS via Grub-devel wrote: > GRUB2 limits number of sectors read at once in LBA mode to the > number reported in CHS disk geometry by BIOS. > This is unnecessary, as IBM/MS INT13 Extensions allows reading > up to 127 sectors in a single call. > > This f

Re: [PATCH 1/1] commands/efi/lsefisystab: human readable revision

2023-10-05 Thread Daniel Kiper
On Fri, Jul 14, 2023 at 08:12:30AM +0200, Heinrich Schuchardt wrote: > Print the UEFI specification revision in human readable form, e.g. > 2.10 instead of 00020064 and 2.3.1 instead of 0002001f. > > See UEFI 2.10 specification, chapter 4.2.1 EFI_TABLE_HEADER > > Signed-off-by: Heinrich Schuchardt

Re: [PATCH 0/2] disk: use maximum number of sectors for LBA

2023-10-05 Thread Vladimir 'phcoder' Serbinenko
This has a very high risk of breaking existing configs. "Specification allows" doesn't mean that real-world BIOSes actually react well to it. Some BIOS may read just reads 63 instead of 127 sectors and we end up with garbage in this case. I fill it shouldn't come into release. After it we can discu

Re: [PATCH 0/2] disk: use maximum number of sectors for LBA

2023-10-05 Thread Glenn Washburn
On Fri, 7 Jul 2023 00:39:46 +0300 ValdikSS via Grub-devel wrote: > GRUB2 limits number of sectors read at once in LBA mode to the > number reported in CHS disk geometry by BIOS. > This is unnecessary, as IBM/MS INT13 Extensions allows reading > up to 127 sectors in a single call. Please provide

Re: [PATCH 1/2] disk: read up to 63 sectors in LBA mode

2023-10-05 Thread Glenn Washburn
On Fri, 7 Jul 2023 00:39:47 +0300 ValdikSS via Grub-devel wrote: > There's no need to obey CHS layout restrictions for LBA reads > on LBA disks, it only slows down booting process. > > See: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg1.html I'd suggest using this link: http

Re: [PATCH 2/2] disk: increase sector size up to 127 for LBA reads

2023-10-05 Thread Glenn Washburn
On Fri, 7 Jul 2023 00:39:48 +0300 ValdikSS via Grub-devel wrote: > According to Wikipedia and various sources, the recommended > value for LBA read using IBM/MS INT13 Extensions is 127 sectors. Please cite references. I'm not seeing that on Wikipedia or osdev.org. I do see where Wikipedia says

Re: [PATCH] fs/btrfs: Zero file data not backed by extents

2023-10-05 Thread Qu Wenruo
On 2023/10/6 00:27, Fabian Vogt wrote: Implicit holes in file data need to be zeroed explicitly, instead of just leaving the data in the buffer uninitialized. This led to kernels randomly failing to boot in "fun" ways when loaded from btrfs with the no_holes feature enabled, because large bloc

Re: [PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-10-05 Thread Glenn Washburn
On Sat, 2 Sep 2023 22:03:08 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > 2 problems: > 1) Did you audit that all call places either clear or propagate error? Am I correct in understanding that you're asking if all calls to grub_xvasprintf() with clear grub_errno or return it? I have not checke