Re: [PATCH] Fix XFS directory extent parsing

Can you remove pure whitespace changes? Few comments inline but otherwise looks good Le ven. 15 sept. 2023, 06:12, Jon DeVree a écrit : > The XFS directory entry parsing code has never been completely correct > for extent based directories. The parser correctly handles the case > where the direc

Re: [PATCH] Fix XFS directory extent parsing

On Fri, Sep 15, 2023 at 15:23:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > > @@ -877,9 +883,8 @@ grub_xfs_iterate_dir (grub_fshelp_node_t dir, > > { > > struct grub_xfs_dir2_entry *direntry = > > grub_xfs_first_de(dir->data, > > dirb

Re: [PATCH] Fix XFS directory extent parsing

Le ven. 15 sept. 2023, 15:59, Jon DeVree a écrit : > On Fri, Sep 15, 2023 at 15:23:23 +0200, Vladimir 'phcoder' Serbinenko > wrote: > > > @@ -877,9 +883,8 @@ grub_xfs_iterate_dir (grub_fshelp_node_t dir, > > > { > > > struct grub_xfs_dir2_entry *direntry = > > >

[PATCH v2] Fix XFS directory extent parsing

The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the multiple extent case are each identical to the single e