Re: regression in cryptomount -u

2023-08-18 Thread Olaf Hering
Thu, 17 Aug 2023 15:31:52 -0500 Glenn Washburn : > Would you like to send a proper patch to the list or should I? Please go ahead and propose a proper patch/fix. Thanks, Olaf pgpbJ0wr5ypJ4.pgp Description: Digitale Signatur von OpenPGP ___ Grub-deve

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-18 Thread Olaf Hering
Thu, 17 Aug 2023 15:21:44 -0500 Glenn Washburn : > On Thu, 17 Aug 2023 11:00:44 +0200 > Olaf Hering wrote: > > It is the result of my attempt to build just the required binaries, without > > docs. > > I came up with this: > > git clean -dffx > > bash bootstrap > > mkdir .b > > cd .b > >

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-18 Thread Glenn Washburn
On Fri, 18 Aug 2023 16:33:19 +0200 Olaf Hering wrote: > Thu, 17 Aug 2023 15:21:44 -0500 Glenn Washburn : > > > On Thu, 17 Aug 2023 11:00:44 +0200 > > Olaf Hering wrote: > > > It is the result of my attempt to build just the required binaries, > > > without docs. > > > I came up with this: > >

[PATCH] misc: Make grub_vsnprintf C99/POSIX conformant

2023-08-18 Thread Glenn Washburn
To comply with C99 and POSIX standards, snprintf should return the number of bytes that would be written to the string (excluding the terminating NULL byte) if the buffer size was big enough. Before this change, the return value was the minimum of the standard return and the length of the buffer. R

[PATCH] disk/cryptodisk: Fix missing change when updating to use grub_uuidcasecmp

2023-08-18 Thread Glenn Washburn
This was causing the cryptomount command to return failure even though the crypto device was successfully added. Of course, this meant that any script using the return code would behave unexpectedly. Fixes: 3cf2e848bc03 (disk/cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner)

[PATCH 0/2] Fix documentation issues reported by Olaf

2023-08-18 Thread Glenn Washburn
Olaf, would you see if these do indeed fix your issues? Glenn Glenn Washburn (2): docs: Use @pxref instead of @xref inside parenthesis docs: Add menu to prevent older makeinfo versions from failing docs/grub-dev.texi | 5 + docs/grub.texi | 2 +- 2 files changed, 6 insertions(+), 1

[PATCH 1/2] docs: Use @pxref instead of @xref inside parenthesis

2023-08-18 Thread Glenn Washburn
The @xref command is meant to be used at the beginning of a sentence because its expansion creates a "See " prefix. The @pxref expands with a prefix of "see " and is meant to be used within parenthesis. This also fixes an issue where there was a repeated "see" in the output. Reported-by: Olaf Heri

[PATCH 2/2] docs: Add menu to prevent older makeinfo versions from failing

2023-08-18 Thread Glenn Washburn
It has been reported that makeinfo version 4.13a complains and returns error when menus for chapter structuring commands are not present. It is also known that newer makeinfos, such as version 6.7, will create default menus when needed. Since the menu will be created regardless, explicitly create i