Re: [RFC PATCH] efi: Add build error for new EFI arches that do not specify INITRD_MAX_ADDRESS_OFFSET

2023-07-11 Thread Ard Biesheuvel
On Mon, 10 Jul 2023 at 20:33, Glenn Washburn wrote: > > Non-x86 EFI architectures were using a INITRD_MAX_ADDRESS_OFFSET defined > by the aarch64 architecture. This seems to generally work, as in no one > has complained about this. However, the code is misleading. Architectures > should explicitly

Re: How to detect the amount of RAM on non-EFI platforms?

2023-07-11 Thread Cyan Yang via Grub-devel
Hi again, On 2023/7/11 10:08, Cyan via Grub-devel wrote: > static int > traverse_mmap_hook (grub_uint64_t addr, grub_uint64_t size, > grub_memory_type_t type, > void *data __attribute__ ((unused))) > { > total_mem_bytes += size; > } > I discovered a huge problem in my hoo

Re: [PATCH] util/grub.d/25_bli.in: fix shebang on unmerged-usr

2023-07-11 Thread Glenn Washburn
On Mon, 10 Jul 2023 23:55:43 -0500 Oskari Pirhonen wrote: > On an unmerged-usr system, grub-mkconfig errors out with the following > error due to /usr/bin/sh not existing: > > /usr/sbin/grub-mkconfig: /etc/grub.d/25_bli: /usr/bin/sh: bad interpreter: No > such file or directory > > Use a /bin/

[PATCH v4] docs: Add missing assumption

2023-07-11 Thread Glenn Washburn
Also reword a prior sentence to be more clear. Fixes: 5a3d2b4742df (docs: Add debugging chapter to development documentation) Signed-off-by: Glenn Washburn --- Range-diff against v3: 1: 437c408b31cb ! 1: c228e0412720 docs: Add missing assumption @@ docs/grub-dev.texi: GDB is started from th

Re: [PATCH v3] docs: Add missing assumption

2023-07-11 Thread Glenn Washburn
On Mon, 10 Jul 2023 22:34:58 -0500 Oskari Pirhonen wrote: > On Mon, Jul 10, 2023 at 12:14:48 -0500, Glenn Washburn wrote: > > Also reword a prior sentence to be more clear. > > > > Fixes: 5a3d2b4742df (docs: Add debugging chapter to development > > documentation) > > Signed-off-by: Glenn Washbu

Re: [PATCH v4] docs: Add missing assumption

2023-07-11 Thread Oskari Pirhonen
On Tue, Jul 11, 2023 at 12:07:29 -0500, Glenn Washburn wrote: > Also reword a prior sentence to be more clear. > > Fixes: 5a3d2b4742df (docs: Add debugging chapter to development documentation) > Signed-off-by: Glenn Washburn LGTM, thanks. Reviewed-by: Oskari Pirhonen - Oskari > --- > Range-