Re: [PATCH 0/6] NVMeoFC support on Grub

2023-06-06 Thread avnish
On 2023-05-10 17:57, Daniel Kiper wrote: On Mon, May 08, 2023 at 07:28:34PM +0530, Avnish Chouhan wrote: This patch series adds support of NVMeoFC on grub. It consists of six patches. Patch 1/6 (0001-ieee1275-powerpc-implements-fibre-channel-discovery-.patch): grub-ofpathname doesn't work wit

Re: [PATCH v2 1/1] xfs: Fix issues found while fuzzing the XFS filesystem

2023-06-06 Thread Daniel Kiper
On Fri, Jun 02, 2023 at 06:08:44PM +, Lidong Chen wrote: > From: Darren Kenny > > While performing fuzz testing with XFS filesystem images with ASAN > enabled, several issues were found where the memory accesses are made > beyond the data that is allocated into the struct grub_xfs_data > struc

[PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
From: Kees Cook GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's disk.number, which is an internal kernel index. If an array has had drives added, removed, etc, there may be gaps in GET_DISK_INFO's results. But since the consumer of devicelist cannot tolerate gaps (it expects to wal

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > From: Kees Cook > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > disk.number, which is an internal kernel index. If an array has had drives > added, removed, etc, there may be gaps in GET_DISK_INFO's result

Re: [PATCH v1 1/1] loongarch: add relaxation support

2023-06-06 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 10:34:06AM +0800, Xiaotian Wu wrote: > Add R_LARCH_B16, R_LARCH_B21 and R_LARCH_RELAX relocation types to support > LoongArch relaxation. Please explain why this relaxation support is needed. I think you can copy explanation from the cover letter. > https://sourceware.org

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > disk.number, which is an internal kernel index. If an array has

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > > From: Kees Cook > > > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_IN

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Kees Cook
On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode wrote: > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > [...] > > This patch

Re: [PATCH 1/1] fs/udf: Fix out of bounds access

2023-06-06 Thread Lidong Chen
On Jun 2, 2023, at 2:43 AM, Darren Kenny wrote: Hi Li, In general looks good... On Thursday, 2023-06-01 at 18:50:19 UTC, Lidong Chen wrote: Implemented a boundary check before advancing the allocation descriptors pointer. Signed-off-by: Lidong Chen --- grub-core/fs/udf.c | 36 +++

[PATCH v2 0/1] fs/udf: Fix out of bounds access

2023-06-06 Thread Lidong Chen
Thanks Daniel and Darren for reviewing the changes. This v2 addressed Darren's comments. Lidong Chen (1): fs/udf: Fix out of bounds access grub-core/fs/udf.c | 38 ++ 1 file changed, 38 insertions(+) -- 2.39.1

[PATCH v2 1/1] fs/udf: Fix out of bounds access

2023-06-06 Thread Lidong Chen
Implemented a boundary check before advancing the allocation descriptors pointer. Signed-off-by: Lidong Chen Reviewed-by: Darren Kenny Reviewed-by: Daniel Kiper --- grub-core/fs/udf.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/grub-core/fs/udf.c