Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2023-02-09 Thread Peter Zijlstra
On Thu, Jan 26, 2023 at 10:37:35AM +0100, Peter Zijlstra wrote: > On Wed, Dec 21, 2022 at 01:59:02PM +0100, Daniel Kiper wrote: > > Sorry for late reply... > > > > May I ask you to send the patches using "git send-email"? > > I'll try -- I'm one of the few quilt holdouts in Linux-land so I don't

Re: [PATCH v2] tests: Add pathological iso9660 filesystem tests

2023-02-09 Thread Daniel Kiper
On Wed, Feb 08, 2023 at 11:52:17PM -0600, Glenn Washburn wrote: > These are not added to grub-fs-tester because they are not generated and > none of the filesystem tests are run on these isos. The test is to run the > command "ls /" on the iso, and a failure is determined if the command > times out

Re: [PATCH V2] grub-core: modify sector by sysfs as disk sector

2023-02-09 Thread Daniel Kiper
On Thu, Feb 09, 2023 at 01:09:16PM +0530, Mukesh Kumar Chaurasiya wrote: > The disk sector size provided by sysfs file system considers the > sector size of 512 irrespective of disk sector size, Thus > causing the read by grub to an incorrect offset from what was > originally intended. > > Consider

Re: Incorrect comment in disk.h (and bigger cache) ?

2023-02-09 Thread Daniel Kiper
On Thu, Feb 09, 2023 at 01:24:52AM +0100, Mihai Moldovan wrote: > * On 2/9/23 01:05, Benjamin Herrenschmidt wrote: > > Stumbled upon this: > > > > /* The size of a disk cache in 512B units. Must be at least as big as the > >largest supported sector size, currently 16K. */ > > #define GRUB_DISK

Re: [PATCH v2 0/8] serial: Add MMIO & SPCR support

2023-02-09 Thread Daniel Kiper
On Fri, Jan 20, 2023 at 05:15:48PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2023-01-19 at 18:31 +0100, Daniel Kiper wrote: > > > > Sadly your patch set broke various builds including x86-ieee1275 one. I had > > to do some tweaks to make it work again. You can find most important ones > > belo

Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2023-02-09 Thread Daniel Kiper
Adding another Ben's address... On Thu, Feb 09, 2023 at 11:36:46AM +0100, Peter Zijlstra wrote: > On Thu, Jan 26, 2023 at 10:37:35AM +0100, Peter Zijlstra wrote: > > On Wed, Dec 21, 2022 at 01:59:02PM +0100, Daniel Kiper wrote: > > > Sorry for late reply... > > > > > > May I ask you to send the pa

Re: [PATCH V2] grub-core: modify sector by sysfs as disk sector

2023-02-09 Thread Glenn Washburn
On Thu, 9 Feb 2023 13:09:16 +0530 Mukesh Kumar Chaurasiya wrote: > The disk sector size provided by sysfs file system considers the > sector size of 512 irrespective of disk sector size, Thus > causing the read by grub to an incorrect offset from what was > originally intended. > > Considering

Re: [v7 PATCH 2/3] efi: Remove arch specific image headers for RISC-V & ARM64

2023-02-09 Thread Atish Patra
On Thu, Feb 2, 2023 at 12:12 PM Daniel Kiper wrote: > > On Fri, Jan 20, 2023 at 05:17:13PM -0800, Atish Patra wrote: > > The arch specific image header details are not very useful as > > most of the grub just looks at the PE/COFF spec parameters (PE32 magic > > and header offset). > > > > Remove t