Re: [PATCH] f2fs: fix off-by-one error in nat journal entries check

2023-01-17 Thread Daniel Kiper
On Sun, Jan 15, 2023 at 12:19:50AM +1100, Daniel Axtens wrote: > Oops. You're allowed to have up to n = NAT_JOURNAL_ENTRIES entries > _inclusive_, because the loop below uses i < n, not i <= n. D'oh. > > Fixes: 4bd9877f6216 ("fs/f2fs: Do not read past the end of nat journal > entries") > Reported-

Re: [PATCH v4 0/2] mm: Better handling of adding new regions

2023-01-17 Thread Daniel Kiper
On Sat, Jan 14, 2023 at 09:23:21PM +0800, Zhang Boyang wrote: > Hi, > > This is the V4 patchset. > > V3 is at: > https://lists.gnu.org/archive/html/grub-devel/2022-12/msg00271.html > > V2 is at: > https://lists.gnu.org/archive/html/grub-devel/2022-12/msg00164.html > > V1 is at: > https://lists.gnu.

Re: [PATCH 1/1] gentpl.py: Remove .interp section from .img files.

2023-01-17 Thread Daniel Kiper
On Fri, Jan 13, 2023 at 02:56:35AM -0500, Nicholas Vinson wrote: > Whn building .img files, a .interp section from the .image files will > sometimes be copied into the .img file. This additional section pushes > the .img file beyond the 512-byte limit and causes grub-install to fail > to run for i3

Re: clang appends an extra string to Grub2 making it not work with MBR systems

2023-01-17 Thread Daniel Kiper
On Tue, Jan 03, 2023 at 01:15:46AM +, Immolo via Grub-devel wrote: > Using Gentoo with clang on a MBR system I have come across an extra string the > content /lib/ld-linux.so.2 is being added to > /usr/lib/grub/i386-pc/diskboot.img > and /usr/lib/grub/i386-pc/boot.img taking it over 512 bytes

Re: clang appends an extra string to Grub2 making it not work with MBR systems

2023-01-17 Thread Mike Gilbert
On Tue, Jan 17, 2023 at 12:50 PM Daniel Kiper wrote: > > On Tue, Jan 03, 2023 at 01:15:46AM +, Immolo via Grub-devel wrote: > > Using Gentoo with clang on a MBR system I have come across an extra string > > the > > content /lib/ld-linux.so.2 is being added to > > /usr/lib/grub/i386-pc/diskbo

Re: [PATCH v4 1/2] mm: Adjust new region size to take management overhead into account

2023-01-17 Thread Patrick Steinhardt
On Sat, Jan 14, 2023 at 09:23:22PM +0800, Zhang Boyang wrote: > When grub_memalign() encounters out-of-memory, it will try > grub_mm_add_region_fn() to request more memory from system firmware. > However, the size passed to it doesn't take region management overhead > into account. Adding a memory

Re: [PATCH v4 2/2] mm: Preallocate some space when adding new regions

2023-01-17 Thread Patrick Steinhardt
On Sat, Jan 14, 2023 at 09:23:23PM +0800, Zhang Boyang wrote: > When grub_memalign() encounters out-of-memory, it will try > grub_mm_add_region_fn() to request more memory from system firmware. > However, it doesn't preallocate memory space for future allocation > requests. In extreme cases, it req