Re: [PATCH 1/1] gentpl.py: Remove .interp section from .img files.

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
LGTM On Fri, 13 Jan 2023 at 10:58, Nicholas Vinson wrote: > Whn building .img files, a .interp section from the .image files will > sometimes be copied into the .img file. This additional section pushes > the .img file beyond the 512-byte limit and causes grub-install to fail > to run for i386-p

Re: [PATCH 0/6] Cryptomount testing

2023-01-13 Thread Patrick Steinhardt
On Thu, Jan 12, 2023 at 05:23:24PM +0100, Daniel Kiper wrote: > On Tue, Jan 10, 2023 at 04:08:54PM -0600, Glenn Washburn wrote: > > This patch series adds a variety of functional cryptomount LUKS1/2 tests by > > creating a LUKS container on the host and verifying that data inside can be > > read ac

Re: [PATCH 3/4] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2023-01-13 Thread Patrick Steinhardt
On Thu, Jan 12, 2023 at 05:05:09PM -0600, Glenn Washburn wrote: > From: Josselin Poiret > > This lets a LUKS2 cryptodisk have its cipher and hash filled out, > otherwise they wouldn't be initialized if cheat mounted. > > Signed-off-by: Josselin Poiret > Tested-by: Glenn Washburn > --- > grub-

Re: [PATCH 0/4] LUKS1/2 testing in fs-tester and LUKS2 support in grub-probe

2023-01-13 Thread Patrick Steinhardt
On Thu, Jan 12, 2023 at 05:05:06PM -0600, Glenn Washburn wrote: > This series adds the testing of LUKS 1 and 2 encrypted container to the > user-space fs tester. While this does replicate some of the testing done > by grub_cmd_cryptomount, and is less flexible, it is run natively (that is > without

[PATCH v1 0/2] ppc64le: fix problems with signed boot media

2023-01-13 Thread Robbie Harwood
Fix three issues uncovered while trying to use the same core.elf on both installed systems and boot media. CCing POWER folks I have working emails for in case they have a better way to do any of this. Be well, --Robbie Robbie Harwood (2): Skip diskfilter on powerpc CDs Fix prefix and root on

[PATCH v1 2/2] Fix prefix and root on ppc64le CDs

2023-01-13 Thread Robbie Harwood
CHRP requires grub at /boot/grub. On CDs, this means any other prefix will be invalid. In particular, a distro grub might prefer /grub2 - but prefix is hardcoded into the signed core.elf, and will always be wrong here. Also work around a conflict between OF naming and that used by part_msdos: on

[PATCH v1 1/2] Skip diskfilter on powerpc CDs

2023-01-13 Thread Robbie Harwood
Prior to this change, on ppc64le with part_msdos and the mdraid* modules enabled, we see: disk/diskfilter.c:191: scanning ieee1275/cdrom kern/disk.c:196: Opening `ieee1275/cdrom'... disk/ieee1275/ofdisk.c:477: Opening `cdrom'. disk/ieee1275/ofdisk.c:502: MAX_RETRIES set to 20 k

Re: [PATCH v1 2/2] Fix prefix and root on ppc64le CDs

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
The ,0 suffix sounds like a bug in a detection As for the prefix, can‘t we solve it by setting prefix properly. If there is really no better solution (doubtful) then it needs to be restricted to chrp platforms and even there, probably only a subset On Fri, 13 Jan 2023 at 23:27, Robbie Harwood wrot

Re: [PATCH v1 2/2] Fix prefix and root on ppc64le CDs

2023-01-13 Thread Robbie Harwood
"Vladimir 'phcoder' Serbinenko" writes: > The ,0 suffix sounds like a bug in a detection > As for the prefix, can‘t we solve it by setting prefix properly. > If there is really no better solution (doubtful) then it needs to be > restricted to chrp platforms and even there, probably only a subset

Re: [PATCH v1 1/2] Skip diskfilter on powerpc CDs

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
This is not properly restricted to just raid. Only mdraid 1.1 is affected. The condition should probably be along the lines "if msdos is embedded in a device of unknown size, then skip mdraid 1.1 probing" On Fri, Jan 13, 2023 at 9:27 PM Robbie Harwood wrote: > > Prior to this change, on ppc64le w

Re: [PATCH 3/4] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
> + name = dm_tree_node_get_name (node); > + if (grub_strlen (name) == 0) > +grub_util_error (_("cannot get dm node name for grub dev > `%s'"), grdev); if (name[0] == '\0') ... ___ Grub-devel mailing list Gru