Re: [RFC PATCH v4 1/1] kern/dl: Add module vermagic check

2022-12-29 Thread Pete Batard via Grub-devel
On 2022.12.25 07:57, Zhang Boyang wrote: This commit add vermagic string to GRUB modules. Specifically, a unique but shared vermagic string is embedded in .modver section of each module, and it is checked at module loading time. The vermagic string is uniquely generated by configure script in eac

Re: [RFC PATCH v4 0/1] kern/dl: Add module vermagic check

2022-12-29 Thread Pete Batard via Grub-devel
Hi, I finally got a chance to test this proposal (mostly in the context of Rufus and for BIOS boot), and everything looks good to me. Thanks a lot for adding an option to disable the warning when invoking configure! I also second the idea that we want a unique identifier added to the versi