Hi,
On 2022/12/21 03:04, Glenn Washburn wrote:
On Mon, 19 Dec 2022 23:33:29 +0800
Zhang Boyang wrote:
This patch add version information to GRUB modules. Specifically,
PACKAGE_VERSION is embedded as null-terminated string in .modver
section. This string is checked at module loading time. That
Hi,
On 2022/12/21 10:43, Pete Batard via Grub-devel wrote:
Hello all,
On 2022.12.20 22:58, Robbie Harwood wrote:
Zhang Boyang writes:
This patch add version information to GRUB modules. Specifically,
PACKAGE_VERSION is embedded as null-terminated string in .modver
section. This string is ch
Hi,
Pete Batard wrote:
> > unlike what is the case for UEFI, one can not expect
> > to be able to pick all the GRUB core files needed to convert a GRUB
> > based ISO bootable media to a GRUB based USB bootable media [...]
> > Typically, one of the
> > missing files will be a 'core.img' that can wo
Le 21/12/2022 à 09:43, Thomas Schmitt a écrit :
> I think that in any case an ISO made by grub-mkrescue should be tested.
> Maybe a distro developer is here who uses it for making a full fledged
> installation ISO or a live ISO.
I do for making a full fledged installation ISO in this function, wit
Hi,
On 2022/12/21 17:43, Thomas Schmitt wrote:
Hi,
Pete Batard wrote:
unlike what is the case for UEFI, one can not expect
to be able to pick all the GRUB core files needed to convert a GRUB
based ISO bootable media to a GRUB based USB bootable media [...]
Typically, one of the
missing files w
This patch add version information to GRUB modules. Specifically,
PACKAGE_VERSION is embedded as null-terminated string in .modver
section. This string is checked at module loading time.
If GRUB is locked down, modules with mismatched version will be
rejected. This is necessary for implementing ex
Sorry for late reply...
May I ask you to send the patches using "git send-email"?
On Fri, Aug 26, 2022 at 01:01:44PM +0200, pet...@infradead.org wrote:
> Loosely based on early_pci_serial_init() from Linux, allow GRUB to make
> use of PCI serial devices.
>
> Specifically, my Alderlake NUC exposes
On Fri, Dec 02, 2022 at 10:05:22AM +1100, Benjamin Herrenschmidt wrote:
> From: Benjamin Herrenschmidt
>
> This adds the ability for the driver to access UARTs via MMIO instead
> of PIO selectively at runtime, and exposes a new function to add an
> MMIO port.
>
> Signed-off-by: Benjamin Herrenschm
On Fri, Dec 02, 2022 at 10:05:23AM +1100, Benjamin Herrenschmidt wrote:
> From: Benjamin Herrenschmidt
>
> This will allow ports to be added with a pre-set configuration
>
> Signed-off-by: Benjamin Herrenschmidt
> ---
> grub-core/term/ns8250.c | 25 +++--
> grub-core/term/ser
On Fri, Dec 02, 2022 at 10:05:24AM +1100, Benjamin Herrenschmidt wrote:
> From: Benjamin Herrenschmidt
>
> "serial auto" is now equivalent to just "serial" and will use the
> SPCR to discover the port if present, otherwise defaults to "com0"
> as before.
>
> This allows to support MMIO ports speci
On Fri, Dec 02, 2022 at 10:05:25AM +1100, Benjamin Herrenschmidt wrote:
> From: Benjamin Herrenschmidt
>
> It is common for PCI based UARTs to use larger than one byte access
> sizes. This adds support for this and uses the information present
> in SPCR accordingly.
>
> Signed-off-by: Benjamin Her
On Fri, Dec 02, 2022 at 10:05:26AM +1100, Benjamin Herrenschmidt wrote:
> From: Benjamin Herrenschmidt
>
> This adds the ability to explicitely add an MMIO based serial port
> via the 'serial' command. The syntax is:
>
> serial --port=mmio,{.b,.w,.l,.q}
>
> Signed-off-by: Benjamin Herrenschmidt
>
On Fri, Dec 02, 2022 at 10:05:19AM +1100, Benjamin Herrenschmidt wrote:
> This series adds support for MMIO serial ports and auto-configuration
> via ACPI SPCR.
>
> This is necessary for the serial port to work on AWS EC2 "metal" x86
> systems.
>
> An MMIO serial port can be specified explicitely u
Hi Zhang,
On 2022.12.21 11:38, Zhang Boyang wrote:
Hi,
On 2022/12/21 17:43, Thomas Schmitt wrote:
Hi,
Pete Batard wrote:
unlike what is the case for UEFI, one can not expect
to be able to pick all the GRUB core files needed to convert a GRUB
based ISO bootable media to a GRUB based USB boota
On Thu, Dec 15, 2022 at 11:29:27PM -0600, Glenn Washburn wrote:
Why? Could you add that to the commit message?
> Signed-off-by: Glenn Washburn
> ---
> grub-core/gdb_grub.in | 20 +---
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/grub-core/gdb_grub.in b/gru
Adding Robbie...
Please CC him next time when you post these patches. I would want to
hear his opinion too. Or at least he is aware what is happening here...
On Thu, Dec 15, 2022 at 11:29:31PM -0600, Glenn Washburn wrote:
> If the macro PRINT_GDB_SYM_LOAD_CMD is non-zero, compile code which will
On Thu, Dec 15, 2022 at 11:29:35PM -0600, Glenn Washburn wrote:
> A new command, run_on_start, is created which handles some complexities
> of the EFI platform when breaking on GRUB start. If GRUB start is hooked,
> run "onstart" command if it is defned.
>
> Signed-off-by: Glenn Washburn
> ---
>
On Thu, Dec 15, 2022 at 11:29:36PM -0600, Glenn Washburn wrote:
> Add symbols for boot.image, disk.image, and lzma_decompress.image if the
> target is i386-pc.
Why?
> Signed-off-by: Glenn Washburn
> ---
> grub-core/gdb_grub.in | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/grub-
Hi again Zhang,
I hadn't had a chance to properly look at your v2 before replying
earlier, and it looks like it addresses the elements I had an issue with.
On 2022.12.21 12:11, Zhang Boyang wrote:
This patch add version information to GRUB modules. Specifically,
PACKAGE_VERSION is embedded as
On Thu, Dec 15, 2022 at 11:29:38PM -0600, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn
> ---
> docs/grub-dev.texi | 191 +
> 1 file changed, 191 insertions(+)
>
> diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi
> index f76fc658bf..8171e91c
On Fri, Aug 26, 2022 at 01:01:45PM +0200, pet...@infradead.org wrote:
> Glenn suggested to rename the existing PCI_CLASS defines to have
> explicit class and subclass names.
>
> Suggested-by: Glenn Washburn
> Signed-off-by: Peter Zijlstra (Intel)
Reviewed-by: Daniel Kiper
Daniel
_
Hi,
On 2022/12/21 01:16, Daniel Kiper wrote:
Please do not send your new sets of patches as a reply to previous
discussions. If you do that then it is more difficult to find them
in threaded views.
OK. I will not do that in future.
On Thu, Dec 15, 2022 at 07:19:23PM +0800, Zhang Boyang wrot
On Wed, 21 Dec 2022 16:07:27 +0800
Zhang Boyang wrote:
> Hi,
>
> On 2022/12/21 03:04, Glenn Washburn wrote:
> > On Mon, 19 Dec 2022 23:33:29 +0800
> > Zhang Boyang wrote:
> >
> >> This patch add version information to GRUB modules. Specifically,
> >> PACKAGE_VERSION is embedded as null-termina
On Wed, 21 Dec 2022 16:20:17 +0100
Daniel Kiper wrote:
> Adding Robbie...
>
> Please CC him next time when you post these patches. I would want to
> hear his opinion too. Or at least he is aware what is happening
> here...
Sure, I CC'd him and Peter on the first couple of ones. But there was
ne
Zhang Boyang writes:
> On 2022/12/21 06:58, Robbie Harwood wrote:
>> Zhang Boyang writes:
>>
>>> This patch add version information to GRUB modules. Specifically,
>>> PACKAGE_VERSION is embedded as null-terminated string in .modver
>>> section. This string is checked at module loading time. Tha
On Wed, 21 Dec 2022 16:27:40 +0100
Daniel Kiper wrote:
> On Thu, Dec 15, 2022 at 11:29:35PM -0600, Glenn Washburn wrote:
> > A new command, run_on_start, is created which handles some
> > complexities of the EFI platform when breaking on GRUB start. If
> > GRUB start is hooked, run "onstart" comm
On Wed, 21 Dec 2022 16:28:35 +0100
Daniel Kiper wrote:
> On Thu, Dec 15, 2022 at 11:29:36PM -0600, Glenn Washburn wrote:
> > Add symbols for boot.image, disk.image, and lzma_decompress.image
> > if the target is i386-pc.
>
> Why?
Why not? I'm not clear on what your objection is. This is for deb
On Wed, 2022-12-21 at 15:15 +0100, Daniel Kiper wrote:
>
> First of all sorry for very late reply. I sent you my comments. There
> are some important problems plus some nitpicks which have to be
> fixed.
> Though I like the patch set in general. Than you for doing this work.
Thanks ! I'll try to
Thanks for your review !
I'll address everything. Small "nits":
On Wed, 2022-12-21 at 14:25 +0100, Daniel Kiper wrote:
> > +
> > +char *
> > +grub_serial_ns8250_add_mmio(grub_addr_t addr)
> > +{
> > + struct grub_serial_port *p;
> > + unsigned i;
>
> Please add en empty line here.
Ack. I cop
On Wed, 2022-12-21 at 15:11 +0100, Daniel Kiper wrote:
> > + if (!port && grub_memcmp (name, "mmio,", sizeof ("mmio,") - 1) == 0
>
> I think grub_strncmp() in string context would be more appropriate.
> Please replace grub_memcmp() with grub_strncmp() where possible.
Same comment as patch 3, thi
On Wed, 21 Dec 2022 12:19:16 -0600
Glenn Washburn wrote:
> On Wed, 21 Dec 2022 16:27:40 +0100
> Daniel Kiper wrote:
>
> > On Thu, Dec 15, 2022 at 11:29:35PM -0600, Glenn Washburn wrote:
> > > A new command, run_on_start, is created which handles some
> > > complexities of the EFI platform when
On Wed, 21 Dec 2022 11:07:38 +0800
Jeremy Szu wrote:
> On Fri, Dec 16, 2022 at 1:33 PM Glenn Washburn
> wrote:
> >
> > Signed-off-by: Glenn Washburn
> > ---
> > docs/grub-dev.texi | 191
> > + 1 file changed, 191
> > insertions(+)
> >
> > diff --git a
This series adds support for MMIO serial ports and auto-configuration
via ACPI SPCR.
This is necessary for the serial port to work on AWS EC2 "metal" x86
systems.
An MMIO serial port can be specified explicitely using the
"mmio," prefix for the --port argument to the 'serial' command,
the registe
From: Benjamin Herrenschmidt
"serial auto" is now equivalent to just "serial" and will use the
SPCR to discover the port if present, otherwise defaults to "com0"
as before.
This allows to support MMIO ports specified by ACPI which is needed
on AWS EC2 "metal" instances, and will enable GRUB to p
This adds the definition of the two ACPI tables according to
the spec.
Signed-off-by: Benjamin Herrenschmidt
---
include/grub/acpi.h | 51 +
1 file changed, 51 insertions(+)
diff --git a/include/grub/acpi.h b/include/grub/acpi.h
index 8c126b2b9..17aad
And convert grub_acpi_find_fadt to use it
Signed-off-by: Benjamin Herrenschmidt
---
grub-core/kern/acpi.c | 43 +--
include/grub/acpi.h | 3 +++
2 files changed, 28 insertions(+), 18 deletions(-)
diff --git a/grub-core/kern/acpi.c b/grub-core/kern/acpi
From: Benjamin Herrenschmidt
It is common for PCI based UARTs to use larger than one byte access
sizes. This adds support for this and uses the information present
in SPCR accordingly.
Signed-off-by: Benjamin Herrenschmidt
---
grub-core/term/ns8250-spcr.c | 3 +-
grub-core/term/ns8250.c
From: Benjamin Herrenschmidt
This adds the ability for the driver to access UARTs via MMIO instead
of PIO selectively at runtime, and exposes a new function to add an
MMIO port.
In an ideal world, MMIO accessors would be generic and have architecture
specific memory barriers. However, existing d
From: Benjamin Herrenschmidt
This adds the ability to explicitely add an MMIO based serial port
via the 'serial' command. The syntax is:
serial --port=mmio,{.b,.w,.l,.q}
Signed-off-by: Benjamin Herrenschmidt
---
docs/grub.texi | 26 ++--
grub-core/term/serial.c | 53 +
And while at it, unify it as clock frequency in HZ, to match the
value in "struct grub_serial_config" and do the division by
16 in one common place.
This will simplify adding SPCR support.
Signed-off-by: Benjamin Herrenschmidt
---
grub-core/term/ns8250.c | 15 ---
include/grub/ns825
From: Benjamin Herrenschmidt
This will allow ports to be added with a pre-set configuration
Signed-off-by: Benjamin Herrenschmidt
---
grub-core/term/ns8250.c | 27 ---
grub-core/term/serial.c | 2 +-
include/grub/serial.h | 4 ++--
3 files changed, 23 insertions(+),
On Wed, 21 Dec 2022 20:11:57 +0800
Zhang Boyang wrote:
> This patch add version information to GRUB modules. Specifically,
> PACKAGE_VERSION is embedded as null-terminated string in .modver
> section. This string is checked at module loading time.
>
> If GRUB is locked down, modules with mismatc
42 matches
Mail list logo
