Re: [PATCH 4/4] fs/iso9660: Incorrect check for entry boudary

2022-12-20 Thread Thomas Schmitt
Hi, in summary: Your objections to my objections are correct. On Wed, 14 Dec 2022 18:55:05 + Lidong Chen wrote: > >> + /* The symlink is not stored as a POSIX symlink, translate it. */ > >> + while ((pos + GRUB_ISO9660_SUSP_HEADER_SZ) < entry->len) On Dec 15, 2022, at 10:20 AM, T

Re: [PATCH] grub-shell: Add grub output logfile with grub-shell --debug

2022-12-20 Thread Daniel Kiper
On Thu, Dec 15, 2022 at 10:45:46AM -0600, Glenn Washburn wrote: > This allows seeing full qemu output of grub-shell, which can be invaluable > when debugging failing tests. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-d

Re: [PATCH] docs: Remove text about cryptodisk uuids no being able to use dashes

2022-12-20 Thread Daniel Kiper
On Thu, Dec 15, 2022 at 12:04:39PM -0600, Glenn Washburn wrote: > This was fixed here: 3cf2e848bc (disk/cryptodisk: Allows UUIDs to be compared > in a dash-insensitive manner). > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Gr

Re: [PATCH v2 0/3] Add support for EFI file system transposition

2022-12-20 Thread Daniel Kiper
On Fri, Nov 25, 2022 at 05:22:14PM +, Pete Batard via Grub-devel wrote: > Changes from v1: > - Rebased against latest GRUB > - Validated patches against coding guidelines > - Clarified comments > > Note: If you are interested in testing this series, I have jolted down some > guidelines at: > h

Re: [PATCH v2 1/2] mm: Adjust new region size to take management overhead into account

2022-12-20 Thread Daniel Kiper
Please do not send your new sets of patches as a reply to previous discussions. If you do that then it is more difficult to find them in threaded views. On Thu, Dec 15, 2022 at 07:19:23PM +0800, Zhang Boyang wrote: > When grub_memalign() encounters out-of-memory, it will try > grub_mm_add_region_f

Re: [PATCH v3] cmp: Only return success when both files have the same contents

2022-12-20 Thread Daniel Kiper
On Thu, Dec 15, 2022 at 12:13:30PM -0600, Glenn Washburn wrote: > This allows the cmp command to be used in GRUB scripts to conditionally > run commands based on whether two files are the same. > > The command is now quiet by default and the -v switch can be given to enable > verbose mode, the prev

Re: [PATCH v2 2/2] mm: Preallocate some space when adding new regions

2022-12-20 Thread Daniel Kiper
On Thu, Dec 15, 2022 at 07:19:25PM +0800, Zhang Boyang wrote: > When grub_memalign() encounters out-of-memory, it will try > grub_mm_add_region_fn() to request more memory from system firmware. > However, it doesn't preallocate memory space for future allocation > requests. In extreme cases, it req

Re: [PATCH] templates/linux_xen: fix detecting xsm policy

2022-12-20 Thread Daniel Kiper
On Tue, Dec 13, 2022 at 10:47:35PM +0100, Marek Marczykowski-Górecki wrote: > On Tue, Dec 13, 2022 at 01:02:14PM +0100, Daniel Kiper wrote: > > On Tue, Dec 13, 2022 at 05:12:35AM +0100, Marek Marczykowski-Górecki wrote: > > > xsmpolicy variable was left set from previous function call. This > > > r

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Glenn Washburn
On Mon, 19 Dec 2022 23:33:29 +0800 Zhang Boyang wrote: > This patch add version information to GRUB modules. Specifically, > PACKAGE_VERSION is embedded as null-terminated string in .modver > section. This string is checked at module loading time. That module > will be rejected if mismatch is fou

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2022-12-20 Thread Lidong Chen
> On Dec 16, 2022, at 4:57 AM, Thomas Schmitt wrote: > > Hi, > > i realize that my previous proposal opens a possibility for regression with > a very bad ISO image. > The danger is in an endless loop by a CE entry which points to itself. > The bug which i want to see fixed currently prevents t

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Robbie Harwood
Zhang Boyang writes: > This patch add version information to GRUB modules. Specifically, > PACKAGE_VERSION is embedded as null-terminated string in .modver > section. This string is checked at module loading time. That module will > be rejected if mismatch is found. This will prevent loading modu

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Pete Batard via Grub-devel
Hello all, On 2022.12.20 22:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at module loading time. That module will be rejected if

Re: [PATCH v4 15/15] docs: Add debugging chapter to development documentation

2022-12-20 Thread Jeremy Szu
On Fri, Dec 16, 2022 at 1:33 PM Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > --- > docs/grub-dev.texi | 191 + > 1 file changed, 191 insertions(+) > > diff --git a/docs/grub-dev.texi b/docs/grub-dev.texi > index f76fc658bf..8171e91c33 1006

Re: [RFC PATCH] kern/dl: Add module version check

2022-12-20 Thread Zhang Boyang
Hi, (sorry for duplicate emails because I forgot to add CCs) On 2022/12/21 06:58, Robbie Harwood wrote: Zhang Boyang writes: This patch add version information to GRUB modules. Specifically, PACKAGE_VERSION is embedded as null-terminated string in .modver section. This string is checked at m