Re: Fonts and theming and what to do in future with SB

2022-12-01 Thread Zhang Boyang
Hi, On 2022/12/1 00:08, Robbie Harwood wrote: Zhang Boyang writes: On 2022/11/30 02:35, Steve McIntyre wrote: AFAIK Chris Coulson has a patch for the font loader to cause it to try loading fonts from the embedded memdisk first. Is that the best approach? If so, what fonts should we be embed

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Stefan Berger
On 12/1/22 00:19, Glenn Washburn wrote: On Wed, 30 Nov 2022 17:42:40 -0500 Stefan Berger wrote: On 11/30/22 16:24, Stefan Berger wrote: On 11/30/22 14:47, Stefan Berger wrote: On 11/24/22 12:56, Daniel Kiper wrote: Hi, Adding Sudhakar and Glenn... On Thu, Aug 11, 2022 at 02:40:58P

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
Adding Vladimir... On Wed, Nov 30, 2022 at 02:47:41PM -0500, Stefan Berger wrote: > On 11/24/22 12:56, Daniel Kiper wrote: > > Hi, > > > > Adding Sudhakar and Glenn... > > > > On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote: > > > Hello, > > > > > > This is an addition to the series

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 04:24:59PM -0500, Stefan Berger wrote: > On 11/30/22 14:47, Stefan Berger wrote: > > On 11/24/22 12:56, Daniel Kiper wrote: > > > Hi, > > > > > > Adding Sudhakar and Glenn... > > > > > > On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote: > > > > Hello, > > > > >

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 08:43:56AM -0500, Stefan Berger wrote: > On 12/1/22 00:19, Glenn Washburn wrote: > > On Wed, 30 Nov 2022 17:42:40 -0500 > > Stefan Berger wrote: > > > On 11/30/22 16:24, Stefan Berger wrote: > > > > On 11/30/22 14:47, Stefan Berger wrote: > > > > > On 11/24/22 12:56, Daniel

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Stefan Berger
On 12/1/22 09:02, Daniel Kiper wrote: On Thu, Dec 01, 2022 at 08:43:56AM -0500, Stefan Berger wrote: On 12/1/22 00:19, Glenn Washburn wrote: On Wed, 30 Nov 2022 17:42:40 -0500 Stefan Berger wrote: On 11/30/22 16:24, Stefan Berger wrote: On 11/30/22 14:47, Stefan Berger wrote: On 11/24/22

Re: [PATCH v2 2/2] efi: Put Linux specific magic number in the DOS header

2022-12-01 Thread Daniel Kiper
On Tue, Nov 29, 2022 at 06:56:16PM +0100, Ard Biesheuvel wrote: > GRUB currently relies on the magic number in the image header of ARM and > arm64 EFI kernel images to decide whether or not the image in question > is a bootable kernel. > > However, the purpose of the magic number is to identify the

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 09:22:42AM -0500, Stefan Berger wrote: > On 12/1/22 09:02, Daniel Kiper wrote: [...] > > ./configure --target=i386 --with-platform=ieee1275 ... > > I had to adjust the created symlist.h like this to make it compile at least: > > //#include <../include/grub/machine/pxe.h> >

Re: [PATCH v2 2/2] efi: Put Linux specific magic number in the DOS header

2022-12-01 Thread Ard Biesheuvel
On Thu, 1 Dec 2022 at 15:30, Daniel Kiper wrote: > > On Tue, Nov 29, 2022 at 06:56:16PM +0100, Ard Biesheuvel wrote: > > GRUB currently relies on the magic number in the image header of ARM and > > arm64 EFI kernel images to decide whether or not the image in question > > is a bootable kernel. > >

Re: [PATCH v2 2/2] efi: Put Linux specific magic number in the DOS header

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 03:48:12PM +0100, Ard Biesheuvel wrote: > On Thu, 1 Dec 2022 at 15:30, Daniel Kiper wrote: > > On Tue, Nov 29, 2022 at 06:56:16PM +0100, Ard Biesheuvel wrote: > > > GRUB currently relies on the magic number in the image header of ARM and > > > arm64 EFI kernel images to dec

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Stefan Berger
On 12/1/22 09:47, Daniel Kiper wrote: On Thu, Dec 01, 2022 at 09:22:42AM -0500, Stefan Berger wrote: On 12/1/22 09:02, Daniel Kiper wrote: [...] ./configure --target=i386 --with-platform=ieee1275 ... I had to adjust the created symlist.h like this to make it compile at least: //#include

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 09:58:45AM -0500, Stefan Berger wrote: > On 12/1/22 09:47, Daniel Kiper wrote: > > On Thu, Dec 01, 2022 at 09:22:42AM -0500, Stefan Berger wrote: > > > On 12/1/22 09:02, Daniel Kiper wrote: > > > > [...] > > > > > > ./configure --target=i386 --with-platform=ieee1275 ... > >

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Stefan Berger
On 12/1/22 10:51, Daniel Kiper wrote: On Thu, Dec 01, 2022 at 09:58:45AM -0500, Stefan Berger wrote: On 12/1/22 09:47, Daniel Kiper wrote: On Thu, Dec 01, 2022 at 09:22:42AM -0500, Stefan Berger wrote: On 12/1/22 09:02, Daniel Kiper wrote: [...] ./configure --target=i386 --with-platform=

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 11:44:02AM -0500, Stefan Berger wrote: > On 12/1/22 10:51, Daniel Kiper wrote: > > On Thu, Dec 01, 2022 at 09:58:45AM -0500, Stefan Berger wrote: > > > On 12/1/22 09:47, Daniel Kiper wrote: > > > > On Thu, Dec 01, 2022 at 09:22:42AM -0500, Stefan Berger wrote: > > > > > On 1

Re: [PATCH V2 2/4] bash-completion:fix shellcheck SC2207-Warning

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 04:30:58PM +0800, t.feng wrote: > SC2207 (warning): Prefer mapfile or read -a to split > command output (or quote to avoid splitting). > > In grub-completion.bash.in line 56: > COMPREPLY=($(compgen -P "${2-}" -W "${1-}" -S "${4-}" -- > "$cur")) >^

Re: [PATCH] util/grub.d/30_uefi-firmware.in: Re-arrange if conditions

2022-12-01 Thread Daniel Kiper
On Tue, Nov 29, 2022 at 10:13:27PM +, Dimitri John Ledkov wrote: > Only perform call to fwsetup if one is on EFI platform. On all other > platorms fwsetup command does not exists, and thus returns 0 and a > useless uefi-firmware menuentry gets generated. > > Signed-off-by: Dimitri John Ledkov

Re: [PATCH v2 2/2] efi: Put Linux specific magic number in the DOS header

2022-12-01 Thread Daniel Kiper
On Thu, Dec 01, 2022 at 03:48:12PM +0100, Ard Biesheuvel wrote: > On Thu, 1 Dec 2022 at 15:30, Daniel Kiper wrote: > > > > On Tue, Nov 29, 2022 at 06:56:16PM +0100, Ard Biesheuvel wrote: > > > GRUB currently relies on the magic number in the image header of ARM and > > > arm64 EFI kernel images to

Re: [PATCH V2 4/4] bash-completion:disable shellcheck SC2120-Warning

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 04:31:00PM +0800, t.feng wrote: > In grub-completion.bash.in line 63: > __grub_get_options_from_help () { > ^-- SC2120 (warning) Again, what the warning means? > SC2120: the current code meets the exception and does not need to be > modified. So we disable it. > > ref:http

Re: [PATCH v8 1/1] plainmount: Support plain encryption mode

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 11:58:33PM -0600, Glenn Washburn wrote: > On Tue, 29 Nov 2022 18:13:11 +0100 > Daniel Kiper wrote: > > > First of all, sorry for late reply. I hope I will be able to review > > next version of this patch much faster. > > > > On Sat, Oct 29, 2022 at 05:40:42PM +, Maxim F

Re: [PATCH V2 1/4] bash-completion:fix shellcheck error

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 04:30:57PM +0800, t.feng wrote: > SC2070 (error): -n doesn't work with unquoted arguments. > Quote or use [[ ]]. > In grub-completion.bash.in line 130: > [ -n $tmp ] && { > ^--^ SC2070 (error) > > ref:https://github.com/koalaman/shellcheck/wiki

Re: [PATCH V2 3/4] bash-completion:fix shellcheck SC2155-Warning

2022-12-01 Thread Daniel Kiper
On Wed, Nov 30, 2022 at 04:30:59PM +0800, t.feng wrote: > In grub-completion.bash.in line 115: > local config_file=$(__grub_dir)/grub.cfg > ^-^ SC2155 (warning) > > In grub-completion.bash.in line 126: > local grub_dir=$(__grub_dir) > ^--^ SC2155 (warning) P

Re: [PATCH v8 1/1] plainmount: Support plain encryption mode

2022-12-01 Thread Glenn Washburn
On Sat, 29 Oct 2022 17:40:42 + Maxim Fomin wrote: > From 2b1d2deb3f2416cbc3e7d25cbc4141a3078eaf68 Mon Sep 17 00:00:00 2001 > From: Maxim Fomin > Date: Sat, 29 Oct 2022 18:18:58 +0100 > Subject: [PATCH v8 1/1] plainmount: Support plain encryption mode > > This patch adds support for plain en

[PATCH v2 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-12-01 Thread Stefan Berger
Hello, This is an addition to the series sent from Daniel Axtens (https://lists.gnu.org/archive/html/grub-devel/2022-04/msg00064.html). Patch 'ieee1275: request memory with ibm,client-architecture-support' implements vectors 1-4 of client-architecture-support negotiation However, during some te

[PATCH v2 3/6] ieee1275: support runtime memory claiming

2022-12-01 Thread Stefan Berger
From: Daniel Axtens On powerpc-ieee1275, we are running out of memory trying to verify anything. This is because: - we have to load an entire file into memory to verify it. This is difficult to change with appended signatures. - We only have 32MB of heap. - Distro kernels are now often aro

[PATCH v2 4/6] ieee1275: implement vec5 for cas negotiation

2022-12-01 Thread Stefan Berger
From: Diego Domingos As a legacy support, if the vector 5 is not implemented, Power Hypervisor will consider the max CPUs as 64 instead 256 currently supported during client-architecture-support negotiation. This patch implements the vector 5 and set the MAX CPUs to 256 while setting the others

[PATCH v2 5/6] Add memtool module with memory allocation stress-test

2022-12-01 Thread Stefan Berger
From: Daniel Axtens When working on memory, it's nice to be able to test your work. Add a memtest module. When compiled with --enable-mm-debug, it exposes 3 commands: * lsmem - print all allocations and free space in all regions * lsfreemem - print free space in all regions * stress_big_all

[PATCH v2 6/6] ibmvtpm: Add support for trusted boot using a vTPM 2.0

2022-12-01 Thread Stefan Berger
Add support for trusted boot using a vTPM 2.0 on the IBM IEEE1275 PowerPC platform. With this patch grub now measures text and binary data into the TPM's PCRs 8 and 9 in the same way as the x86_64 platform does. This patch requires Daniel Axtens's patches for claiming more memory. For vTPM suppor

[PATCH v2 2/6] ieee1275: drop len -= 1 quirk in heap_init

2022-12-01 Thread Stefan Berger
From: Daniel Axtens This was apparently 'required by some firmware': commit dc9468500919 ("2007-02-12 Hollis Blanchard "). It's not clear what firmware that was, and what platform from 14 years ago which exhibited the bug then is still both in use and buggy now. It doesn't cause issues on qem

[PATCH v2 1/6] ieee1275: request memory with ibm, client-architecture-support

2022-12-01 Thread Stefan Berger
From: Daniel Axtens On PowerVM, the first time we boot a Linux partition, we may only get 256MB of real memory area, even if the partition has more memory. This isn't enough to reliably verify a kernel. Fortunately, the Power Architecture Platform Reference (PAPR) defines a method we can call to

[PATCH 1/7] acpi: Export a generic grub_acpi_find_table

2022-12-01 Thread Benjamin Herrenschmidt
From: Matthias Lange And convert grub_acpi_find_fadt to use it Signed-off-by: Benjamin Herrenschmidt --- grub-core/kern/acpi.c | 43 +-- include/grub/acpi.h | 3 +++ 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/grub-core/kern/acpi.

[PATCH 3/7] ns8250: Add base support for MMIO UARTs

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This adds the ability for the driver to access UARTs via MMIO instead of PIO selectively at runtime, and exposes a new function to add an MMIO port. Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250.c | 78 - gr

[RESEND PATCH 0/7] serial: Add MMIO & SPCR support

2022-12-01 Thread Benjamin Herrenschmidt
This series adds support for MMIO serial ports and auto-configuration via ACPI SPCR. This is necessary for the serial port to work on AWS EC2 "metal" x86 systems. An MMIO serial port can be specified explicitely using the "mmio," prefix for the --port argument to the 'serial' command, the registe

[PATCH 2/7] acpi: Add SPCR and generic address definitions

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt --- include/grub/acpi.h | 51 + 1 file changed, 51 insertions(+) diff --git a/include/grub/acpi.h b/include/grub/acpi.h index 8c126b2b9..17aadb802 100644 --- a/include/grub/acpi.h +++

[PATCH 6/7] ns8250: Support more MMIO access sizes

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt It is common for PCI based UARTs to use larger than one byte access sizes. This adds support for this and uses the information present in SPCR accordingly. Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250-spcr.c | 3 ++- grub-core/term/ns8250.c

[PATCH 5/7] ns8250: Use ACPI SPCR table when available to configure serial

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt "serial auto" is now equivalent to just "serial" and will use the SPCR to discover the port if present, otherwise defaults to "com0" as before. This allows to support MMIO ports specified by ACPI which is needed on AWS EC2 "metal" instances, and will enable grub to p

[PATCH 4/7] ns8250: Add configuration parameter when adding ports

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This will allow ports to be added with a pre-set configuration Signed-off-by: Benjamin Herrenschmidt --- grub-core/term/ns8250.c | 25 +++-- grub-core/term/serial.c | 2 +- include/grub/serial.h | 4 ++-- 3 files changed, 22 insertions(+), 9

[PATCH 7/7] serial: Add ability to specify MMIO ports via 'serial'

2022-12-01 Thread Benjamin Herrenschmidt
From: Benjamin Herrenschmidt This adds the ability to explicitely add an MMIO based serial port via the 'serial' command. The syntax is: serial --port=mmio,{.b,.w,.l,.q} Signed-off-by: Benjamin Herrenschmidt --- docs/grub.texi | 26 -- grub-core/term/serial.c