SC2070 (error): -n doesn't work with unquoted arguments.
Quote or use [[ ]].
In grub-completion.bash.in line 130:
[ -n $tmp ] && {
^--^ SC2070 (error)
ref:https://github.com/koalaman/shellcheck/wiki/SC2070
Signed-off-by: "t.feng"
---
util/bash-completion.d/grub-co
In grub-completion.bash.in line 115:
local config_file=$(__grub_dir)/grub.cfg
^-^ SC2155 (warning)
In grub-completion.bash.in line 126:
local grub_dir=$(__grub_dir)
^--^ SC2155 (warning)
ref:https://github.com/koalaman/shellcheck/wiki/SC2155
Signed-off-by:
SC2207 (warning): Prefer mapfile or read -a to split
command output (or quote to avoid splitting).
In grub-completion.bash.in line 56:
COMPREPLY=($(compgen -P "${2-}" -W "${1-}" -S "${4-}" --
"$cur"))
^-- SC2207 (warning)
In grub-completion.bash.in line 119:
COM
Hi,
The patch set fix some warning and error in grub-completion.bash.in.
And shellcheck also provides 'info' and 'style' level check, i think
grub do not need to modify.
shellcheck -s bash -S warning grub-completion.bash.in
shellcheck:https://github.com/koalaman/shellcheck
V2:
split warnings p
In grub-completion.bash.in line 63:
__grub_get_options_from_help () {
^-- SC2120 (warning)
SC2120: the current code meets the exception and does not need to be
modified. So we disable it.
ref:https://github.com/koalaman/shellcheck/wiki/SC2120
Signed-off-by: "t.feng"
---
util/bash-completion.d/
Hi,
On 2022/11/30 02:35, Steve McIntyre wrote:
Hey folks!
So, with the latest set of GRUB CVE patches we've fixed up a bunch of
potential crashes in font-handling code that could lead to Secure Boot
holes. These are good and useful fixes, and thanks to Zhang Boyang and
everyone else involved!
Zhang Boyang writes:
> On 2022/11/30 02:35, Steve McIntyre wrote:
>
>> AFAIK Chris Coulson has a patch for the font loader to cause it to try
>> loading fonts from the embedded memdisk first. Is that the best
>> approach? If so, what fonts should we be embedding in the signed
>> image? It's a tra
On 11/24/22 12:56, Daniel Kiper wrote:
Hi,
Adding Sudhakar and Glenn...
On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote:
Hello,
This is an addition to the series sent from Daniel Axtens
(https://lists.gnu.org/archive/html/grub-devel/2022-04/msg00064.html).
Patch 'ieee1275:
On 11/30/22 14:47, Stefan Berger wrote:
On 11/24/22 12:56, Daniel Kiper wrote:
Hi,
Adding Sudhakar and Glenn...
On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote:
Hello,
This is an addition to the series sent from Daniel Axtens
(https://lists.gnu.org/archive/html/grub-devel
On 11/30/22 16:24, Stefan Berger wrote:
On 11/30/22 14:47, Stefan Berger wrote:
On 11/24/22 12:56, Daniel Kiper wrote:
Hi,
Adding Sudhakar and Glenn...
On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote:
Hello,
This is an addition to the series sent from Daniel Axtens
(ht
On Wed, 30 Nov 2022 17:42:40 -0500
Stefan Berger wrote:
>
>
> On 11/30/22 16:24, Stefan Berger wrote:
> >
> >
> > On 11/30/22 14:47, Stefan Berger wrote:
> >>
> >>
> >> On 11/24/22 12:56, Daniel Kiper wrote:
> >>> Hi,
> >>>
> >>> Adding Sudhakar and Glenn...
> >>>
> >>> On Thu, Aug 11, 2022 a
On Tue, 29 Nov 2022 18:13:11 +0100
Daniel Kiper wrote:
> First of all, sorry for late reply. I hope I will be able to review
> next version of this patch much faster.
>
> On Sat, Oct 29, 2022 at 05:40:42PM +, Maxim Fomin wrote:
> > From 2b1d2deb3f2416cbc3e7d25cbc4141a3078eaf68 Mon Sep 17 00:
12 matches
Mail list logo
