Re: [PATCH] loader: Ensure the newc pathname is NULL-terminated

2022-11-24 Thread Daniel Kiper
On Thu, Nov 24, 2022 at 11:54:28AM +0800, Gary Lin via Grub-devel wrote: > On Wed, Nov 23, 2022 at 03:44:54PM +0100, Daniel Kiper wrote: > > On Wed, Nov 23, 2022 at 02:40:21PM +0800, Gary Lin via Grub-devel wrote: > > > Per "man 5 cpio", the namesize in the cpio header includes the trailing > > > N

Re: Possible memory fault in fs/iso9660 (correction)

2022-11-24 Thread Daniel Kiper
On Sat, Nov 19, 2022 at 01:57:59PM +0100, Thomas Schmitt wrote: > Hi, > > i wrote: > > I think the loop end condition should use 4 rather than 1: > > (char *) entry < (char *) sua + sua_size - 4 && entry->len > 0 > > Urm ... better "3 rather than 1": > >(char *) entry < (char *) sua +

Re: [programmer11...@programist.ru: Bug#1021846: grub-install is broken since 2.06-3: error: unknown filesystem]

2022-11-24 Thread Daniel Kiper
Adding Daniel Axtens... On Tue, Nov 15, 2022 at 06:31:45PM +, Steve McIntyre wrote: > Hi all! > > программист некто (in CC) reported this bug a few weeks back in > Debian. Since I applied the bundle of filesystem bounds-checking fixes > a few months back, he can't run grub-install. He's done t

Re: Possible memory fault in fs/iso9660 (correction)

2022-11-24 Thread Thomas Schmitt
Hi, (Again i Cc t.feng in the hope that the review is not finished yet. :)) Daniel Kiper wrote: > I am not an ISO format expert but your thinking LGTM. So you agree that "3" is really the right number if any remaining bytes fewer than 4 shall be ignored ? (I don't trust myself, although i made a

Re: [PATCH v2] tpm: Disable tpm verifier if tpm is not present

2022-11-24 Thread Daniel Kiper
On Mon, Oct 17, 2022 at 01:19:08PM +0800, Michael Chang via Grub-devel wrote: > On Fri, Oct 14, 2022 at 11:40:01AM +0200, Daniel Kiper wrote: > > On Fri, Oct 07, 2022 at 01:37:10PM +0800, Michael Chang via Grub-devel > > wrote: > > > This helps to prevent out of memory error when reading large fil

Re: [PATCH v3 0/2] Fix installation issues on ppc64le

2022-11-24 Thread Daniel Kiper
On Mon, Sep 05, 2022 at 02:39:45PM +0200, Ismael Luceno wrote: > If the nvram device is non-functional, e.g. because the nvram module isn't > loaded and it's file been removed from the filesystem, thus can't be > loaded, the installation will be attempted but the system will be left in > an unboota

Re: [RESEND PATCH] templates: Set defaults using var substitution

2022-11-24 Thread Daniel Kiper
On Wed, Aug 24, 2022 at 03:36:07PM +0200, Ismael Luceno wrote: > Signed-off-by: Ismael Luceno Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 0/6] Dynamic allocation of memory regions and IBM vTPM v2

2022-11-24 Thread Daniel Kiper
Hi, Adding Sudhakar and Glenn... On Thu, Aug 11, 2022 at 02:40:58PM -0300, Diego Domingos wrote: > Hello, > > This is an addition to the series sent from Daniel Axtens > (https://lists.gnu.org/archive/html/grub-devel/2022-04/msg00064.html). > > Patch 'ieee1275: request memory with ibm,client-arc

Re: [programmer11...@programist.ru: Bug#1021846: grub-install is broken since 2.06-3: error: unknown filesystem]

2022-11-24 Thread sudhakar
Hi Steve, It seems invalid Commit id which you reported. It should be 4bd9877f62166b7e369773ab92fe24a39f6515f8 did you applied below patch and tested? Could you please confirm that. fs/f2fs: Do not read past the end of nat journal entries https://git.savannah.gnu.org/cgit/grub.git/patch/?id=4

Re: [PATCH v2] tpm: Disable tpm verifier if tpm is not present

2022-11-24 Thread Michael Chang via Grub-devel
On Thu, Nov 24, 2022 at 05:04:48PM +0100, Daniel Kiper wrote: > On Mon, Oct 17, 2022 at 01:19:08PM +0800, Michael Chang via Grub-devel wrote: > > On Fri, Oct 14, 2022 at 11:40:01AM +0200, Daniel Kiper wrote: > > > On Fri, Oct 07, 2022 at 01:37:10PM +0800, Michael Chang via Grub-devel > > > wrote:

[PATCH v2] loader: Ensure the newc pathname is NULL-terminated

2022-11-24 Thread Gary Lin via Grub-devel
Per "man 5 cpio", the namesize in the cpio header includes the trailing NUL byte of the pathname and the pathname is followed by NUL bytes, but the current implementation ignores the trailing NUL byte when making the newc header. Although make_header() tries to pad the pathname string, the padding