Re: [PATCH v3 1/1] Add paging instructions to normal and help prompts

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 01:05:37PM -0400, Robbie Harwood wrote: > This is not an ideal solution, as interactive users must always ru na > command in order to get the behavior they want, but it avoids > problematic interactions between prompting and sourcing files. > > Signed-off-by: Robbie Harwood

[PATCH] Correct `GRUB_DISABLE_LINUX_PARTUUID` documentation

2022-11-08 Thread Damian Szuberski
Signed-off-by: szubersk --- docs/grub.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git docs/grub.texi docs/grub.texi index 2d6cd8358..969493577 100644 --- docs/grub.texi +++ docs/grub.texi @@ -1671,7 +1671,8 @@ command. @end multitable Remember, @samp{GRUB_DISABLE_LINUX

Re: [PATCH v4 0/3] tpm: Don't propagate measurement failures to the verifiers layer

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 12:13:33PM -0400, Robbie Harwood wrote: > Address review from Daniel (interdiff attached). I moved the variable parsing > into its own function since it has gotten large enough I'd rather it not get > rewritten every time we need a variable as a boolean. > > Note that I do

Re: [PATCH v6 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2022-11-08 Thread Fabian Vogt
Hi, I've played around with LUKS2 using cipher_null and discovered a small issue with error handling. Am Freitag, 8. Juli 2022, 12:06:08 CET schrieb Josselin Poiret via Grub-devel: > This lets a LUKS2 cryptodisk have its cipher and hash filled out, > otherwise they wouldn't be initialized if chea

Re: [PATCH v3 1/1] Add paging instructions to normal and help prompts

2022-11-08 Thread Robbie Harwood
Daniel Kiper writes: > On Fri, Nov 04, 2022 at 01:05:37PM -0400, Robbie Harwood wrote: > >> --- >> grub-core/commands/help.c | 2 ++ >> grub-core/normal/main.c | 3 ++- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/grub-core/commands/help.c b/grub-core/commands/help.c >

Re: [v6 PATCH 1/3] loader: Move arm64 linux loader to common code

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 04:26:05PM -0700, Atish Patra wrote: > ARM64 linux loader code is written in such a way that it can be reused > across different architectures without much change. Move it to common > code so that RISC-V doesn't have to define a separate loader. > > Reviewed-by: Daniel Kiper

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > Update the RISC-V Linux kernel image headers as per the current header. > > Reference: > /Documentation/riscv/boot-image-header.rst > > 474efecb65dc: ("riscv: modify the Image header to improve compatibility with > the ARM64 header")

Re: [v6 PATCH 3/3] RISC-V: Use common linux loader

2022-11-08 Thread Daniel Kiper
On Fri, Nov 04, 2022 at 04:26:07PM -0700, Atish Patra wrote: > RISC-V doesn't have to do anything very different from other architectures > to loader EFI stub linux kernel. As a result, just use the common linux > loader instead of defining a RISC-V specific linux loader. > > Signed-off-by: Atish P

Re: [PATCH] Correct `GRUB_DISABLE_LINUX_PARTUUID` documentation

2022-11-08 Thread Daniel Kiper
On Tue, Nov 08, 2022 at 07:44:50PM +1000, Damian Szuberski wrote: > Signed-off-by: szubersk Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] grub-core: Pass -P to zpool status

2022-11-08 Thread Daniel Kiper
On Tue, Nov 08, 2022 at 12:22:36AM +0100, Arsen Arsenović via Grub-devel wrote: > zpool status by default prints basenames of VDEVs, which means that GRUB > would have to go around guessing to see whether a VDEV exists. Instead, > it'd be more robust to simply tell zpool to give us full paths to V

Re: [v6 PATCH 2/3] RISC-V: Update image header

2022-11-08 Thread Ard Biesheuvel
On Tue, 8 Nov 2022 at 16:59, Daniel Kiper wrote: > > On Fri, Nov 04, 2022 at 04:26:06PM -0700, Atish Patra wrote: > > Update the RISC-V Linux kernel image headers as per the current header. > > > > Reference: > > /Documentation/riscv/boot-image-header.rst > > > > 474efecb65dc: ("riscv: modify the

Re: [PATCH] grub-core: Pass -P to zpool status

2022-11-08 Thread Arsen Arsenović via Grub-devel
Daniel Kiper writes: > Missing "Signed-off-by: Arsen Arsenović " line. > I can add it on your behalf if you are OK with it. Ah, apologies, I didn't know GRUB collects signoffs. I'll keep that in mind for the future, and yes, go ahead and add it. Thanks, and have a great evening! :) -- Arsen