Re: [PATCH v2 1/1] normal: Add paging instructions to interactive prompt

On Thu, Nov 03, 2022 at 05:50:51PM -0400, Robbie Harwood wrote: > Daniel Kiper writes: > > On Mon, Oct 31, 2022 at 03:35:49PM -0400, Robbie Harwood wrote: > >> Conditionally add instructions for enabling paging to the prompt of > >> interactive shells. This is not an ideal solution, as ineractive

[PATCH v4 1/3] types: make bool generally available

Add an include on stdbool.h, making the bool type generally available within grub without needing to add a file-specific include every time it would be used. Signed-off-by: Robbie Harwood --- grub-core/commands/parttool.c | 2 +- grub-core/loader/arm64/linux.c | 1 - grub-core/parttool/msdospar

[PATCH v4 0/3] tpm: Don't propagate measurement failures to the verifiers layer

Address review from Daniel (interdiff attached). I moved the variable parsing into its own function since it has gotten large enough I'd rather it not get rewritten every time we need a variable as a boolean. Note that I do not have a machine with a broken TPM for testing fallback. Be well, --Ro

[PATCH v4 2/3] env: add function for retrieving variables as booleans

Signed-off-by: Robbie Harwood --- grub-core/kern/env.c | 13 + include/grub/env.h | 1 + 2 files changed, 14 insertions(+) diff --git a/grub-core/kern/env.c b/grub-core/kern/env.c index 10e08ad76c..7640688963 100644 --- a/grub-core/kern/env.c +++ b/grub-core/kern/env.c @@ -144,6 +

[PATCH v4 3/3] tpm: Don't propagate measurement failures to the verifiers layer

Currently if an EFI firmware fails to do a TPM measurement for a file, the error will be propagated to the verifiers framework which will prevent it to be opened. This mean that buggy firmwares will lead to the system not booting because files won't be allowed to be loaded. But a failure to do a T

[PATCH v3 1/1] Add paging instructions to normal and help prompts

This is not an ideal solution, as interactive users must always ru na command in order to get the behavior they want, but it avoids problematic interactions between prompting and sourcing files. Signed-off-by: Robbie Harwood --- grub-core/commands/help.c | 2 ++ grub-core/normal/main.c | 3 ++-

[PATCH v3 0/1] Add paging instructions to normal and help prompts

Rewrite to address review and clarifications with suggestion from Daniel (thanks). Be well, --Robbie Robbie Harwood (1): Add paging instructions to normal and help prompts grub-core/commands/help.c | 2 ++ grub-core/normal/main.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) --

[v6 PATCH 2/3] RISC-V: Update image header

Update the RISC-V Linux kernel image headers as per the current header. Reference: /Documentation/riscv/boot-image-header.rst 474efecb65dc: ("riscv: modify the Image header to improve compatibility with the ARM64 header") Acked-by: Heinrich Schuchardt Signed-off-by: Atish Patra --- include/g

[v6 PATCH 3/3] RISC-V: Use common linux loader

RISC-V doesn't have to do anything very different from other architectures to loader EFI stub linux kernel. As a result, just use the common linux loader instead of defining a RISC-V specific linux loader. Signed-off-by: Atish Patra --- grub-core/Makefile.core.def| 4 +-- grub-core/loader/r

[v6 PATCH 1/3] loader: Move arm64 linux loader to common code

ARM64 linux loader code is written in such a way that it can be reused across different architectures without much change. Move it to common code so that RISC-V doesn't have to define a separate loader. Reviewed-by: Daniel Kiper Signed-off-by: Atish Patra --- grub-core/Makefile.core.def

[v6 PATCH 0/3] Unify ARM64 & RISC-V Linux Loader

This series unifies the linux loader for ARM64 & RISC-V. The linux loader for ARM64 is pretty much arch independent. Thus, this series just moves it to the common directory and update the make files. This series is rebased on top of Ard's LoadFile2 series[1]. The unification effort was a little m