Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
Daniel Axtens writes: >>> Have you checked that you can't boot them with HFS+? Because HFS+ >>> came in 1998, which was (AFAICT) pretty early on in the G3 >>> lifecycle. So I'd be really surprised if the firmware didn't support >>> booting from HFS+. I'd be very keen to hear. >> >> I have not tes

Re: [PATCH] Remove HFS support

2022-08-30 Thread John Paul Adrian Glaubitz
On 8/30/22 18:37, Robbie Harwood wrote: As the person currently responsible for the Red Hat tree: I am also not happy about this state of affairs. I don't want to sound rude, but GRUB isn't a RedHat-only project, it's a community project. So, while I understand RH's point of view, I would also

Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
"Vladimir 'phcoder' Serbinenko" writes: > Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit : > >> Let me answer this out of order. >> >>> I understand the need to sometimes get rid of old code, but since >>> the HFS module can be blacklisted as Vladimir explains, I don't >>> really understand

Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
John Paul Adrian Glaubitz writes: > On 8/30/22 18:37, Robbie Harwood wrote: > >> As the person currently responsible for the Red Hat tree: I am also >> not happy about this state of affairs. > > I don't want to sound rude, but GRUB isn't a RedHat-only project, it's a > community project. Nowhere

Re: [PATCH v2 2/3] term/serial: Add support for PCI serial devices

2022-08-30 Thread Glenn Washburn
On Mon, 29 Aug 2022 12:53:54 +0200 Peter Zijlstra wrote: > On Fri, Aug 26, 2022 at 01:32:25PM -0500, Glenn Washburn wrote: > > On Fri, 26 Aug 2022 13:01:44 +0200 > > pet...@infradead.org wrote: > > > > > Loosely based on early_pci_serial_init() from Linux, allow GRUB to make > > > use of PCI ser

Re: [PATCH v6 2/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-08-30 Thread Glenn Washburn
On Mon, 29 Aug 2022 07:38:24 +0200 Patrick Steinhardt wrote: > On Fri, Aug 19, 2022 at 06:06:15PM -0500, Glenn Washburn wrote: > > A user can now specify UUID strings with dashes, instead of having to remove > > dashes. This is backwards-compatability preserving and also fixes a source > > of use

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Robbie Harwood
Philip Müller writes: >> Hello Robbie, hello Daniel, >> >> with the commit 26031d3b101648352e4e427f04bf69d320088e77 >> 30_uefi-firmware will always call `fwsetup --is-supported' to check >> if the system supports EFI or not. However most installed grub >> versions on MBR don't support the '--is-s

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Mike Gilbert
On Tue, Aug 30, 2022 at 4:16 PM Robbie Harwood wrote: > Why doesn't grub on the MBR get updated when you install a new grub > package? That seems like the real issue here - what am I missing? I think the grub project tries to maintain config file compatibility with older versions so that users c

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
On 8/30/22 23:14, Mike Gilbert wrote:> On Tue, Aug 30, 2022 at 4:16 PM Robbie Harwood wrote: >> Why doesn't grub on the MBR get updated when you install a new grub >> package? That seems like the real issue here - what am I missing? > > I think the grub project tries to maintain config file com

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 30.08.22 23:34, Javier Martinez Canillas wrote: You could add a feature flag, which causes grub-core to set an environment variable when a new feature is supported. See the features array in grub-core/normal/main.c. You would then check for this feature flag in the grub.d snippet before calli

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Javier Martinez Canillas
On 8/31/22 00:07, Philip Müller wrote: > On 30.08.22 23:34, Javier Martinez Canillas wrote: >>> You could add a feature flag, which causes grub-core to set an >>> environment variable when a new feature is supported. See the features >>> array in grub-core/normal/main.c. >>> >>> You would then chec

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Philip Müller via Grub-devel
On 31.08.22 00:43, Javier Martinez Canillas wrote: To prevent that, let's partially revert the mentioned commit and keep the old logic that didn't execute the `fwsetup` command and just included an entry for it if GRUB is executed in an EFI platform. I was about to do the same on my end when we

[PATCH] fs/ext2: ignore the large_dir incompat feature

2022-08-30 Thread Theodore Ts'o
Recently, ext4 added the a large_dRecently, ext4 added the a large_dir feature, which adds support for a 3 level htree directory support. Grub supports existing file systems with htree directories by ignoring their existence, and since the index nodes for the hash tree look like deleted directory

Re: [Regression] efi: Don't display a uefi-firmware entry if it's not supported

2022-08-30 Thread Luna Jernberg
Had this problem on my Arch Linux and EOS setup had to chroot in and fiddle with this last week: https://youtu.be/b_KHtK2b5cA On 8/31/22, Philip Müller via Grub-devel wrote: > On 31.08.22 00:43, Javier Martinez Canillas wrote: >> To prevent that, let's partially revert the mentioned commit and ke

Re: [PATCH 3/5] ns8250: Add base support for MMIO UARTs

2022-08-30 Thread Benjamin Herrenschmidt
On Mon, 2022-05-23 at 19:11 +0200, Sven Anderson wrote: > > I had a couple of sleepless nights trying to find out why this didn't > work for my MMIO UART (Intel Cannon Lake PCH Intel C246), so I > thought I would share my findings with others in a similar situation. > (See below.) >   .../... >