[PATCH] util/grub-mkfont: Fix resource leaks

2022-08-01 Thread Qiumiao Zhang via Grub-devel
--- util/grub-mkfont.c | 5 + 1 file changed, 5 insertions(+) diff --git a/util/grub-mkfont.c b/util/grub-mkfont.c index f07566ade..0070edf19 100644 --- a/util/grub-mkfont.c +++ b/util/grub-mkfont.c @@ -699,6 +699,7 @@ add_font (struct grub_font_info *font_info, FT_Face face, int nocut)

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread Glenn Washburn
On Sat, 30 Jul 2022 11:54:32 +0200 (CEST) brutser--- via Grub-devel wrote: > Glenn, > > > > As I had no idea how to get the debug logs from qemu, I made screenshots, > find them attached. As this is probably something I am doing wrong, I hope it > shows from the logs. > > https://imgur.com/

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
Glenn, Still resorted to screenshots for the debug (with the added dprintf): https://imgur.com/a/YkVMdBe Van: Glenn Washburn Aan: brutser--- via Grub-devel Onderwerp: Re: [PATCH v3 0/3] Cryptomount detached headers Datum: 01/08/2022 22:50:27 Europe/Paris Cc: brut...@perso.be;    dki...@n

Re: [PATCH v5 9/9] tests: add support for LoongArch

2022-08-01 Thread Glenn Washburn
On Fri, 29 Jul 2022 15:12:01 +0800 Xiaotian Wu wrote: > Signed-off-by: Xiaotian Wu > --- > tests/ahci_test.in | 2 +- > tests/ehci_test.in | 2 +- > tests/ohci_test.in | 2 +- > tests/partmap_test.in| 2 +- > tests/pata_test.in | 2 +- > tests/uhci_test.in

Re: [PATCH v5 0/9] Add support for LoongArch

2022-08-01 Thread Glenn Washburn
On Sat, 30 Jul 2022 14:43:02 +0800 (GMT+08:00) 武校田 wrote: > Thanks for your reply. > > > Thanks for doing this testing. What are the values passed for the > > configure options --build, --host, and --target? > > I compiled it on my local machine, using the Archlinux 2022.03 LoongArch > version,

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread Glenn Washburn
On Sat, 30 Jul 2022 20:48:54 +0200 (CEST) brutser--- via Grub-devel wrote: > Glenn, > > > > The most obvious error that jumps out: > > Read out of range: sector 0x32000 (attempt to read or write outside partition) This looks like a red-herring to me. I believe it happens because in opening

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread Glenn Washburn
On Tue, 2 Aug 2022 00:21:09 +0200 (CEST) brutser--- via Grub-devel wrote: > Glenn, > > > > Still resorted to screenshots for the debug (with the added dprintf): > > > > https://imgur.com/a/YkVMdBe Ok, that confirms that the luks2 module is loaded and that the scan is happening. Based on t

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
Debian 11.4 for all the testing. as i said, i execute shell during installation, then simply enter the commands I wrote earlier: cryptsetup luksFormat --type luks2 -q -h sha512 -s 512 --pbkdf pbkdf2 --header /root/header.bin --luks2-metadata-size=16k --luks2-keyslots-size=512k /dev/sda2 cr

Re: [PATCH v3 0/3] Cryptomount detached headers

2022-08-01 Thread brutser--- via Grub-devel
Glenn, But my testing is very limited, i only create grub payload for coreboot and then i create the encrypted sda2 from the debian expert installer etc. If you got suggestions with this setup, how i can do another way of testing, let me know and I will do it. Van: brutser--- via Grub-

Re: [PATCH v5 0/9] Add support for LoongArch

2022-08-01 Thread Xiaotian Wu
在 2022/8/2 上午6:44, Glenn Washburn 写道: On Sat, 30 Jul 2022 14:43:02 +0800 (GMT+08:00) 武校田 wrote: Thanks for your reply. > Thanks for doing this testing. What are the values passed for the > configure options --build, --host, and --target? I compiled it on my local machine, using the Archlinu

Re: [PATCH v5 9/9] tests: add support for LoongArch

2022-08-01 Thread Xiaotian Wu
在 2022/8/2 上午6:33, Glenn Washburn 写道: On Fri, 29 Jul 2022 15:12:01 +0800 Xiaotian Wu wrote: Signed-off-by: Xiaotian Wu --- tests/ahci_test.in | 2 +- tests/ehci_test.in | 2 +- tests/ohci_test.in | 2 +- tests/partmap_test.in| 2 +- tests/pata_test.in |