[PATCH v1 0/3] FAT: fix mtime 0 breaking updates

The first two commits are to make debugging grub-probe failures easier, while the third is the actual fix. A Fedora user reported a problem with grub2-mkconfig failing on their system. This was caused by a grub2-probe failure probing the ESP. It transpired that some files on the ESP had mtime of

[PATCH v1 1/3] grub-probe: document the behavior of multiple -v

Signed-off-by: Robbie Harwood --- util/grub-probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/grub-probe.c b/util/grub-probe.c index 01d26bb87d..446bd25532 100644 --- a/util/grub-probe.c +++ b/util/grub-probe.c @@ -732,7 +732,8 @@ static struct argp_option options

[PATCH v1 3/3] fs/fat: don't error when mtime is 0

In the wild, we occasionally see valid ESPs where some file modification times are 0. For instance: ├── [Dec 31 1979] EFI │ ├── [Dec 31 1979] BOOT │ │ ├── [Dec 31 1979] BOOTX64.EFI │ │ └── [Dec 31 1979] fbx64.efi │ └── [Jun 27 02:41] fedora │ ├──

[PATCH v1 2/3] grub_fs_probe(): dprint errors from filesystems

When filesystem detection fails, all that's currently debug-logged is a series of messages like: grub-core/kern/fs.c:56:fs: Detecting ntfs... grub-core/kern/fs.c:76:fs: ntfs detection failed. repeated for each filesystem. Any messages provided to grub_error() by the filesystem are lost,

Re: [PATCH] Initialize local relocator subchunk struct to all zeros

On Thu, Jul 14, 2022 at 03:38:04PM +0100, Darren Kenny wrote: > Hi Ross, > > This looks good to me. > > On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote: > > The way the code is written the tofree variable would never be > > passed to the free_subchunk() function uninitialized. Cover