[PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-14 Thread Ross Philipson
The way the code is written the tofree variable would never be passed to the free_subchunk() function uninitialized. Coverity cannot determine this and flags the situation as "Using uninitialized value...". The fix is just to initialize the local struct. Fixes: CID 314016 Signed-off-by: Ross Phil

Re: [PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-14 Thread Darren Kenny
Hi Ross, This looks good to me. On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote: > The way the code is written the tofree variable would never be > passed to the free_subchunk() function uninitialized. Coverity > cannot determine this and flags the situation as "Using uninitialized

Re: [PATCH v4 1/1] plainmount: Support plain encryption mode

2022-07-14 Thread Glenn Washburn
On Mon, 11 Jul 2022 19:35:47 + Maxim Fomin wrote: > --- Original Message --- > On Sunday, July 10th, 2022 at 9:07 PM, Glenn Washburn > wrote: > > > > + > > > +plainmount hd0,gpt1 -o 1048576 > > > + > > > + > > > +both create virtual devices with 1MiB offset on top of the specified

[PATCH v3 1/1] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2022-07-14 Thread Robbie Harwood
From: Peter Jones On my laptop running at 2.4GHz, if I run a VM where tsc calibration using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds to do so (as measured with the stopwatch on my phone), with a tsc delta of 0x1cd1c85300, or around 125 billion cycles. If instead of tryi

[PATCH v3 0/1] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2022-07-14 Thread Robbie Harwood
This is actually the fourth time this patch has been posted, but last time it was v2, so I guess we're zero-indexing. Changes from v2: - Rebase forward 6 months - Grammar pass over commit message to address Paul Menzel's review Be well, --Robbie Peter Jones (1): i386: Make pmtimer tsc calibrat