Re: [PATCH v2 2/2] docs: Document efitextmode command

2022-07-12 Thread Daniel Kiper
On Fri, Jul 08, 2022 at 07:29:51PM -0500, Glenn Washburn wrote: > On Tue, 5 Jul 2022 16:01:04 +0200 > Daniel Kiper wrote: > > > On Fri, May 13, 2022 at 12:54:12PM -0500, Glenn Washburn wrote: > > > Signed-off-by: Glenn Washburn > > > > I think this patch should be merged with patch #1. > > > > >

Re: [PATCH v5 1/2] json: Add function to unescape JSON-encoded strings

2022-07-12 Thread Daniel Kiper
On Mon, Jul 11, 2022 at 09:08:09AM -0400, Nicholas Vinson wrote: > On 7/11/22 06:44, Patrick Steinhardt wrote: > > JSON strings require certain characters to be encoded, either by using a > > single reverse solidus character "\" for a set of popular characters, or > > by using a Unicode representat

Re: [PATCH v5 2/2] luks2: Fix decoding of digests and salts with escaped chars

2022-07-12 Thread Daniel Kiper
On Mon, Jul 11, 2022 at 12:44:59PM +0200, Patrick Steinhardt wrote: > It was reported in the #grub IRC channel on Libera that decryption of > LUKS2 partitions fails with errors about invalid digests and/or salts. > In all of these cases, what failed was decoding the Base64 > representation of these

Re: [PATCH v5 2/2] luks2: Fix decoding of digests and salts with escaped chars

2022-07-12 Thread Patrick Steinhardt
On Tue, Jul 12, 2022 at 03:30:22PM +0200, Daniel Kiper wrote: > On Mon, Jul 11, 2022 at 12:44:59PM +0200, Patrick Steinhardt wrote: > > It was reported in the #grub IRC channel on Libera that decryption of > > LUKS2 partitions fails with errors about invalid digests and/or salts. > > In all of thes

[PATCH V4 1/3] efi/tpm.c: Refine the status of log event

2022-07-12 Thread Lu Ken
1. Use macro GRUB_ERR_NONE instead of hard code 0. 2. Keep lowercase of the first char for the status string of log event. Signed-off-by: Lu Ken --- grub-core/commands/efi/tpm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/grub-core/commands/efi/tpm.c b/grub-cor

[PATCH V4 2/3] efi/tpm.c: Uses grub_strcpy() to replace grub_memcpy()

2022-07-12 Thread Lu Ken
The event description is a string, so using grub_strcpy() is cleaner way than grub_memcpy(). Signed-off-by: Lu Ken --- grub-core/commands/efi/tpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/commands/efi/tpm.c b/grub-core/commands/efi/tpm.c index 7acf51049.

[PATCH V4 3/3] efi/tpm.c: Enable EFI_CC_MEASUREMENT_PROTOCOL

2022-07-12 Thread Lu Ken
EFI_CC_MEASUREMENT_PROTOCOL abstract the measurement for virtual firmware in confidential computing environment. It similiar to EFI_TCG2_PROTOCOL. It is proposed by Intel and ARM and approved by UEFI organization. It is defined in Intel GHCI specification https://cdrdv2.intel.com/v1/dl/getContent

[PATCH V4 0/3] Enable TDX measurement to RTMR register

2022-07-12 Thread Lu Ken
Intel Trust Domain Extensions(Intel TDX) refers to an Intel technology that extends Virtual Machine Extensions(VMX) and Multi-Key Total Memory Encryption(MK-TME) with a new kind of virtual machine guest called a Trust Domain(TD)[1]. A TD runs in a CPU mode that protects the confidentiality of its m