Re: [PATCH v2 0/3] Cryptomount detached headers

2022-05-27 Thread Daniel Kiper
On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote: > Note: Description here has changed since last time, the last few sentences, > which describe a method for allowing backends to bypass the read hook on > the source disk. > > Updates since v1: > * Add marge comment block describing a

Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails

2022-05-27 Thread Daniel Kiper
On Wed, May 11, 2022 at 10:19:44PM -0500, Glenn Washburn wrote: > On failure, the hfs test should show both the host and GRUB determined fs > UUID. Prior to this change, both outputs where generated by GRUB, which is > less helpful in determining the cause of failure. > > Signed-off-by: Glenn Washb

Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-05-27 Thread Robbie Harwood
Michael Chang via Grub-devel writes: > On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: >> Mathieu Desnoyers writes: >> >>> There are no users left of version_find_latest(), version_test_gt(), >>> and version_test_numeric(). Remove those unused helper >>> functions. Using those h

Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails

2022-05-27 Thread Glenn Washburn
On Fri, 27 May 2022 16:16:48 +0200 Daniel Kiper wrote: > On Wed, May 11, 2022 at 10:19:44PM -0500, Glenn Washburn wrote: > > On failure, the hfs test should show both the host and GRUB determined fs > > UUID. Prior to this change, both outputs where generated by GRUB, which is > > less helpful in

Re: [PATCH v2 0/3] Cryptomount detached headers

2022-05-27 Thread Glenn Washburn
On Fri, 27 May 2022 16:06:42 +0200 Daniel Kiper wrote: > On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote: > > Note: Description here has changed since last time, the last few sentences, > > which describe a method for allowing backends to bypass the read hook on > > the source disk

Re: [PATCH v2 0/3] Cryptomount detached headers

2022-05-27 Thread Daniel Kiper
On Fri, May 27, 2022 at 03:20:26PM -0500, Glenn Washburn wrote: > On Fri, 27 May 2022 16:06:42 +0200 > Daniel Kiper wrote: > > On Mon, May 16, 2022 at 04:49:45PM -0500, Glenn Washburn wrote: > > > Note: Description here has changed since last time, the last few > > > sentences, > > > which descri

Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails

2022-05-27 Thread Daniel Kiper
On Fri, May 27, 2022 at 01:39:25PM -0500, Glenn Washburn wrote: > On Fri, 27 May 2022 16:16:48 +0200 > Daniel Kiper wrote: > > > On Wed, May 11, 2022 at 10:19:44PM -0500, Glenn Washburn wrote: > > > On failure, the hfs test should show both the host and GRUB determined fs > > > UUID. Prior to this

Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-05-27 Thread Daniel Kiper
On Fri, May 27, 2022 at 10:56:38AM -0400, Robbie Harwood wrote: > Michael Chang via Grub-devel writes: > > > On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: > >> Mathieu Desnoyers writes: > >> > >>> There are no users left of version_find_latest(), version_test_gt(), > >>> and ver

Re: [PATCH 0/6] Fix coverity bugs and add checks for elf values in grub-core

2022-05-27 Thread Daniel Kiper
On Thu, May 26, 2022 at 03:29:46PM -0400, Alec Brown wrote: > Coverity identified several untrusted loop bounds and untrusted allocation > size > bugs in grub-core/loader/i386/bsdXX.c and grub-core/loader/multiboot_elfXX.c. > Upon review of these bugs, I found that specific checks weren't being ma