Re: [PATCH] efi: Set text-mode console resolution to maximum supported

2022-05-12 Thread Gerd Hoffmann
> > Well, 80x25 is the only text mode which must be supported by the > > firmware. Supporting larger modes is optional. > > > > I think the firmware is also free to choose the default text mode, > > and the implementations I've seen so far seem to be conservative > > and use 80x25 or 80x50 by def

Re: a GRUB command to show the UEFI built-in boot manager

2022-05-12 Thread Gerd Hoffmann
On Wed, May 11, 2022 at 11:31:32AM -0400, Chris Murphy wrote: > Hi, > > There's GRUB command "fwsetup" to bring the user from GRUB to the > firmware's setup menu. > > Could there be a command that brings the user to the firmware's > built-in boot manager? a.k.a. boot order, a.k.a. boot selection?

Re: [PATCH 3/4] cryptodisk: Add options to cryptomount to support keyfiles

2022-05-12 Thread Daniel Kiper
On Fri, May 06, 2022 at 03:45:59AM -0500, Glenn Washburn wrote: > From: John Lane > > Add the options --key-file, --keyfile-offset, and --keyfile-size to > cryptomount and code to put read the requested key file data and pass > via the cargs struct. Note, key file data is for all intents and purpo

Re: [PATCH 4/4] docs: Add documentation on keyfile option to cryptomount

2022-05-12 Thread Daniel Kiper
On Fri, May 06, 2022 at 03:46:00AM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-12 Thread Glenn Washburn
Hi Paul, On Thu, 12 May 2022 08:10:56 +0200 Paul Menzel wrote: > Dear Glenn, > > > Thank you for the patch. > > Am 12.05.22 um 05:07 schrieb Glenn Washburn: > > This command is meant to behave similarly to the 'mode' command of the EFI > > Shell application. One difference is that to set the

Re: [PATCH 3/4] cryptodisk: Add options to cryptomount to support keyfiles

2022-05-12 Thread Glenn Washburn
On Thu, 12 May 2022 19:45:48 +0200 Daniel Kiper wrote: > On Fri, May 06, 2022 at 03:45:59AM -0500, Glenn Washburn wrote: > > From: John Lane > > > > Add the options --key-file, --keyfile-offset, and --keyfile-size to > > cryptomount and code to put read the requested key file data and pass > > v

Re: [PATCH 1/2] efi: Add efitextmode command for getting/setting the text mode resolution

2022-05-12 Thread Paul Menzel
Dear Glenn, Am 12.05.22 um 20:29 schrieb Glenn Washburn: On Thu, 12 May 2022 08:10:56 +0200 Paul Menzel wrote: Am 12.05.22 um 05:07 schrieb Glenn Washburn: This command is meant to behave similarly to the 'mode' command of the EFI Shell application. One difference is that to set the mode t

Re: [PATCH v2 0/2] Have LUKS2 cryptomounts be useable with grub-probe

2022-05-12 Thread Glenn Washburn
Hi Josselin, Have this on my list of things to circle back to but it got pushed to the bottom. So sorry about taking so long. Thanks for the submitting this. This approach seems the most complete of the other patch series attempting to fix this issue and I'd like to get it merged in in some form.

Re: [PATCH v2 1/2] devmapper/getroot: Have devmapper recognize LUKS2

2022-05-12 Thread Glenn Washburn
On Sat, 11 Dec 2021 13:29:44 +0100 Josselin Poiret wrote: > Changes UUID comparisons so that LUKS1 and LUKS2 are both recognized > as being LUKS cryptodisks. > --- > grub-core/osdep/devmapper/getroot.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/grub-core/os

Re: [PATCH v2 2/2] devmapper/getroot: Set up cheated LUKS2 cryptodisk mount from DM parameters

2022-05-12 Thread Glenn Washburn
On Sat, 11 Dec 2021 13:29:45 +0100 Josselin Poiret wrote: > This lets a LUKS2 cryptodisk have all the cipher, hash, and sizes > filled out, otherwise they wouldn't be initialized if cheat mounted. > --- > grub-core/osdep/devmapper/getroot.c | 99 - > 1 file changed, 9

Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-12 Thread Glenn Washburn
On Thu, 12 May 2022 08:08:32 +0200 Paul Menzel wrote: > Dear Glenn, > > > Thank you for the patch. Two small nits. > > Am 12.05.22 um 05:07 schrieb Glenn Washburn: > > Signed-off-by: Glenn Washburn > > *Add documentation for …* could be abbreviated to *Document …* in the > git commit messag

Re: [PATCH 0/2] Add efitextmode command

2022-05-12 Thread Gerd Hoffmann
On Wed, May 11, 2022 at 10:07:33PM -0500, Glenn Washburn wrote: > This patch add the efitextmode command which is used for showing all > available text output modes and setting a specific mode. Its basically the > equivalent of the EFI Shell's "mode" command and its output looks similar. > The main

Re: [PATCH 2/2] docs: Add documentation for the efitextmode command

2022-05-12 Thread Paul Menzel
Dear Glenn, Am 13.05.22 um 00:46 schrieb Glenn Washburn: On Thu, 12 May 2022 08:08:32 +0200 Paul Menzel wrote: […] Am 12.05.22 um 05:07 schrieb Glenn Washburn: Signed-off-by: Glenn Washburn *Add documentation for …* could be abbreviated to *Document …* in the git commit message summary.