[PATCH 0/4] Cryptomount keyfile support

2022-05-06 Thread Glenn Washburn
I'm breaking the keyfile and detached header patch series into two series. I think that the detached header patches can be improved and I don't want to hold up the more trivial keyfile support patches. This series is patches #1, #2, #5, and a split of #7, the documentation patch. The first two pat

[PATCH 2/4] cryptodisk: geli: Unify grub_cryptodisk_dev function names

2022-05-06 Thread Glenn Washburn
From: Denis 'GNUtoo' Carikli Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt Reviewed-by: Daniel Kiper --- grub-core/disk/geli.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grub-core/disk/geli.c b/grub-core/disk/geli.c index 445a66878..91e

[PATCH 1/4] cryptodisk: luks: Unify grub_cryptodisk_dev function names

2022-05-06 Thread Glenn Washburn
From: Denis 'GNUtoo' Carikli Signed-off-by: Denis 'GNUtoo' Carikli Reviewed-by: Patrick Steinhardt Reviewed-by: Daniel Kiper --- grub-core/disk/luks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/disk/luks.c b/grub-core/disk/luks.c index 46ae734ef..7f837d5

[PATCH 3/4] cryptodisk: Add options to cryptomount to support keyfiles

2022-05-06 Thread Glenn Washburn
From: John Lane Add the options --key-file, --keyfile-offset, and --keyfile-size to cryptomount and code to put read the requested key file data and pass via the cargs struct. Note, key file data is for all intents and purposes equivalent to a password given to cryptomount. So there is no need to

[PATCH 4/4] docs: Add documentation on keyfile option to cryptomount

2022-05-06 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- docs/grub.texi | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/grub.texi b/docs/grub.texi index 5de94d062..3f01871f7 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -4356,11 +4356,15 @@ Alias for @code{hashsum --hash cr

[PATCH] efi: Set text-mode console resolution to maximum supported

2022-05-06 Thread Glenn Washburn
On some buggy EFI firmwares, GRUB is started with the console resolution set to the maximum but the output console EFI object has the mode set as 0, which is the minimum supported mode of 80x25 characters. This causes strange behavior at the GRUB shell where output can fill the screen, but the prom

Re: [PATCH] efi: Set text-mode console resolution to maximum supported

2022-05-06 Thread Gerd Hoffmann
Hi, > On some buggy EFI firmwares, GRUB is started with the console resolution > set to the maximum but the output console EFI object has the mode set as > 0, which is the minimum supported mode of 80x25 characters. This causes > strange behavior at the GRUB shell where output can fill the scree

[PATCH v2] efi: Set text-mode console resolution to maximum supported

2022-05-06 Thread Glenn Washburn
On some buggy EFI firmwares, GRUB is started with the console resolution set to the maximum but the output console EFI object has the mode set as 0, which is the minimum supported mode of 80x25 characters. This causes strange behavior at the GRUB shell where output can fill the screen, but the prom

Re: [PATCH v2] efi: Set text-mode console resolution to maximum supported

2022-05-06 Thread Gerd Hoffmann
Hi, > v2: Fix to query each mode instead of just the current mode Oh, right, that is another one ... > + /* Set text-mode resolution to maximum supported */ > + o = grub_efi_system_table->con_out; > + for (i=0, columns_max=0, rows_max=0, mode_max=0; i < o->mode->max_mode; > i++) > +if

Re: [PATCH] efi: Set text-mode console resolution to maximum supported

2022-05-06 Thread Glenn Washburn
Hi Gerd, Thanks for taking a look at the patch. On Fri, 6 May 2022 12:39:52 +0200 Gerd Hoffmann wrote: > Hi, > > > On some buggy EFI firmwares, GRUB is started with the console resolution > > set to the maximum but the output console EFI object has the mode set as > > 0, which is the minimum