Mathieu Desnoyers writes:
> +version_reverse_sort ()
> +{
> + case $version_reverse_sort_sort_has_v in
Does this need to be its own variable, or could it just reuse
version_sort_sort_has_v?
> +reverse_sorted_list=$(echo $list | tr ' ' '\n' | sed 's/$/ 2/' | sed
> 's/\.old 2/ 1/' | version_rev
- On May 4, 2022, at 10:43 AM, Robbie Harwood rharw...@redhat.com wrote:
> Mathieu Desnoyers writes:
>
>> +version_reverse_sort ()
>> +{
>> + case $version_reverse_sort_sort_has_v in
>
> Does this need to be its own variable, or could it just reuse
> version_sort_sort_has_v?
We could do t
Thanks for the update, I'd like to see this get into master. However,
while this was waiting for review some changes were made to master that
make this need some extra work. I've commented below on that and other
issues.
On Tue, 29 Mar 2022 12:31:56 +0200
Pierre-Louis Bonicoli wrote:
> The logic
On Tue, 29 Mar 2022 12:31:58 +0200
Pierre-Louis Bonicoli wrote:
> Unlike LUKS1, the sector size of LUKS2 devices isn't hardcoded.
>
> Regarding the probe command, the following values of --target switch
> are affected: abstraction, arc_hints, baremetal_hints, bios_hints,
> cryptodisk_uuid, drive
On Tue, 29 Mar 2022 12:31:57 +0200
Pierre-Louis Bonicoli wrote:
> The --target=drive option of the probe command doesn't handle LUKS2
> devices:
>
> # dd if=/dev/zero of=data count=10 bs=1M
> # losetup --show -f data
> /dev/loop4
> # echo -n pass | cryptsetup luksFormat -v --type luks2 /
On Tue, 29 Mar 2022 12:31:55 +0200
Pierre-Louis Bonicoli wrote:
> v2 updates:
> * grub-fs-tester: remove extraneous 'sleep' and 'tail'
> * add LUKS and LUKS2 fs tests
> * the patches have been rebased on top of the master branch
>
>
> On 09/02/2022 07.20, Glenn Washburn wrote:
> > Why do thi
Hi Maxim,
I just want to reiterate Daniel, for v3, please use --threaded when
using format-patch and send-email. It'll help reviewers see all the
emails in the patch series together.
On Sat, 02 Apr 2022 20:02:17 +
Maxim Fomin wrote:
> ---
> docs/grub.texi | 47
> grub-co
