Re: [PATCH v3 0/5] Fix coverity bugs and add checks for elf values in grub-core

2022-04-27 Thread Darren Kenny
Hi Alec, This all looks good to me, so for the series: Reviewed-by: Darren Kenny Thanks, Darren. On Wednesday, 2022-04-20 at 22:23:12 -04, Alec Brown wrote: > v3: Added check for e_shoff, made starting words lowercase in error messages, > and added comment to why return pointers are set to 0.

[PATCH 1/1] grub-mkimage: Creating aarch64 images from x86 host is broken

2022-04-27 Thread Darren Kenny
A recent fix that made appears to have broken the ability to create an aarch64 boot image on a x86-based host. This was due to an overzealous testing of the architecture when building grub-mkimage and removing the code that build an Arm image when not built on Arm. Fixes: 8541f319 ("grub-mkimage:

Re: [PATCH 1/1] grub-mkimage: Creating aarch64 images from x86 host is broken

2022-04-27 Thread Daniel Kiper
On Wed, Apr 27, 2022 at 10:46:48AM +, Darren Kenny wrote: > A recent fix that made appears to have broken the ability to create an > aarch64 boot image on a x86-based host. > > This was due to an overzealous testing of the architecture when building > grub-mkimage and removing the code that bui

Re: [PATCH] grub-install: Allow to install to non-EFI ESP when --force

2022-04-27 Thread Daniel Kiper
On Sun, Apr 24, 2022 at 03:36:33PM +0800, Icenowy Zheng wrote: > Although the EFI specification enforces support for FAT ESP, it's free > for EFI implementations to implement support for ESPs with other formats > (e.g. ext4, ntfs, etc), and at least U-Boot EFI will support ext4 ESP if > U-Boot is b

Re: [PATCH V2] Enable TDX measurement to RTMR register

2022-04-27 Thread Daniel Kiper
First of all, sorry for late reply but I am busy... On Mon, Mar 14, 2022 at 02:52:22PM +0800, Lu Ken wrote: > Intel Trust Domain Extensions(Intel TDX) refers to an Intel technology > that extends Virtual Machine Extensions(VMX) and Multi-Key Total Memory > Encryption(MK-TME) with a new kind of vir

Re: [PATCHv2] hurd: Support device entries with @/dev/disk: qualifier

2022-04-27 Thread Daniel Kiper
Sorry for late reply but I am busy... On Thu, Feb 24, 2022 at 12:34:13AM +0100, Samuel Thibault wrote: > Those are used with non-bootstrap disk drivers, for which libstore has to > open /dev/disk before calling device_open on it instead of on the device > master port. Normally in that case all /d

Re: [PATCH v2] util/grub.d/linux: Improve initramfs detection

2022-04-27 Thread Daniel Kiper
Sorry, somehow I missed your reply... On Thu, Apr 07, 2022 at 09:35:19PM -0500, Oskari Pirhonen wrote: > On Thu, Apr 07, 2022 at 05:44:18PM +0200, Daniel Kiper wrote: > > On Sun, Mar 27, 2022 at 10:41:31PM -0500, Oskari Pirhonen wrote: > > > Add detection for initramfs of the form *.img.old. For e

[PATCHv3] hurd: Support device entries with @/dev/disk: qualifier

2022-04-27 Thread Samuel Thibault
Those are used with non-bootstrap disk drivers, for which libstore has to open /dev/disk before calling device_open on it instead of on the device master port. Normally in that case all /dev/ entries also have the @/dev/disk: qualifier, so we can just drop it. Signed-off-by: Samuel Thibault Mes