Re: [PATCH v2] configure: Fix default -O2 being added when CFLAGS not set

2022-04-06 Thread Daniel Kiper
On Mon, Mar 28, 2022 at 12:56:22PM -0500, Glenn Washburn wrote: > Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS > was defaulted to "" early in configure to prevent this. A recent commit > ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new > autotools

Re: [PATCH] gnulib: Handle aborts in gnulib more gracefully

2022-04-06 Thread Daniel Kiper
Adding Robbie and Vladimir... On Thu, Mar 24, 2022 at 07:12:22PM -0500, Glenn Washburn wrote: > Gnulib does not define abort(), but expects it to be defined, usually by a > libc implementation. However, GRUB has no libc and does not have an abort() > function. Until recently GRUB had patched out a

Re: [PATCH] misc: Make grub_min() and grub_max() more resilient.

2022-04-06 Thread Daniel Kiper
On Thu, Mar 24, 2022 at 04:06:38PM -0400, Peter Jones wrote: > grub_min(a,b) and grub_max(a,b) use a relatively naive implementation > which leads to several problems: > - they evaluate their parameters more than once > - the naive way to address this, to declare temporary variables in a > statem

Re: [PATCH v2 2/3] Fix -Werror=array-bounds array subscript 0 is outside array bounds

2022-04-06 Thread Daniel Kiper
On Mon, Mar 28, 2022 at 03:00:53PM +0800, Michael Chang via Grub-devel wrote: > The grub is failing to build with gcc-12 in many places like this: > > In function 'init_cbfsdisk', > inlined from 'grub_mod_init' at ../../grub-core/fs/cbfs.c:391:3: > ../../grub-core/fs/cbfs.c:345:7: error: array

Re: [PATCH v8 1/7] cryptodisk: luks: unify grub_cryptodisk_dev function names

2022-04-06 Thread Daniel Kiper
On Sat, Jan 01, 2022 at 09:52:54PM -0600, Glenn Washburn wrote: > From: Denis 'GNUtoo' Carikli > > Signed-off-by: Denis 'GNUtoo' Carikli > Reviewed-by: Patrick Steinhardt > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-de

Re: [PATCH v8 2/7] cryptodisk: geli: unify grub_cryptodisk_dev function names

2022-04-06 Thread Daniel Kiper
On Sat, Jan 01, 2022 at 09:52:55PM -0600, Glenn Washburn wrote: > From: Denis 'GNUtoo' Carikli > > Signed-off-by: Denis 'GNUtoo' Carikli > Reviewed-by: Patrick Steinhardt > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-de

Re: [PATCH v8 0/7] Cryptodisk detached headers and key files

2022-04-06 Thread Daniel Kiper
On Sat, Jan 01, 2022 at 09:52:53PM -0600, Glenn Washburn wrote: > This patch series is an updated version of the v7 sent by Denis Carikli with > modifications to reflect changes in argument passing to crypto backends. The > previous patch #6 titled "Add support for LUKS1 key files" has been removed

Re: [PATCH v2 01/15] grub-shell: only pass SeaBIOS fw_opt in for x86 BIOS platforms

2022-04-06 Thread Daniel Kiper
On Mon, Mar 28, 2022 at 05:22:26PM +1100, Daniel Axtens wrote: > This breaks the tests on pseries - just restrict it to x86 platforms > that don't specify a BIOS. > > Signed-off-by: Daniel Axtens Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailin

Re: [PATCH v2 02/15] mm: assert that we preserve header vs region alignment

2022-04-06 Thread Daniel Kiper
On Mon, Mar 28, 2022 at 05:22:27PM +1100, Daniel Axtens wrote: > grub_mm_region_init() does: > > h = (grub_mm_header_t) (r + 1); > > where h is a grub_mm_header_t and r is a grub_mm_region_t. > > Cells are supposed to be GRUB_MM_ALIGN aligned, but while grub_mm_dump > ensures this vs the region h

Display MAC in theme

2022-04-06 Thread Robert LeBlanc
I'd like to display the current MAC address (net_default_mac) on our theme for PXE booting to help with troubleshooting. I can't seem to figure out from the docs how to either target the text box by id and set the text in the config file, or have a variable rendered as part of the theme. Can someon