Re: [PATCH 3/3] reed_solomon: Fix array subscript 0 is outside array bounds

2022-03-17 Thread Paul Menzel
Dear Michael, Thank you for working on that. Am 17.03.22 um 07:43 schrieb Michael Chang via Grub-devel: The grub_absolute_pointer() is a compound expression that can only work within a function. We are out of luck here when the pointer variables require global definition due to ATTRIBUTE_TEXT

Re: [PATCH 3/3] reed_solomon: Fix array subscript 0 is outside array bounds

2022-03-17 Thread Michael Chang via Grub-devel
On Thu, Mar 17, 2022 at 08:41:32AM +0100, Paul Menzel wrote: > Dear Michael, > > > Thank you for working on that. > > > Am 17.03.22 um 07:43 schrieb Michael Chang via Grub-devel: > > The grub_absolute_pointer() is a compound expression that can only work > > within a function. We are out of luc

Re: [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable

2022-03-17 Thread Daniel Kiper
On Tue, Mar 15, 2022 at 08:16:01PM -0500, Glenn Washburn wrote: > On Tue, 15 Mar 2022 16:24:07 -0400 > Alec Brown wrote: > > > In the function grub_net_ipv6_get_link_local(), > > grub_net_network_level_address_t > > addr is called but isn't being initialized. To prevent contents of this > > struc

Re: [PATCH 1/2] EFI: console: Do not set colorstate until the first text output

2022-03-17 Thread Daniel Kiper
On Fri, Mar 04, 2022 at 11:30:13AM +0100, Hans de Goede wrote: > Hi Daniel, > > On 1/28/22 12:43, Hans de Goede wrote: > > GRUB_MOD_INIT(normal) does an unconditional: > > > > grub_env_set ("color_normal", "light-gray/black"); > > > > which triggers a grub_term_setcolorstate() call. The original ve

Re: [PATCH 6/6] INSTALL: Add more cross-compiling Debian packages

2022-03-17 Thread Daniel Kiper
Paul, On Thu, Mar 17, 2022 at 07:02:22AM +0100, Paul Menzel wrote: > Dear Daniel, > > Am 11.03.22 um 00:36 schrieb Daniel Kiper: > > The mingw-w64-tools is especially important because with out it some > > without > > > Windows builds may fail due to lack of proper pkg-config. > > > > Signed-off-b

Re: [PATCH 0/3] Net fix and improvements

2022-03-17 Thread Daniel Kiper
Hey, On Tue, Mar 08, 2022 at 03:20:17PM -0600, Glenn Washburn wrote: > The first patch looks like it was a copy/paste error. If the net module is > unloaded, grub_net_poll_cards_idle should be NULL so that a function in the > net module which now doesn't exist. > > The second and third patches are

Re: Comparable syslinux kernel command in GRUB2?

2022-03-17 Thread Daniel Kiper
Hi Robert, First of all, sorry for late reply... On Sun, Mar 13, 2022 at 10:17:34AM -0600, Robert LeBlanc wrote: > I'm trying to convert a syslinux/isolinux config from the VMware ESXi > installer > ISO for PXE booting and I'm trying to figure out how the syslinux 'kernel' > command translates t

Re: [PATCH 1/2] Add vlan information to net_ls_addr output

2022-03-17 Thread Daniel Kiper
Hey, First of all, if you send multiple patches please add cover letter to the patch series. Her is a good example [1]. On Fri, Mar 04, 2022 at 10:46:35PM -0500, Chad Kimes via Grub-devel wrote: > Example output: > grub> net_ls_addr > efinet1 00:11:22:33:44:55 192.168.0.100 vlan100 If you gi

Re: [PATCH 2/2] Add net_set_vlan command

2022-03-17 Thread Daniel Kiper
On Fri, Mar 04, 2022 at 10:46:36PM -0500, Chad Kimes via Grub-devel wrote: > Previously there was no way to set the 802.1Q VLAN identifier, despite > support for vlantag in the net module. The only location vlantag was > being populated was from PXE boot and only for Open Firmware hardware. > This