Re: [PATCH] po: Un-transliterate the %zu format code

2022-03-10 Thread Daniel Kiper
On Wed, Mar 09, 2022 at 06:10:12PM -0600, Glenn Washburn wrote: > On Wed, 9 Mar 2022 17:10:01 +0100 > Daniel Kiper wrote: > > > On Mon, Mar 07, 2022 at 12:15:36PM -0600, Glenn Washburn wrote: > > > Commit 45bffae13 uses the %zu format specifier which has not been used in > > > > If you mention a c

Re: [PATCH] gdb: Add malloc and free symbols to kernel.exec to improve gdb functionality

2022-03-10 Thread Daniel Kiper
On Wed, Mar 09, 2022 at 02:25:28PM -0600, Glenn Washburn wrote: > On Wed, 9 Mar 2022 16:49:57 +0100 > Daniel Kiper wrote: > > > On Wed, Mar 02, 2022 at 06:25:12PM -0600, Glenn Washburn wrote: > > > Add linker flags when linking kernel.exec to have malloc and free point to > > > grub_malloc and gru

Re: [PATCH] Drop mention of libusb from INSTALL

2022-03-10 Thread Daniel Kiper
On Wed, Mar 09, 2022 at 03:31:51PM -0500, Robbie Harwood wrote: > 9d25b0da9a8cce9b3766f4e1b449d7936d5ba124 ("Remove emu libusb support.") > dropped use of libusb, but did not remove mention of it from INSTALL. > > Signed-off-by: Robbie Harwood Reviewed-by: Daniel Kiper Daniel _

Re: [PATCH v2] grub-mount: Support libfuse 3

2022-03-10 Thread Daniel Kiper
On Tue, Feb 08, 2022 at 05:22:45PM +0100, Daniel Kiper wrote: > On Mon, Jan 17, 2022 at 03:34:37PM +0100, Fabian Vogt wrote: > > libfuse 3.0.0 got released in 2016, with some API changes compared to 2.x. > > This commit introduces support for 3.x while keeping it compatible with 2.6 > > as a fallba

[PATCH 6/6] INSTALL: Add more cross-compiling Debian packages

2022-03-10 Thread Daniel Kiper
The mingw-w64-tools is especially important because with out it some Windows builds may fail due to lack of proper pkg-config. Signed-off-by: Daniel Kiper --- INSTALL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index a64f63723..aff44f75c 100644 --- a/I

[PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-10 Thread Daniel Kiper
Latest GCC may complain in that way: commands/i386/pc/sendkey.c: In function ‘grub_sendkey_postboot’: commands/i386/pc/sendkey.c:223:21: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=] 223 | *((char *) 0x41a) = 0x1e; | ~~^~ The v

[PATCH 0/6] Various fixes and cleanups

2022-03-10 Thread Daniel Kiper
Hey, Mostly build fixes plus one cleanup and INSTALL file update. Daniel INSTALL | 3 ++- conf/i386-cygwin-img-ld.sc | 4 configure.ac | 4 ++-- grub-core/commands/i386/pc/sendkey.c | 8 grub-core/loader/i386/bsd.c

[PATCH 4/6] conf/i386-cygwin-img-ld: Do not discard .data and .edata sections

2022-03-10 Thread Daniel Kiper
$ ./configure --target=i686-w64-mingw32 --with-platform=efi --host=i686-w64-mingw32 [...] checking if __bss_start is defined by the compiler... no checking if edata is defined by the compiler... no checking if _edata is defined by the compiler... no configure: error: none of __bss_start, edata o

[PATCH 5/6] configure: Drop ${grub_coredir} unneeded references

2022-03-10 Thread Daniel Kiper
These are probably stray references left after earlier removals. Signed-off-by: Daniel Kiper --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 50f7bc6a0..560d40515 100644 --- a/configure.ac +++ b/configure.ac @@ -1128,9 +11

[PATCH 2/6] loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta()

2022-03-10 Thread Daniel Kiper
Latest GCC may complain in that way: In file included from ../include/grub/disk.h:31, from ../include/grub/file.h:26, from ../include/grub/loader.h:23, from loader/i386/bsd.c:19: loader/i386/bsd.c: In function ‘grub_cmd_openbsd’: ../in

[PATCH 1/6] osdep/windows/platform: Disable gcc9 -Waddress-of-packed-member

2022-03-10 Thread Daniel Kiper
$ ./configure --target=x86_64-w64-mingw32 --with-platform=efi --host=x86_64-w64-mingw32 $ make [...] In file included from grub-core/osdep/platform.c:4: grub-core/osdep/windows/platform.c: In function ‘grub_install_register_efi’: grub-core/osdep/windows/platform.c:382:41: error: taking address o

Re: [PATCH v8 0/6] Update gnulib version and drop most gnulib patches

2022-03-10 Thread Daniel Kiper
On Wed, Mar 09, 2022 at 02:01:16PM -0600, Glenn Washburn wrote: > On Wed, 9 Mar 2022 16:42:43 +0100 > Daniel Kiper wrote: > > > On Mon, Mar 07, 2022 at 02:15:49AM -0600, Glenn Washburn wrote: > > > On Fri, 4 Mar 2022 18:01:10 -0600 > > > Glenn Washburn wrote: > > > > > > > On Wed, 2 Mar 2022 14:

Re: [PATCH 1/6] osdep/windows/platform: Disable gcc9 -Waddress-of-packed-member

2022-03-10 Thread Vladimir 'phcoder' Serbinenko
LGTM On Fri, Mar 11, 2022 at 12:38 AM Daniel Kiper wrote: > > $ ./configure --target=x86_64-w64-mingw32 --with-platform=efi > --host=x86_64-w64-mingw32 > $ make > > [...] > > In file included from grub-core/osdep/platform.c:4: > grub-core/osdep/windows/platform.c: In function ‘grub_install_regis

[PATCH v2] po: Un-transliterate the %zu format code

2022-03-10 Thread Glenn Washburn
Commit 45bffae13 (util/resolve: Bail with error if moddep.lst file line is too long) uses the %zu format specifier which has not been used in any translated strings yet. So the sed scripts used for tranliterating certain languages need to be updated otherwise creation of the message indexes will fa