RE: [PATCH] Enable TDX measurement to RTMR register via EFI_CC_MEASUREMENT_PROTOCOL

2022-03-08 Thread Lu, Ken
Thanks Kiper's review and comment, sorry for later response since vacation. Please see my answer in below, and will submit new patch soon. > -Original Message- > From: Daniel Kiper > Sent: Friday, February 25, 2022 2:47 AM > To: Lu, Ken > Cc: grub-devel@gnu.org; Xu, Min M > Subject: Re

[PATCH 1/3] net: Unset grub_net_poll_cards_idle when net module has been unloaded

2022-03-08 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- grub-core/net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/net/net.c b/grub-core/net/net.c index 4d3eb5c1a5..563dea9ec8 100644 --- a/grub-core/net/net.c +++ b/grub-core/net/net.c @@ -1948,5 +1948,5 @@ GRUB_MOD_FINI(net) g

[PATCH 0/3] Net fix and improvements

2022-03-08 Thread Glenn Washburn
The first patch looks like it was a copy/paste error. If the net module is unloaded, grub_net_poll_cards_idle should be NULL so that a function in the net module which now doesn't exist. The second and third patches are for performance and were helpful when debugging GRUB. When the net module is l

[PATCH 2/3] net: Avoid unnecessary calls to grub_net_tcp_retransmit

2022-03-08 Thread Glenn Washburn
In grub_net_poll_cards_idle_real, only call grub_net_tcp_retransmit if there are network cards found. If there are no network card found, there can be no tcp sockets to transmit on. Signed-off-by: Glenn Washburn --- grub-core/net/net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[PATCH 3/3] net/tcp: Only call grub_get_time_ms when there are sockets to potentially retransmit for

2022-03-08 Thread Glenn Washburn
If there are no TCP sockets, this call to grub_get_time_ms is unneeded. This prevents a call into the firmware on some platforms. Signed-off-by: Glenn Washburn --- grub-core/net/tcp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/grub-core/net/tcp.c b/grub-core/net