On Thu, Feb 24, 2022 at 01:37:19PM -0500, Robbie Harwood wrote:
> Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> patched out all relevant invocations of abort() in gnulib. While it was
> not documented why at the time, testing suggests that there's no abort()
> implementation
On Thu, Feb 24, 2022 at 01:37:20PM -0500, Robbie Harwood wrote:
> In addition to the changes carried in our gnulib patches, several
> Coverity and code hygiene fixes that were previously downstream are also
> included in this 3-year gnulib increment.
>
> Unfortunately, fix-width.patch is retained.
Signed-off-by: Robbie Harwood
---
config.h.in | 56 ++---
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/config.h.in b/config.h.in
index 9e8f9911b..1c8c05b9c 100644
--- a/config.h.in
+++ b/config.h.in
@@ -22,46 +22,46 @@
#define MI
- Fix type of size variable in luks2_verify_key()
- Avoid redefinition of SIZE_MAX and ATTRIBUTE_ERROR
- Work around gnulib's int types on older compilers
Signed-off-by: Robbie Harwood
---
config.h.in | 5 +
grub-core/disk/luks2.c| 4 ++--
grub-core/lib/posi
gnulib defines go in config-util.h, and we need to know whether to
provide duplicates in config.h or not.
Signed-off-by: Robbie Harwood
---
grub-core/disk/host.c| 2 +-
grub-core/gensymlist.sh | 1 +
grub-core/kern/emu/argp_common.c | 2 +-
grub-core/kern/emu/mai
In addition to the changes carried in our gnulib patches, several
Coverity and code hygiene fixes that were previously downstream are also
included in this 3-year gnulib increment.
Unfortunately, fix-width.patch is retained.
Bump minimum autoconf version from 2.63 to 2.64 and automake from 1.11
t
Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
patched out all relevant invocations of abort() in gnulib. While it was
not documented why at the time, testing suggests that there's no abort()
implementation available for gnulib to use.
gnulib's position is that the use of abor
This version attempts to address dkiper's review of v6. As such, the only
code change is to replace __builtin_unreachable with __builtin_trap (and
surrounding comments). The patchset also, as requseted, grows another commit
to handle warnings that would be introduced by updating gnulib. Conceptu
Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
fix-base64.patch handled two problems we have using gnulib, which are
exerciesd by the base64 module but not directly caused by it.
First, grub2 defines its own bool
On Wed, 2 Mar 2022 18:00:11 +0100
Daniel Kiper wrote:
> On Thu, Feb 24, 2022 at 01:37:19PM -0500, Robbie Harwood wrote:
> > Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> > patched out all relevant invocations of abort() in gnulib. While it was
> > not documented why at the
On Tue, Mar 01, 2022 at 11:18:52AM -0500, Chad Kimes via Grub-devel wrote:
> Vlan configuration seems to have never worked on little-endian systems. This
> is
> likely because VLANTAG_IDENTIFIER is not byte-swapped before copying into the
> net buffer, nor is vlantag. We can resolve this by using
On Wed, Mar 02, 2022 at 12:07:33PM -0600, Glenn Washburn wrote:
> On Wed, 2 Mar 2022 18:00:11 +0100
> Daniel Kiper wrote:
>
> > On Thu, Feb 24, 2022 at 01:37:19PM -0500, Robbie Harwood wrote:
> > > Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> > > patched out all relevant in
Signed-off-by: Robbie Harwood
---
config.h.in | 56 ++---
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/config.h.in b/config.h.in
index 9e8f9911b..1c8c05b9c 100644
--- a/config.h.in
+++ b/config.h.in
@@ -22,46 +22,46 @@
#define MI
- Fix type of size variable in luks2_verify_key()
- Avoid redefinition of SIZE_MAX and ATTRIBUTE_ERROR
- Work around gnulib's int types on older compilers
Signed-off-by: Robbie Harwood
---
config.h.in | 5 +
grub-core/disk/luks2.c| 4 ++--
grub-core/lib/posi
Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
fix-base64.patch handled two problems we have using gnulib, which are
exerciesd by the base64 module but not directly caused by it.
First, grub2 defines its own bool
gnulib defines go in config-util.h, and we need to know whether to
provide duplicates in config.h or not.
Signed-off-by: Robbie Harwood
---
grub-core/disk/host.c| 2 +-
grub-core/gensymlist.sh | 1 +
grub-core/kern/emu/argp_common.c | 2 +-
grub-core/kern/emu/mai
Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
patched out all relevant invocations of abort() in gnulib. While it was
not documented why at the time, testing suggests that there's no abort()
implementation available for gnulib to use.
gnulib's position is that the use of abor
Changes this version:
- Reorder last two commits so that warning fixes come after the change that
introduces them.
- Fix comment formatting to comply with grub2 style.
No functional code changes.
Be well,
--Robbie
Robbie Harwood (6):
Use visual indentation in config.h.in
Where present, en
In addition to the changes carried in our gnulib patches, several
Coverity and code hygiene fixes that were previously downstream are also
included in this 3-year gnulib increment.
Unfortunately, fix-width.patch is retained.
Bump minimum autoconf version from 2.63 to 2.64 and automake from 1.11
t
Vlan configuration seems to have never worked on little-endian systems. This is
likely because VLANTAG_IDENTIFIER is not byte-swapped before copying into the
net buffer, nor is vlantag. We can resolve this by using grub_cpu_to_be16 and
its inverse when copying vlan info to/from the net buffer.
Sig
On Fri, Feb 25, 2022 at 03:04:57PM -0600, Glenn Washburn wrote:
> On Tue, 22 Feb 2022 19:03:39 +0100
> Daniel Kiper wrote:
>
> > On Tue, Feb 15, 2022 at 12:36:42PM -0600, Glenn Washburn wrote:
> > > These functions may be useful within modules as well. Export them so that
> > > modules can use the
On Wed, Mar 02, 2022 at 02:21:22PM -0500, Chad Kimes via Grub-devel wrote:
> Vlan configuration seems to have never worked on little-endian systems. This
> is
> likely because VLANTAG_IDENTIFIER is not byte-swapped before copying into the
> net buffer, nor is vlantag. We can resolve this by using
On Wed, 2 Mar 2022 14:08:27 -0500
Robbie Harwood wrote:
> Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this
> patched out all relevant invocations of abort() in gnulib. While it was
> not documented why at the time, testing suggests that there's no abort()
> implementation avai
Add linker flags when linking kernel.exec to have malloc and free point to
grub_malloc and grub_free respectively. Some gdb functionality depends on
gdb locating the symbols "malloc" and "free", such as dynamically creating
strings for arguments to injected function calls. A trivial example would
t
For anyone stumbling on this I made some progress. Apparently the version
of GRUB that ships with Ubuntu 18.04 is way too old for this feature (2.02)
and the feature was not included until 2.06 which Ubuntu 22.04 will have.
So I built GRUB from source, but the bootstrap was failing, so I used the
H
os-prober now effectively handles multiple paths passed to initrd, but
grub-mkconfig still truncates off any subsequent space-delimited paths.
Support proper parsing of space-delimited initrd paths passed from
os-prober for distributions, like Manjaro, that require it.
Fixes: https://savannah.gnu
26 matches
Mail list logo
