Re: [PATCH] configure: Replace -Wl,-r,-d with -Wl,-r

2022-02-11 Thread Daniel Kiper
On Tue, Feb 08, 2022 at 03:25:27PM -0800, Fangrui Song via Grub-devel wrote: > In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON symbols. > This behavior is presumably to work around legacy projects which inspect > relocatable output by themselves and do not handle COMMON symbols

Re: [PATCH v1] efi: make sure EFI disk controllers are connected when discovering devices

2022-02-11 Thread Renaud Métrich
Le 2/10/22 à 15:53, Ard Biesheuvel a écrit : Hello all, Please don't top post. I am not going to rearrange the text below and just reply to each chunk if it seems relevant. On Thu, 10 Feb 2022 at 14:02, Alexander Graf wrote: On 09.02.22 18:20, Renaud Métrich wrote: Hi, I observed no slowd

Re: [PATCH] configure: Replace -Wl,-r,-d with -Wl,-r

2022-02-11 Thread Fāng-ruì Sòng via Grub-devel
On Fri, Feb 11, 2022 at 6:04 AM Daniel Kiper wrote: > > On Tue, Feb 08, 2022 at 03:25:27PM -0800, Fangrui Song via Grub-devel wrote: > > In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON > > symbols. > > This behavior is presumably to work around legacy projects which inspect >

Re: [PATCH] configure: Replace -Wl,-r,-d with -Wl,-r

2022-02-11 Thread Daniel Kiper
On Fri, Feb 11, 2022 at 09:35:04AM -0800, Fāng-ruì Sòng via Grub-devel wrote: > On Fri, Feb 11, 2022 at 6:04 AM Daniel Kiper wrote: > > > > On Tue, Feb 08, 2022 at 03:25:27PM -0800, Fangrui Song via Grub-devel wrote: > > > In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON > > >

[PATCH] configure: Replace -Wl,-r,-d with -Wl,-r and add -fno-common

2022-02-11 Thread Fangrui Song via Grub-devel
In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON symbols. This behavior is presumably to work around legacy projects which inspect relocatable output by themselves and do not handle COMMON symbols. grub does not do this. See https://github.com/llvm/llvm-project/issues/53660 -d

Re: [PATCH] configure: Replace -Wl, -r, -d with -Wl, -r and add -fno-common

2022-02-11 Thread Fāng-ruì Sòng via Grub-devel
Yes, please do. Sorry for missing the tag. On Fri, Feb 11, 2022 at 10:37 AM Daniel Kiper wrote: > > On Fri, Feb 11, 2022 at 10:13:23AM -0800, Fangrui Song via Grub-devel wrote: > > In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON > > symbols. > > This behavior is presumably

Re: [PATCH] configure: Replace -Wl,-r,-d with -Wl,-r and add -fno-common

2022-02-11 Thread Daniel Kiper
On Fri, Feb 11, 2022 at 10:13:23AM -0800, Fangrui Song via Grub-devel wrote: > In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON symbols. > This behavior is presumably to work around legacy projects which inspect > relocatable output by themselves and do not handle COMMON symbols