[PATCH v4] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Vitaly Kuzmichev via Grub-devel
Improve 'search' grub-shell command with functionality to search for a partition by PARTUUID string. This is useful for embedded systems where FSUUID is not guaranteed to be constant, e.g. it is not preserved between system updates, and modifying grub.cfg is undesired. V2: This patch is based on M

Re: [PATCH v1] efi: make sure EFI disk controllers are connected when discovering devices

2022-02-09 Thread Alexander Graf
On 08.02.22 11:56, Renaud Métrich wrote: When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular partition

Re: [PATCH v4] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Glenn Washburn
On Wed, 9 Feb 2022 13:08:51 +0300 Vitaly Kuzmichev via Grub-devel wrote: > Improve 'search' grub-shell command with functionality to search for > a partition by PARTUUID string. This is useful for embedded systems > where FSUUID is not guaranteed to be constant, e.g. it is not preserved > betwee

Re: [PATCH v4] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Vitaly Kuzmichev via Grub-devel
Hello Glenn, On 2/9/22 6:48 PM, Glenn Washburn wrote: On Wed, 9 Feb 2022 13:08:51 +0300 Vitaly Kuzmichev via Grub-devel wrote: Improve 'search' grub-shell command with functionality to search for a partition by PARTUUID string. This is useful for embedded systems where FSUUID is not guarante

Re: [PATCH v1] efi: make sure EFI disk controllers are connected when discovering devices

2022-02-09 Thread Renaud Métrich
Hi, I observed no slowdown at all with the new code. I was thinking of the same, i.e. trying to find the device and perform a discovery if not found but there is some sort of caching mechanism inside Grub regarding devices which prevents Grub from working at all if the device list already hav

Re: [PATCH v4] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Glenn Washburn
On Wed, 9 Feb 2022 19:41:28 +0300 Vitaly Kuzmichev wrote: > Hello Glenn, > > On 2/9/22 6:48 PM, Glenn Washburn wrote: > > On Wed, 9 Feb 2022 13:08:51 +0300 > > Vitaly Kuzmichev via Grub-devel wrote: > > > >> Improve 'search' grub-shell command with functionality to search for > >> a partition

Re: [PATCH v2] tests: Add check-native and check-nonnative make targets

2022-02-09 Thread Daniel Kiper
On Tue, Feb 08, 2022 at 03:55:57PM -0600, Glenn Washburn wrote: > This allows for testing only tests that run directly on the build machine or > only tests that run in a virtualized environment. When testing multiple > targets on the same build machine the native tests only need to be run once > fo

Re: [PATCH] Revert "iee1275/datetime: Fix off-by-1 error."

2022-02-09 Thread Daniel Kiper
On Tue, Feb 08, 2022 at 03:51:41PM +1100, Daniel Axtens wrote: > Hi, > > I tested a pseries guest under: > - qemu + KVM on a Power8 host with a fairly modern qemu > - qemu + TCG > > Here the 'date' command simply reports "error: no cmos found", so > this patch will have no impact on those platfor

Re: [PATCH v3] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Nicholas Vinson
On 2/1/22 21:54, Glenn Washburn wrote: Hi Vitaly, Now that GRUB is out of a feature freeze, there's a chance this can make it in. On Thu, 15 Apr 2021 16:59:07 +0300 Vitaly Kuzmichev via Grub-devel wrote: Improve 'search' grub-shell command with functionality to search for a partition by PA

Re: How to boot Windows when Bitlocker enabled with key sealed in TPM

2022-02-09 Thread Chris Murphy
Found this: [PATCH v1 2/2] core: commands: efi: add commands to get/set EFI vars https://lists.gnu.org/archive/html/grub-devel/2020-05/msg00027.html But I haven't seen any discussion on whether to support get/set EFI vars. Would it be possible to constrain the support to setting just "BootNext" f

Re: [PATCH v3] commands/search: Add support to search by PARTUUID

2022-02-09 Thread Glenn Washburn
On Wed, 9 Feb 2022 17:19:30 -0500 Nicholas Vinson wrote: > > > On 2/1/22 21:54, Glenn Washburn wrote: > > Hi Vitaly, > > > > Now that GRUB is out of a feature freeze, there's a chance this can > > make it in. > > > > On Thu, 15 Apr 2021 16:59:07 +0300 > > Vitaly Kuzmichev via Grub-devel wrot

[PATCH v3 0/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-02-09 Thread Glenn Washburn
This patch series has been updated to reflect changes suggested by Mihai. grub_uuidcasecmp() has been completely rewritten to basically a copy of grub_strncasecmp() which ignores dashes. The rest is the same minus changes needed due to rebasing onto master. Glenn Glenn Washburn (2): luks, luks2

[PATCH v3 1/2] luks, luks2: Force header.uuid to be NULL terminated

2022-02-09 Thread Glenn Washburn
According to the LUKS specification the uuid header field is of data type "char[]", which is defined as "a string stored as null terminated sequence of 8-bit characters". So enforce this by adding a null byte as the last byte of the uuid. The LUKS2 specification defers to the LUKS1 specification in

[PATCH v3 2/2] cryptodisk: Allows UUIDs to be compared in a dash-insensitive manner

2022-02-09 Thread Glenn Washburn
A user can now specify UUID strings with dashes, instead of having to remove dashes. This is backwards-compatability preserving and also fixes a source of user confusion over the inconsistency with how UUIDs are specified between file system UUIDs and cryptomount UUIDs. Since cryptsetup, the refere