[PATCH v3 1/2] search: fixed bug stopping iteration when --no-floppy is used

2022-02-08 Thread Renaud Métrich
When using --no-floppy and a floppy was encountered, iterate_device() was returning 1, causing the iteration to stop instead of continuing. Signed-off-by: Renaud Métrich --- grub-core/commands/search.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/commands/search.

[PATCH v3 2/2] search: new --efidisk-only option on EFI systems

2022-02-08 Thread Renaud Métrich
When using 'search' on EFI systems, we sometimes want to exclude devices that are not EFI disks (e.g. md, lvm). This is typically used when wanting to chainload when having a software raid (md) for EFI partition: with no option, 'search --file /EFI/redhat/shimx64.efi' sets root envvar to 'md/boot_e

Re: [PATCH] search: new --efidisk-only option on EFI systems

2022-02-08 Thread Renaud Métrich
So Glenn, I'm new to Grub developer, in the past I was relying on Javier Martinez Canillas ... Just sent v3. Le 2/7/22 à 22:32, Glenn Washburn a écrit : On Mon, 7 Feb 2022 12:12:14 +0100 Renaud Métrich wrote: Please find inline the new patch integrating Glenn's comments (new "flags" option

Re: [PATCH] efi: make sure EFI disk controllers are connected when, discovering devices

2022-02-08 Thread Renaud Métrich
Please ignore, resent properly using a git send-email command. Le 2/1/22 à 11:38, Renaud Métrich a écrit : When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the device

[PATCH v1] efi: make sure EFI disk controllers are connected when discovering devices

2022-02-08 Thread Renaud Métrich
When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular partitions for a given disk. This typically happens w

Re: [PATCH 4/4] util/grub-module-verifierXX.c: Add module_size parameter to functions for sanity checking

2022-02-08 Thread Daniel Kiper
On Wed, Feb 02, 2022 at 07:27:00PM -0500, Alec Brown wrote: > In grub-module-verifierXX.c, the function grub_module_verifyXX() performs an > initial check that the ELF section headers are within the module's size but > doesn't check if the sections being accessed have contents that are within the >

Re: [PATCH 2/2] util/resolve.c: Bail with error if moddep lst file line is too long

2022-02-08 Thread Daniel Kiper
On Wed, Jan 12, 2022 at 08:55:01PM -0600, Glenn Washburn wrote: > The code reads each line into a buffer of size 1024 and does not check if > the line is longer. So a line longer than 1024 will be read as a valid line > followed by an invalid line. Then an error confusing to the user is sent > with

Re: [PATCH 2/2] tests: Add check-native and check-nonnative make targets

2022-02-08 Thread Daniel Kiper
On Wed, Jan 12, 2022 at 08:19:04PM -0600, Glenn Washburn wrote: > This allows for testing only tests that run directly on the build machine or > only tests that run in a virtualized environment. When testing multiple > targets on the same build machine the native tests only need to be run once > fo

Re: [PATCH v3 0/5] Various test fixes and improvements

2022-02-08 Thread Daniel Kiper
On Sun, Feb 06, 2022 at 04:00:07PM -0600, Glenn Washburn wrote: > v3 - Fix botched v2 udate > v2 - Updated with Daniel's suggestions. > > Glenn > > Glenn Washburn (5): > tests: Do not remove image file on error in pata_test > tests: Skip pata_test on i386-efi > tests: Remove $((BASE#NUM)) bas

Re: [PATCH v2] grub-mount: Support libfuse 3

2022-02-08 Thread Daniel Kiper
On Mon, Jan 17, 2022 at 03:34:37PM +0100, Fabian Vogt wrote: > libfuse 3.0.0 got released in 2016, with some API changes compared to 2.x. > This commit introduces support for 3.x while keeping it compatible with 2.6 > as a fallback still. > > To detect fuse3, switch configure over to use pkg-config

Re: [PATCH] Revert "iee1275/datetime: Fix off-by-1 error."

2022-02-08 Thread Glenn Washburn
On Tue, 08 Feb 2022 15:51:41 +1100 Daniel Axtens wrote: > Hi, > > I tested a pseries guest under: > - qemu + KVM on a Power8 host with a fairly modern qemu > - qemu + TCG > > Here the 'date' command simply reports "error: no cmos found", so > this patch will have no impact on those platforms.

Re: [PATCH 2/2] tests: Add check-native and check-nonnative make targets

2022-02-08 Thread Glenn Washburn
On Tue, 8 Feb 2022 17:10:32 +0100 Daniel Kiper wrote: > On Wed, Jan 12, 2022 at 08:19:04PM -0600, Glenn Washburn wrote: > > This allows for testing only tests that run directly on the build machine or > > only tests that run in a virtualized environment. When testing multiple > > targets on the s

[PATCH v2] tests: Add check-native and check-nonnative make targets

2022-02-08 Thread Glenn Washburn
This allows for testing only tests that run directly on the build machine or only tests that run in a virtualized environment. When testing multiple targets on the same build machine the native tests only need to be run once for all targets. Whereas, the nonnative tests must be run for each target

[PATCH] configure: Replace -Wl,-r,-d with -Wl,-r

2022-02-08 Thread Fangrui Song via Grub-devel
In GNU ld and ld.lld, -d is used with -r to allocate space to COMMON symbols. This behavior is presumably to work around legacy projects which inspect relocatable output by themselves and do not handle COMMON symbols. grub does not do this. See https://github.com/llvm/llvm-project/issues/53660 -d

Re: [PATCH 1/3] grub-fs-tester: add luks1 and luks2 support

2022-02-08 Thread Glenn Washburn
On Thu, 3 Feb 2022 18:21:03 +0100 Pierre-Louis Bonicoli wrote: > The logical sector size used by LUKS1 is 512 bytes. LUKS2 uses 512 to > 4069 bytes. I like that this has been added here. However there's no test that actually runs this new code. Please add another two fs tests one for LUKS and o