[PATCH 0/5] Various test fixes and improvements

Updated with Daniel's suggestions. Glenn Glenn Washburn (5): tests: Do not remove image file on error in pata_test tests: Skip pata_test on i386-efi tests: Remove $((BASE#NUM)) bashism in grub-fs-tester tests: Ensure that mountpoints are unmounted before exiting tests: Ensure that loopb

[PATCH 4/5] tests: Ensure that mountpoints are unmounted before exiting

When all tests complete successfully, filesystems mounted by grub-fs-tester will be unmounted before exiting. However, on certain test failures the tester will exit with a failure code and not unmount previously mounted filesystems. Now keep track of mounts and umounts and run an exit handler on ex

[PATCH 3/5] tests: Remove $((BASE#NUM)) bashism in grub-fs-tester

This bashism allows converting NUM in base BASE to decimal. Its not needed because the only place its used is to convert from hexidecimal and this can also be done with the more portable $((0xHEXNUM)) syntax. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- tests/util/grub-fs-tester.

[PATCH 1/5] tests: Do not remove image file on error in pata_test

The image file can be useful in debugging an issue when the test fails. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- tests/pata_test.in | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/pata_test.in b/tests/pata_test.in index 4fee0b0fb..27dccec19 100644 --- a/tests/pata_te

[PATCH 5/5] tests: Ensure that loopback devices and zfs devices are cleaned up

ZFS file systems are not unmounted using umount, but instead by exporting them. So export the ZFS file system that has the same label as the one that was created during the test, if such one exists. This is required to delete the loopback device that uses the ZFS image file. Otherwise the added cod

[PATCH 2/5] tests: Skip pata_test on i386-efi

In comparison to other i386 targets, on i386-efi the Q35 QEMU machine type is used to do the testing to be able to make use of the EFI firmware in QEMU. On the Q35 machine type there is no way to use ATA to communicate with an IDE, only AHCI. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kipe

Re: [PATCH v4 0/4] Update gnulib and drop some patches

On Wed, 2 Feb 2022 14:33:29 -0500 Robbie Harwood wrote: > Changes in this version: > > - Address fix several warnings Glenn pointed out. Note that gnulib isn't > clean with our default cflags - they prefer different ones. (I had > previously missed these because of how much stuff I turn o

Re: [PATCH] zfs: fix LINUX_ROOT_DEVICE when grub-probe fails

> On Thu, Dec 17, 2020 at 08:27:14PM -0600, Doug Goldstein wrote: >> When grub-probe fails, the current code is to just stuff an empty result >> in which causes the user to not knowingly have a system that no longer >> boots. grub-probe can fail because the ZFS pool that contains the root >> files

[PATCH v3 5/5] tests: Ensure that loopback devices and zfs devices are cleaned up

ZFS file systems are not unmounted using umount, but instead by exporting them. So export the ZFS file system that has the same label as the one that was created during the test, if such one exists. This is required to delete the loopback device that uses the ZFS image file. Otherwise the added cod

[PATCH v3 1/5] tests: Do not remove image file on error in pata_test

The image file can be useful in debugging an issue when the test fails. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- tests/pata_test.in | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/pata_test.in b/tests/pata_test.in index 4fee0b0fb..27dccec19 100644 --- a/tests/pata_te

[PATCH v3 3/5] tests: Remove $((BASE#NUM)) bashism in grub-fs-tester

This bashism allows converting NUM in base BASE to decimal. Its not needed because the only place its used is to convert from hexidecimal and this can also be done with the more portable $((0xHEXNUM)) syntax. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper --- tests/util/grub-fs-tester.

[PATCH v3 4/5] tests: Ensure that mountpoints are unmounted before exiting

When all tests complete successfully, filesystems mounted by grub-fs-tester will be unmounted before exiting. However, on certain test failures the tester will exit with a failure code and not unmount previously mounted filesystems. Now keep track of mounts and umounts and run an exit handler on ex

Re: [PATCH 0/5] Various test fixes and improvements

Please ignore this patch series. Glenn On Sun, 6 Feb 2022 02:02:39 -0600 Glenn Washburn wrote: > Updated with Daniel's suggestions. > > Glenn > > Glenn Washburn (5): > tests: Do not remove image file on error in pata_test > tests: Skip pata_test on i386-efi > tests: Remove $((BASE#NUM)

[PATCH v3 0/5] Various test fixes and improvements

v3 - Fix botched v2 udate v2 - Updated with Daniel's suggestions. Glenn Glenn Washburn (5): tests: Do not remove image file on error in pata_test tests: Skip pata_test on i386-efi tests: Remove $((BASE#NUM)) bashism in grub-fs-tester tests: Ensure that mountpoints are unmounted before exi

[PATCH v3 2/5] tests: Skip pata_test on i386-efi

In comparison to other i386 targets, on i386-efi the Q35 QEMU machine type is used to do the testing to be able to make use of the EFI firmware in QEMU. On the Q35 machine type there is no way to use ATA to communicate with an IDE, only AHCI. Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kipe