Re: [PATCH 0/4] Clean up code and fix coverity bugs in util/grub-module-verifierXX.c

Hi Alec, These look good to me, thanks for handling the Coverity issues here. For the series: Reviewed-by: Darren Kenny Thanks, Darren. On Wednesday, 2022-02-02 at 19:26:56 -05, Alec Brown wrote: > Coverity identified several untrusted loop bounds in > util/grub-module-verifierXX.c. This pat

Re: [PATCH] affs: Fix resource leaks

Hi Alec, Don't know how I ended up missing this originally, but thanks for fixing it, so: Reviewed-by: Darren Kenny Thanks, Darren. On Wednesday, 2022-02-02 at 19:08:21 -05, Alec Brown wrote: > In commit 178ac5107389 (affs: Fix memory leaks), fixes were made to > grub_affs_iterate_dir() to pr

[PATCH 2/3] commands/probe: improve support of LUKS2 devices

The --target=drive option of the probe command doesn't handle LUKS2 devices: # dd if=/dev/zero of=data count=10 bs=1M # losetup --show -f data /dev/loop4 # echo -n pass | cryptsetup luksFormat -v --type luks2 /dev/loop4 Key slot 0 created. Command successful. # echo -n pass | cryptse

[PATCH 0/3] grub-probe: improve support of LUKS2

This patch series improves support of LUKS2 for grub-probe command. Related: - https://lists.gnu.org/archive/html/grub-devel/2020-05/msg00238.html - https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00017.html Marc Dequènes (Duck) encountered this issue with Debian Bullseye while trying to

[PATCH 3/3] grub-core/kern/disk.c: handle LUKS2 devices

Unlike LUKS1, the sector size of LUKS2 devices isn't hardcoded. Regarding the probe command, the following values of --target switch are affected: abstraction, arc_hints, baremetal_hints, bios_hints, cryptodisk_uuid, drive, efi_hints, hints_string, ieee1275_hints, zero_check. For example using th

[PATCH 1/3] grub-fs-tester: add luks1 and luks2 support

The logical sector size used by LUKS1 is 512 bytes. LUKS2 uses 512 to 4069 bytes. Signed-off-by: Pierre-Louis Bonicoli --- tests/util/grub-fs-tester.in | 58 ++-- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/u

Re: [PATCH 0/2] Add check-native and check-nonnative as make targets

On Wed, Jan 12, 2022 at 08:19:02PM -0600, Glenn Washburn wrote: > Tests can be put into two categories, native (tests that run on the build > system) and non-native (tests run in QEMU). For any two targets (even of > completely different architectures), the native tests will be running the > same b

Re: [PATCH 4/5] tests: Ensure that mountpoints are unmounted before exiting

On Wed, Jan 12, 2022 at 09:59:42PM -0600, Glenn Washburn wrote: > When all tests complete successfully, filesystems mounted by grub-fs-tester > will be unmounted before exiting. However, on certain test failures the > tester will exit with a failure code and not unmount previously mounted > filesys

Re: [PATCH 0/5] Various test fixes and improvements

On Wed, Jan 12, 2022 at 09:59:38PM -0600, Glenn Washburn wrote: > I believe the patches are fairly self explantatory. > > Glenn > > Glenn Washburn (5): > tests: Do not remove image file on error in pata_test > tests: Skip pata_test on i386-efi > tests: Remove $((BASE#NUM)) bashism in grub-fs-

Re: [PATCH 1/1] efi: correct struct grub_efi_boot_services

On Sat, Jan 22, 2022 at 11:27:54AM +0100, Heinrich Schuchardt wrote: > The UEFI specification defines that the EFI_BOOT_SERVICES.Exit(() service > may return EFI_SUCCESS or EFI_INVALID_PARAMETER. So it cannot be > __attribute__((noreturn)). > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Dani