Re: [PATCH] search: new --efidisk-only option on EFI systems

2022-02-02 Thread Robbie Harwood
Renaud Métrich writes: > When using 'search' on EFI systems, we sometimes want to exclude devices > that are not EFI disks (e.g. md, lvm). > This is typically used when wanting to chainload when having a software > raid (md) for EFI partition: > with no option, 'search --file /EFI/redhat/shimx64.

Re: [PATCH 0/2] Support plain encryption mode.

2022-02-02 Thread Maxim Fomin
--- Original Message --- > > > > Plainmount can work with '(hdX,gptY)' syntax in config or shell (actually, > > this > > > > is the base syntax) and thus it is not limited to GPT paritions, what is > > limited > > > > is the ability to use UUID - currently only on GPT. If partition scheme

Re: [PATCH 1/2] plainmount: Support decryption of devices encrypted in plain mode.

2022-02-02 Thread Maxim Fomin
--- Original Message --- On Tuesday, February 1st, 2022 at 5:30, Glenn Washburn wrote: > On Sun, 30 Jan 2022 19:40:43 + > > Maxim Fomin ma...@fomin.one wrote: > > > This patch introduces support for plain encryption mode (plain dm-crypt) via > > > > new module and command named 'pla

Re: [PATCH v3 0/4] Update gnulib and drop some patches

2022-02-02 Thread Robbie Harwood
Glenn Washburn writes: > On Thu, 27 Jan 2022 14:39:56 -0500 > Robbie Harwood wrote: > >> Changes in this version: >> - Make the version of bootstrap match what it's supposed to >> - Restore fix-width.patch at dkiper's request >> >> Be well, >> --Robbie > > I presume this has been build tested,

[PATCH v4 4/4] Update gnulib version and drop most gnulib patches

2022-02-02 Thread Robbie Harwood
In addition to the changes carried in our gnulib patches, several Coverity and code hygiene fixes that were previously downstream are also included in this 3-year gnulib increment. Unfortunately, fix-width.patch is retained. Bump minimum autoconf version from 2.63 to 2.64 as required by gnulib.

[PATCH v4 1/4] Use visual indentation in config.h.in

2022-02-02 Thread Robbie Harwood
Signed-off-by: Robbie Harwood --- config.h.in | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/config.h.in b/config.h.in index 9e8f9911b..1c8c05b9c 100644 --- a/config.h.in +++ b/config.h.in @@ -22,46 +22,46 @@ #define MI

[PATCH v4 0/4] Update gnulib and drop some patches

2022-02-02 Thread Robbie Harwood
Changes in this version: - Address fix several warnings Glenn pointed out. Note that gnulib isn't clean with our default cflags - they prefer different ones. (I had previously missed these because of how much stuff I turn off to build with our old gnulib copy.) - Update gnulib target vers

[PATCH v4 3/4] Drop gnulib no-abort.patch

2022-02-02 Thread Robbie Harwood
Originally added in db7337a3d353a817ffe9eb4a3702120527100be9, this patched out all relevant invocations of abort() in gnulib. While it was not documented why at the time, testing suggests that there's no abort() implementation available for gnulib to use. gnulib's position is that the use of abor

[PATCH v4 2/4] Drop gnulib fix-base64.patch

2022-02-02 Thread Robbie Harwood
Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, fix-base64.patch handled two problems we have using gnulib, which are exerciesd by the base64 module but not directly caused by it. First, grub2 defines its own bool

[PATCH] affs: Fix resource leaks

2022-02-02 Thread Alec Brown
In commit 178ac5107389 (affs: Fix memory leaks), fixes were made to grub_affs_iterate_dir() to prevent memory leaks from occuring after it returns without freeing node. However, there were still some instances where node was causing a memory leak when the function returns after calling grub_affs_cr

[PATCH 1/4] util/grub-module-verifierXX.c: Add function to calculate section headers

2022-02-02 Thread Alec Brown
Added the function get_shdr() which returns the section header at a given index parameter passed into this function. This helps traverse the section header table and reduces repeated calls to lengthy equations used to obtain section headers. Note that it may look as though the argument *arch isn't

[PATCH 3/4] util/grub-module-verifierXX.c: Validate elf section header table index for section name string table

2022-02-02 Thread Alec Brown
In grub-module-verifierXX.c, the function find_section() uses the value from grub_target_to_host16 (e->e_shstrndx) to obtain the section header table index of the section name string table, but it wasn't being checked if the value was there. According to the elf(5) manual page, "If the index of se

[PATCH 0/4] Clean up code and fix coverity bugs in util/grub-module-verifierXX.c

2022-02-02 Thread Alec Brown
Coverity identified several untrusted loop bounds in util/grub-module-verifierXX.c. This patch series addresses these bugs, cleans up lengthy equations, and makes checks to values based on the elf manual page. The Coverity Bugs being addressed are: CID 314021 CID 314027 CID 314033 Alec Brown (4):

[PATCH 4/4] util/grub-module-verifierXX.c: Add module_size parameter to functions for sanity checking

2022-02-02 Thread Alec Brown
In grub-module-verifierXX.c, the function grub_module_verifyXX() performs an initial check that the ELF section headers are within the module's size but doesn't check if the sections being accessed have contents that are within the module's size. In particular, we need to check that sh_offset and s

[PATCH 2/4] util/grub-module-verifierXX.c: Validate number of elf section header table entries

2022-02-02 Thread Alec Brown
In grub-module-verifierXX.c, grub_target_to_host16 (e->e_shnum) is used to obtain the number of section header table entries, but it wasn't being checked if the value was there. According to the elf(5) manual page, "If the number of entries in the section header table is larger than or equal to SH