Re: [PATCH 1/1] fat: fix listing the root directory

2022-01-22 Thread Vladimir 'phcoder' Serbinenko
Inserting dummy date of 1970-1-1 is a bad idea. Can we rather allow timestamp to be missing instead of throwing error? On Fri, Jan 21, 2022 at 8:33 PM Heinrich Schuchardt wrote: > > ls / for a FAT partition leads to > >error: invalid modification timestamp for /. > > Not all entries of the di

[PATCH 1/1] efi: correct struct grub_efi_boot_services

2022-01-22 Thread Heinrich Schuchardt
The UEFI specification defines that the EFI_BOOT_SERVICES.Exit(() service may return EFI_SUCCESS or EFI_INVALID_PARAMETER. So it cannot be __attribute__((noreturn)). Signed-off-by: Heinrich Schuchardt --- include/grub/efi/api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH 1/1] fat: fix listing the root directory

2022-01-22 Thread Heinrich Schuchardt
On 1/22/22 10:07, Vladimir 'phcoder' Serbinenko wrote: Inserting dummy date of 1970-1-1 is a bad idea. Can we rather allow timestamp to be missing instead of throwing error? This function seems only to be used for validation of the timestamp. I never have seen the ls command in GRUB actually di