Re: [PATCH] cryptodisk: Fix Coverity use after free bug

2022-01-13 Thread Daniel Kiper
On Sat, Jan 01, 2022 at 03:48:25PM -0600, Glenn Washburn wrote: > The Coverity output is: > > *** CID 366905: Memory - illegal accesses (USE_AFTER_FREE) > /grub-core/disk/cryptodisk.c: 1064 in grub_cryptodisk_scan_device_real() > 1058 cleanup: > 1059 if (askpass) > 1060

Re: [PATCH v4] misc: Allow selective disabling of debug facility names

2022-01-13 Thread Daniel Kiper
On Sat, Jan 01, 2022 at 11:02:59PM -0600, Glenn Washburn wrote: > Sometimes you only know which debug logging facility names you want to > turn off, not necessarily all the ones you want enabled. This patch allows > the debug string to contain facility names in the $debug variable which are > prefi

Re: [PATCH] http module is not checking correctly HTTP headers

2022-01-13 Thread Javier Moragon
I'm sorry, it's my first time using a mailing list for publishing patches so I sent you the message directly instead of to grub-devel and my mail client wrapped the patch lines. I attached the patch Instead of pasting the diff, I hope this time the lines don't get wrapped. El jue, 13 ene 2022 a la

[PATCH] http module is not checking correctly HTTP headers

2022-01-13 Thread Jamo
From: Javier Moragon I applied the last suggestion in this patch and I've finally realized how to use git send-email. I'm sorry for the unnecesary mails and I hope for next contributions I won't make the same mistakes, Thank you! --- grub-core/net/http.c | 6 +++--- 1 file changed, 3 insertio

Re: [PATCH] http module is not checking correctly HTTP headers

2022-01-13 Thread Glenn Washburn
On Thu, 13 Jan 2022 23:14:54 +0100 Javier Moragon wrote: > I'm sorry, it's my first time using a mailing list for publishing > patches so I sent you the message directly instead of to grub-devel > and my mail client wrapped the patch lines. I attached the patch > Instead of pasting the diff, I ho

Re: [PATCH] http module is not checking correctly HTTP headers

2022-01-13 Thread Glenn Washburn
On Fri, 14 Jan 2022 00:05:59 +0100 Jamo wrote: > From: Javier Moragon > > I applied the last suggestion in this patch and I've finally realized > how to use git send-email. > > I'm sorry for the unnecesary mails and I hope for next contributions > I won't make the same mistakes, Thank you! N